I think what your English teacher told you is right, as far as it goes; but there is a middle ground it does not address, where either may be used. I imagine that very often this is what you are hearing.
The even clause may be neither hypothetical nor concessive but 'occasional'—that is, it may refer to a condition which is sometimes true and sometimes not. In such a case you might use even if or even though, because both are contextually equivalent to even when:
You should eat breakfast every morning, even if/though/when you're hung over.
Even if/though/when he's sometimes over my head, I enjoy Prof. Sartorius' lectures.
In formal contexts you would probably adjust these sentences a little to fit the conjunction more precisely:
... even though you may be hung over
Even when he's over my head ...
But those are niceties which are not required in ordinary conversation.
Note that "What for?" is informal/conversational.
"What Purposeful Reason?"
"What for" denotes a purposeful reason, while "Why?" can be used for causes, reasons, or explanations.
- Statement 1: "I am going to work now."
- Why? (Explanation): "Because it's time for me to leave."
Why? OR What for? (Purpose): "To make money."
Statement 2: "Things fall."
- Why (explanation): "Because of gravity..."
- Why (Purpose): "Because of gravity." / "No, I mean, why is it like that? Why is there gravity?" / "Who knows? That's just the way it is. God? Quantum Multiverse? That may not be answerable."
What for (purpose only!): "Who knows? God? Quantum Multiverse? That may not be answerable."
Statement 3: "I exist."
- Why (Explanation/Cause): "Because your parents had sex, your mother got pregnant, and you were born."
- Why OR What for? (Purpose): "In order to propagate the species." OR "For God's mysterious reason." OR "Nobody knows." OR "There is no purpose; it's a quantum multiverse."
Variations can be created by sentences like "What is $NounPhrase$ for?" For example, if one is in a new car with a salesman, one can ask "What is that button for?" In this case, the question is asking for the functional purpose of the button. Also, "What is math good for?" is asking for suitability for a purpose.
"What for!?" -- Emphasis / Surprise / Suspicion
"What for" can lend itself to more emotion than a simple "Why", adding surprise, suspicion, or just more emphasis. In this case, "what for" can be asking for an explanation just like "why":
- Statement 4: "I am going to work now."
- What for!? You just got home! (Surprise/Explanation): / "Because I left my wallet there."
The emotion behind "What for?" can also be suspicion or interrogation. There can be a bit of eye squinting or head tilting:
"Can I ask you your name?"
"Ummm. What for?" (Suspicion)
"For what?" -- Identifying ambiguity.
"What for" can also be used to mean "For what?" in order to identify an ambiguous reference. The emphasis is on replacing the "what" with the named item rather than replacing the "for" with the named reason:
- "I'm looking for something." / "For what?" / "For my glasses."
- "I'm looking for something." / "What for?" / "My glasses." (Same as "For what")
- "What are you looking for?" / "My glasses."
Here's another one:
- "I need some help." / "What for?" / "To reach that top shelf." / "Ok, what for?" / "That coffee mug."
Both "what for" questions could be asking for purposeful reason. For example, in the 2nd case, the reason could have been to clean the shelf. But the answer given in the 2nd case was an identification of the object desired.
Also, "What am I responsible for?" is asking for identification of responsibilities. It is like "For what am I responsible?", but the fronted what sounds more natural.
Best Answer
If you know that he did go (to some place X) then you could use either expression to ask the same question. The second version ("Why did he go?") is possibly stronger sounding because it confirms that he did go to X.
If you do not know whether or not he did go to X, then you would use the "Why would he go?" question to ask the reason he might have wanted to go to X, without actually saying that he did go to X. You could also use this version of the question if you knew he went to X, but do not want to admit to knowing this.