"What did I say?" I come across this line generally.
What is wrong with this line "What have I said?"
Learn English – What have I said vs What did I say
past-simplepast-tensepast-vs-present-perfectpresent-perfect
past-simplepast-tensepast-vs-present-perfectpresent-perfect
"What did I say?" I come across this line generally.
What is wrong with this line "What have I said?"
Best Answer
When a parent is reminding a child of a previously stated rule, "What have I said?" and "What did I say?" both work:
However, when someone is wondering what they said to offend people, or humorously suggesting that they may have said something to scare people away, "What did I say?" is the conventional form - not "What have I said?". I am not sure what is wrong with "What have I said?", but it isn't used in this situation.
On the other hand, if someone is asking whether they've just said something offensive, "Did I say something to offend?" and "Have I said something to offend?" both work.