Solidity – Fixing Invalid Type for Argument in Function Call: Address to Address Payable

payableselfdestructsolidity

function endSuply() public {
    require(msg.sender == admin,"only admin can end the token sale");
    require(tokenContract.transfer(admin, tokenContract.balanceOf(address(this))),"balance not transferring");

    selfdestruct(admin);
}

here admin is a state variable declared as address admin;

But the error pops up and doesn't compile !

I just need to disable the contract, how can it be done ?

Best Answer

Elsewhere in the contract, find address admin; and declare it as address payable admin;.

Alternatively, selfdestruct(msg.sender); because require(msg.sender == admin); ensures they are the same and msg.sender should be payable.

A word of caution. selfdestruct is an inelegant way to stop a contract and could lead to non-trivial problems. Consider using Open Zeppelin Pausable.sol instead.

Hope it helps.

Related Solutions

Solidity – Resolving TypeError: Invalid Type for Argument in Function Call

The comment says implicit conversion from contract DappTokenSale to address.

So just use an explicit conversion instead - change this to address(this).

Solidity, Storage, Truffle Contract, Struct – Invalid Type for Argument in Function Call: Invalid Implicit Conversion from Mapping

If I'm not mistaken, you'll find problems as you try to write a struct from memory to storage.

I don't see where grapes was defined but it looks like a mapping, so I'll assume it is.

Change this:

grapes[previousGrapesId] = Grapes ({
 grapesId: previousGrapesId,
 notes: _notes,
 vintageYear: _vintageYear,
 farmOwner: msg.sender,
 GrapeState: GrapeState.Harvested,
 farm: farms[farmId].farmName
});

to this style:

Grapes storage g = grapes[previousGrapesId];
g.notes = _notes;
g.vintageYear = _vintageYear;
g.farmOwner = msg.sender;
g.GrapeState = GrapeState.Harvested;

I think your enum has an issue. It should be:

g.state = GrapeState.Harvested;

and

g.farm = farms[farmId].farmName;

g is a storage pointer. https://blog.b9lab.com/storage-pointers-in-solidity-7dcfaa536089

It's redundant to store the grapesId in the struct in most cases. For example, if the structs are stored in a mapping, then one needs to know the id to fetch an instance. In that case, it doesn't help to return the id the caller already knows. These patterns might give you some ideas: Are there well-solved and simple storage patterns for Solidity?

Hope it helps.

Best Answer

Related Solutions

Solidity – Resolving TypeError: Invalid Type for Argument in Function Call

Solidity, Storage, Truffle Contract, Struct – Invalid Type for Argument in Function Call: Invalid Implicit Conversion from Mapping

Related Topic