Solidity Syntax Error – Expected Primary Expression Fix

remixsolidity

I'm trying to make a function that includes a for loop and an if/if else statement and am running into errors. The syntax regarding where to put the brackets here confuses me.

function decider(nbaTeam[] memory team) public {
    for(uint i=0; i < 31; i++) {
    if (team[i].oRtg > avgOrtg && team[i].dRtg < avgDrtg) {
        niceTeams.push(team);
    }
    }   else if (team[i].oRtg <= avgOrtg && team[i].dRtg >= avgDrtg) {
        naughtyTeams.push(team);
    }
    }

"Expected primary expression." error on the else if statement line.

Best Answer

If you indent the code properly you'll see that there's an extra } before the else if. In solidity braces are used to surround block of codes {}.

function decider(nbaTeam[] memory team) public {
    for (uint i=0; i < 31; i++) {
        if (team[i].oRtg > avgOrtg && team[i].dRtg < avgDrtg) {
            niceTeams.push(team);    
        } else if (team[i].oRtg <= avgOrtg && team[i].dRtg >= avgDrtg) {
            naughtyTeams.push(team);
        }
    }
}

Related Solutions

Solidity – Compile Error: Expected Primary Expression

Here's your modified code:

pragma solidity ^0.4.0;

contract user {

    address public owner;

    function user() {
        owner = msg.sender;
    }

    function kill() {
        suicide(owner);
    }

    modifier onlyOwner {
        if (msg.sender != owner) {
            throw;
        } else {
            _;
        }
    }
}

The only problem with your code is that I had to replace your - with a _;. See Are underscores `_` in modifiers code or are they just meant to look cool? for more information on the _ modifiers.

Your modified code then compiles perfectly in the Solidity realtime compiler and runtime:

Solidity – How to Resolve Remix Compilation Error: Invalid Array Length, Expected Integer Literal or Constant Expression

I changed your smart contract implementation with this smart contract.

I put notes just so you'd know your errors.

// SPDX-License-Identifier: MIT
pragma solidity ^0.8.0;

// NOTE: Import IERC20 contract
import "@openzeppelin/contracts/token/ERC20/IERC20.sol";

// NOTE: You must to implement IERC20 for override ERC20 methods!
contract NewToken is IERC20 {

  string public constant name = "NewToken";
  string public constant symbol = "NTKN";
  uint8 public constant decimals = 18;
  uint256 totalSupply_ = 10000000000000000000000000; 

  mapping(address => uint256) public balances;
  mapping(address => mapping (address => uint256)) allowed;

  // NOTE: I removed the events because it already defined into IERC20
  
  constructor() { 
    balances[msg.sender] = totalSupply_;
  }

  function totalSupply() public override view returns (uint256) {
    return totalSupply_;
  }

  // NOTE: You must to change signature function adding address parameter
  function balanceOf(address _address) public override view returns(uint256) {
    return balances[_address];
  }

  function transfer(address to, uint256 value) public override returns (bool) {
      require(value <= balances[msg.sender]);
      balances[msg.sender] = balances[msg.sender]-value;
      balances[to] = balances[to]+value;
      // NOTE: The event is called  Transfer not 'transfer'
      emit Transfer(msg.sender, to, value);
      return true;
  }

  function approve(address spender, uint256 value) public override returns (bool) {
      allowed[msg.sender][spender] = value;
      emit Approval(msg.sender, spender, value);
      return true;
  }

  function allowance(address owner, address spender) public override view returns (uint) {
      return allowed[owner][spender];
  }

  function transferFrom(address from, address to, uint256 value) public override returns (bool) {
      require(value <= balances[from]);
      require(value <= allowed[from][msg.sender]);

      balances[from] = balances[from]-value;
      allowed[from][msg.sender] = allowed[from][msg.sender]+value;
      balances[to] = balances[to]+value;
      emit Transfer(from, to, value);
      return true;
  }
}

Best Answer

Related Solutions

Solidity – Compile Error: Expected Primary Expression

Solidity – How to Resolve Remix Compilation Error: Invalid Array Length, Expected Integer Literal or Constant Expression

Related Topic