solidity – How to Update a Storage Variable in Solidity

solidity

I am new in Solidity, please advise.

I have a code

    uint public bal = address(this).balance;
    
    function getBalance() public view returns (uint) {
            return address(this).balance;
    }

bal variable is 0 by default. I sent 10 Wei to the contract and when I check the bal again – it is still 0. I check the balance with getBalance() function and it shows
10 as expected. Why bal was not updated even it was stated as a global variable? Thank you!

Best Answer

Variable bal is returning zero, because at the time of declaring this variable the contract balance was zero. This variable is stored in the state of the contract and it is not dynamically reading the current contract balance.

If for whatever reason you need bal variable to be up to date with the contract balance then on each address(this).balance call you will have to update bal value as well.

Related Solutions

Solidity – Handling Unimplemented Functions in Contracts

The problem is that totalSupply() implementation is missing. Seems like autogenerated getters do not count. So you need to explicitly create the function.

contract StandardToken is Token {
    uint256 _totalSupply;

    function totalSupply() constant returns (uint256 totalSupply) {
        totalSupply = _totalSupply;
    }
}

Solidity – How to Resolve Remix Compilation Error: Invalid Array Length, Expected Integer Literal or Constant Expression

I changed your smart contract implementation with this smart contract.

I put notes just so you'd know your errors.

// SPDX-License-Identifier: MIT
pragma solidity ^0.8.0;

// NOTE: Import IERC20 contract
import "@openzeppelin/contracts/token/ERC20/IERC20.sol";

// NOTE: You must to implement IERC20 for override ERC20 methods!
contract NewToken is IERC20 {

  string public constant name = "NewToken";
  string public constant symbol = "NTKN";
  uint8 public constant decimals = 18;
  uint256 totalSupply_ = 10000000000000000000000000; 

  mapping(address => uint256) public balances;
  mapping(address => mapping (address => uint256)) allowed;

  // NOTE: I removed the events because it already defined into IERC20
  
  constructor() { 
    balances[msg.sender] = totalSupply_;
  }

  function totalSupply() public override view returns (uint256) {
    return totalSupply_;
  }

  // NOTE: You must to change signature function adding address parameter
  function balanceOf(address _address) public override view returns(uint256) {
    return balances[_address];
  }

  function transfer(address to, uint256 value) public override returns (bool) {
      require(value <= balances[msg.sender]);
      balances[msg.sender] = balances[msg.sender]-value;
      balances[to] = balances[to]+value;
      // NOTE: The event is called  Transfer not 'transfer'
      emit Transfer(msg.sender, to, value);
      return true;
  }

  function approve(address spender, uint256 value) public override returns (bool) {
      allowed[msg.sender][spender] = value;
      emit Approval(msg.sender, spender, value);
      return true;
  }

  function allowance(address owner, address spender) public override view returns (uint) {
      return allowed[owner][spender];
  }

  function transferFrom(address from, address to, uint256 value) public override returns (bool) {
      require(value <= balances[from]);
      require(value <= allowed[from][msg.sender]);

      balances[from] = balances[from]-value;
      allowed[from][msg.sender] = allowed[from][msg.sender]+value;
      balances[to] = balances[to]+value;
      emit Transfer(from, to, value);
      return true;
  }
}

Best Answer

Related Solutions

Solidity – Handling Unimplemented Functions in Contracts

Solidity – How to Resolve Remix Compilation Error: Invalid Array Length, Expected Integer Literal or Constant Expression

Related Topic