Foundry – vm.expectRevert Not Working as Expected

.call() pretends to do the transaction and gives you the result but doesn't commit any changes back to the blockchain.

You can find more details at Truffle docs but it will say basicly that

When you execute a contract function via a call you will receive the return value immediately

Executing getGift after offerGift.call(...) will not work because idCounter wasn't updated.

You have to contract.offerGift('coffee', fiveDollars, giftReceiverAddress, {from: giftGiverAddress}); and you will get the tx object. Then you have to check if it was mined and then get the log and from the log event, get the gift id that you were expecting. You won't get the return value.

I found an answer, I should've used Promise.all as the guy mention in the question here, i get the promise code snippet from here, thanks to @Mavcom.ETH for guiding me here

The difference between Promise.all and Await inside a for loop is that looping in execution time, it will stop and await until the call is done to continue the loop in contrast to the promise.all which does all the calls and wait for them asynchronously which can be faster if the order of the calls doesn't matter

        let signers: Wallet[] = [];
    
        //create 100 wallets
        for (let i = 0; i < 100; i++) {
          //create a new wallet
          let wallet = ethers.Wallet.createRandom().connect(ethers.provider);
          //can store as signer
          signers.push(wallet);
          //can store as address
          addressArray.push(wallet.address.toString());
        }
    
        const checkTheirNFT = () => {
          return Promise.all(
            signers.map(async fooSigner => {
              expect(await yourNFTContract.connect(fooSigner).balanceOf(fooSigner.address, 1)).to.be.equal(0);
              console.log(`fooWallet: ${fooSigner.address}`);
            })
          ).then(() => {
            console.log("done");
          });
        };
        await checkTheirNFT();

      });