Unlike in Diablo II, on-hit elemental damage is simply that - bonus damage, with the sole exception of cold damage (which has a small snare). Frost damage does a little less damage comparatively because of this.
While there was originally a more complex critical hit system (as documented below), that functionality did not make it to the final game.
Critical hits just add damage.
Historical Answer:
More interestingly, in the Diablo III Beta, each type of damage has a different effect on a critical.
Physical: Double Damage
Arcane: Silences targets for 4 seconds (prevents abilities)
Cold: Freezes targets for 2 seconds (Duration can be affected by talents, etc.)
Fire: Sets them on fire, fire DoT (tick rate scales off weapon speed)
Lightning: Stuns targets for 2 seconds (Duration can be affected by talents, etc.)
Poison and Holy presumably have effects on a critical hit also, but I haven't been able to find info on them.
I just ran a few tests because I was curious on this and wanted to know myself since I'm maining a Witch Doctor. My findings are as follows.
Testing Method: I used the abilities on a monster (or multiple) and watched damage against them. I removed gear and equipped it while DoTs were ticking on targets, and I also used INT Boost abilities while DoT effects were ticking on targets. To test Spiders I did something similar but had to time it better. I also had no runes active and no passives active. I didn't try to get screenshots, but if you'd like me to redo the test and try to get good screenshots let me know and I'll edit them in.
Scenario 1: Grasp of the Dead - Gaining INT while Grasp of the Dead is already on the ground does not appear to effect Grasp of the Dead's damage. Damage is calculated when spell is cast and damage dealt doesn't appear to change when INT is increased post cast.
Scenario 2: Corpse Spiders (already thrown) - Gaining INT while Spiders are already on the ground does not appear to effect Corpse Spiders' Damage. This was also true for Tiki Men.
Scenario 3: Haunt and Locust Swarm - Gaining INT while Haunt and Locust Swarm are already on a target does not appear to effect Haunt and Locust Swarm's Damage. Additionally, the damage of Locust Swarm bounces ALSO does NOT appear to be effect by INT gains.
Scenario 4: Summoned Pets/Minions - As far as damage is concerned: Damage is calculated for Gargantuan ON HIT. Meaning when he swings at a mob your stats at that moment are the deciding factor on how much he hits. This was also true for Zombie Dogs. I was not able to test if and how INT effects their other stats because I don't know a way to display that information for summoned minions.
Additionally, I also tested if weapon damage being applied changes the situations and all of the above scenarios are still true.
These tests show the following:
1) Damage calculation for persistent effects (DoTs, AoE Damage Pools, Non-Minion Summoned Creatures, and etc) is calculated as soon as the spell is cast and damage is not retroactively applied when the player's stats increase.
2) Damage calculations for minions (Gragantuan and Zombie Dogs) is calculated when that minion hits a creature, thus will gain bonuses for increased INT.
These were all tested on a level 60 Witch Doctor so I can't say if they apply to all classes, but I can probably safely assume they do. I also didn't test how damage is calculated for hired mercenaries, but from the test we can also probably assume it is on hit.
An easy way to test this yourself would be to go into Act 1 of any difficulty (I suggest the highest you can go). Then go outside the first area with INT items unequiped and use abilities on the zombies in that area and then equip them mid fight, and hitting enemies with abilities like Soul Harvest and looking at the damage increase. You can display your damage dealt to enemy creatures by going to Options -> Gameplay -> and Checking "Display Damage Numbers"
Best Answer
My WD's damage stat goes up by exactly 20% when I spec Pierce the Veil. It's a +20% multiplier that's applied separately from the Intelligence bonus. It doesn't matter when 20% is applied, since multiplication is commutative.