Minecraft Java Edition, Commands – How to Create Husk and Stray Spawners

After 1.7, you can no longer refer to a block by its numeric Block ID; instead you must use its full name. Thus, you should replace 152 with redstone_block.

Also, with /setblock, you need to specify the [dataValue] before you can specify the [oldBlockHandling] mode, so you should add a 0 before delete.

Fixed command should look like:

/setblock ~ ~1 ~ minecraft:wall_sign 2 replace {Text1:"{\"text\":\"Set Gamemodes\",\"clickEvent\":{\"action\":\"run_command\",\"value\":\"/setblock -44 110 248 redstone_block 0 delete\"}}"}

In situations like this where you're setting signs that execute commands or have nested execute commands, I often find it useful to "unwrap" it and try each layer of command separately.

For example, you can try the innermost command (/setblock -44 110 248 152 delete) in chat or a command block to get a somewhat useful message that can help you with fixing the first error:

There is no such block with name minecraft:152

For situations like this, I'd recommend running the command being executed itself (the /fill command) to see what the error is.

The main error appears to be that you're trying to fill a quarter of a million blocks, which is more the maximum (32678) that Minecraft allows for. You could reduce your fill region:

/fill ~-15 ~-15 ~-15 ~15 ~15 ~15 minecraft:diamond_block 0 replace minecraft:gold_block

Or, if the huge area is important, split it up into multiple commands:

/fill ~0 ~0 ~0 ~30 ~30 ~30 minecraft:diamond_block 0 replace minecraft:gold_block
/fill ~0 ~0 ~0 ~-30 ~30 ~30 minecraft:diamond_block 0 replace minecraft:gold_block
etc.

(I'd suggest not running either of these on a clock)

That should be it, but keep in mind that the command will also fail if there are no gold blocks to replace, or if you're too low-down/high-up so that the relative coordinate are selecting an area outside of the world.