tl;dr: Items that people want to have are expensive, other items are not. I suggest using a service like poe.xyz.is to get a feeling for the value of an item you might want to sell. Especially for uniques it can give you a very good idea of an item's value.
This is a pretty open-ended question so a conclusive answer may be hard to come by. That said...
Affixes come in different brackets, or tiers. For example, % Increased Physical Damage comes in 7 tiers ranging from "Heavy" (+20..49% IPD) to "Tyrannical" (+150..169% IPD). The stronger brackets are of course more valuable, while the weaker ones may even reduce the value of an items since they prevent stronger ones from spawning.
Movement speed is incredibly important on boots since it cannot spawn on other gear, and it's rare to see a pair without MS sell at all, let alone fetching a high price.
Affixes that align well with the base item type are more expensive. E.g. Increased Critical Strike Chance is much better on a Dagger than it is on a Maul, because Daggers already have a high base crit chance and are therefore commonly used in crit builds, while Mauls are strength-aligned and often used by characters who cannot crit due to Resolute Technique.
Affixes that align well with each other can increase the value of an item - or rather, affixes that don't align can relegate an item to the vendors. A combination like % Increased Physical Damage and flat Increased Physical Damage, or +2 to Fire gems and +1 to all gems can get quite expensive, while no build I know of makes good use of both Attack Speed and Cast Speed. Especially on base types with a large mod pool (e.g. jewellery, daggers, wands, sceptres, staves) having well-aligned affixes can increase the value dramatically.
Resistances are pretty popular on socket-less items because they're easier to swap around to accommodate changes in your other gear.
With the release of Forsaken Masters, a 5-affix item may well be more valuable than that same item with a 'decent' 6th affix, because it leaves some room for the buyer to customize the item.
Corrupted items are in general less valuable than their non-corrupted variants because the sockets are locked, but if they rolled a very good corruption this is of course not the case.
It could be said that different factors have multiplicative scaling - e.g. a 6L item is expensive, and an item with good affixes is expensive, but a 6L item with good affixes will not simply be twice as expensive - it will cost you three and a half fortunes.
Let me preface, I've played hundreds of hours on hardcore only so my views on crafting differ widely to softcore where there is no removal of items for the economy.
When should I wait and when should I create?
Wait for high ilevel items, lvl 56+ is usually a good place to start. The reasoning behind this is to make sure that your not wasting currency on low level rolls.
When should I pump it and when should I lump it?
Highly subjective, generally a good rule of thumb is to look at the possible max rolls, if you have a high potential max roll and you have a low actual roll then go for it.
When should I buy it and when should I apply it?
Easy buy currency low and sell high, play the market. Selling 1 exalt today might make you 1.1/1.2 exalts tomorrow (exchanging chaos).
When should I damn it and when should I spam it?
I assume your talking about high level items/uniques. In that case always watch the market, keep an eye out for new builds that rely on certain uniques and make your money there.
When should I whet it and when should I forget it?
Whetstones and Armour Scraps are dirt cheap (look for the 40% vendor recipe). Always max your items out. There's no need to be running around without 20% everything. Also worth noting that white items get 5% per consumable apposed to 2% magic (I think) and 1% rare.
When should I hone it and when should I disown it?
Hone always, discard rarely. In any league your characters will greatly benefit from your hand me down gear. Also there is a real market for twink gear if you have some nice pieces.
Hopefully that should help!
Best Answer
The green color is not new as it was introduced during the legacy league. That is a relic version of a unique. Currently in Delve league, you can get these by finding timeworn reliquary keys. Those open up the timeworn reliquary (at the map device) which gives up to 3 of any previous league specific unique items with this special green "foil" coloring.
In the Legacy league you could find ancient reliquary keys which granted access to the ancient reliquary. In addition to the green "foil" coloring these versions had legacy stats meaning you could find legacy variants of any unique item at the time (for better or worse).