FFLIB Unit of work (fflib_ISObjectUnitOfWork) and a self-relationship field

apexfflib

I can't get FFLIB uow to work with a self-relationship field. Quick use case: Create two accounts and relate the second one with the first one using a custom lookup field (selfRelation__c)

fflib_ISObjectUnitOfWork uow = Application.unitOfWork.newInstance();

Account account1 = new Account();
account1.name = 'account1';
uow.registerNew(account1);

Account account2 = new Account();
account2.name = 'account2';
uow.registerRelationship(account2,Account.selfRelation__c,account1);
uow.registerNew(account2);

uow.commitWork();

and as a result, both accounts are created but the relation was not defined.

Any feedback?

Thanks

Best Answer

This isn't supported in the same Unit of Work - why?

Because both registerNews are collected into a single collection of Account by fflib_UnitOfWork and inserted in a single DML statement. registerRelationship only adjusts object references in memory - it does not do separate DML on its own.

Thus, the Id for account1 isn't yet known to set the lookupfield on account2

You need to do this in two units of work each with their own commitWorks(). That is, registerNew account1 in uow1, then commitWork, then registerNew/registerRelationship account2 in a new instance of uow, and commitWork on that uow.

Note also, the following four lines can be collapsed into one

Account account2 = new Account();
account2.name = 'account2';
uow.registerRelationship(account2,Account.selfRelation__c,account1);
uow.registerNew(account2);

uow.registerNew(new Account(Name = 'account2),
                Account.selfRelation__c,
                account1);

as registerNew has an overloaded signature

Worth buying if you haven't already Salesforce Lightning Platform Enterprise Architecture by Andrew Fawcett 3rd edition (4th edition is in progress from what I hear) - page 181 Unit of Work Special Considerations

... not supported ...

Self and recursize referencing

Partial success Database operations

Sending emails -- this is now supported after the release of the 3rd edition thanks to the open source community

Related Solutions

[SalesForce] Inserting Accounts With Attachments Using Wrapper Class

It lacks the code for the VFP so I wrote this one.

<apex:page standardController="Account" extensions="WrapperClassFileController">
<apex:form >
    <apex:pageBlock >
        <apex:pageBlockButtons><apex:commandButton action="{!save}" value="Save"/></apex:pageBlockButtons>            
        <apex:pageBlockSection title="Accounts">
            <apex:pageBlockTable value="{!Wrapperlist}" var="wp">
                <apex:column headerValue="Name"><apex:inputtext value="{!wp.str1}" ></apex:inputtext></apex:column> 
                <apex:column headerValue="Code"><apex:inputtext value="{!wp.str2}" ></apex:inputtext></apex:column> 
                <apex:column ><apex:inputFile value="{!wp.attached.body}" filename="{!wp.attached.name}" id="file"></apex:inputFile>
                 </apex:column>
            </apex:pageBlockTable>
        </apex:pageBlockSection>
    </apex:pageBlock>    
</apex:form>

And the problem is just the use of the properties attach and bodyvalue (unique references).

public class WrapperClassFileController {

Public List<Wrapper>Wrapperlist{get;set;}
// public String string1{get;set;}
// public String string2{get;set;}
// public Attachment attach{get;set;}
//  public Blob bodyvalue{get;set;}

public WrapperClassFileController(ApexPages.StandardController controller) 
{   
    Wrapperlist=new List<Wrapper>();
    for(Integer i=0;i<=1;i++)
    {
        String  string1='';
        String  string2='';
        Blob bodyvalue = null;
        Attachment attach = new Attachment();
        if(attach==null)
            //bodyvalue='Test';
            attach = new Attachment(Body=bodyvalue);

        Wrapperlist.add(new Wrapper(string1, string2,attach ));
        system.debug('WrapperlistWrapperlist'+Wrapperlist);
    }   
}


public void save()
{
    system.debug('>>>>>'+Wrapperlist);

    for(Wrapper wr : Wrapperlist)
    {
        Account acc = new Account();
        acc.Name=wr.str1;
        acc.Account_Code__c=wr.str2;
        insert acc;

        Attachment attach = new Attachment();
        attach.ParentId=acc.id;
        attach.ownerId=UserInfo.getUserId();
        attach.IsPrivate=true;
        attach.Description='Test Description';
        attach.name=wr.attached.name;
        attach.Body=wr.attached.body;
        system.debug('========='+ wr.attached.name + '=' +wr.attached.body);
        insert attach;
    }       
}

public class wrapper{
    public  String str1{get;set;}
    public String str2{get;set;}
    public Attachment attached{get;set;}
    //public String body {get;set;}

    public  wrapper(String string1,String string2,Attachment attach)
    {
        str1=string1;
        str2=string2;
        attached=attach;
    }
}

}

The two attachments are created.

Regards

Alain

[SalesForce] FFLIB Unit of work. how to register a relationship on both new and existing record

So, UnitOfWork will do inserts first, then updates, then deletes

I would simplify your code to look like this:

if (oldLPP != null {...} // set oldLPP fields
// set newLPP fields
...
// define scope of UoW
Schema.SObjectType[] sobjsList = new Schema.SObjectType[] { Payment__c.SObjectType};
uow = new fflib_SObjectUnitOfWork(sobjsList);

uow.registerNew(newLPP);

// build xrefs
if (oldLPP != null) {
   // new -> old
  uow.registerRelationship(newLPP,Payment__c.Merged_Into_Payment__c,oldLPP);
  // old -> new
  uow.registerDirty(oldLPP,Payment__c.Merged_Into_Payment__c,newLPP);
}
uow.commitWork();

There is of course, no rule against explicitly setting the relationship fields yourself

newLPP.Merged_Into_Payment__c = oldLPP.Id;

Best Answer

Related Solutions

[SalesForce] Inserting Accounts With Attachments Using Wrapper Class

[SalesForce] FFLIB Unit of work. how to register a relationship on both new and existing record

Related Topic