[SalesForce] Apex Loop break and continue

I want to distribute custom object records to some user. Theres 2 users inside 'assignmentList' and Im trying to distribute each records to these 2 users based on the inputted max amount of call line they can handle. If their (inputted max amount – total distributed record amount) > 0.

I tried to loop the records and for each record, I loop the assignmentList, which is the users. But when the user amount reach its maximum amount, the 'continue' never skip to the next iteration of the loop, so the records only assigned to the 1st user. How should I skip the iteration?

map <String,tempUserAssignment> mapByManualAmount = new map <String,tempUserAssignment>();
        Decimal tempClAmount = 0;
        Decimal tempMaxAmount = 0;
        for(Call_Line__c dis : callLineList){
            tempClAmount = dis.APE_Total_Child__c;
            for(AgentAssignment assignm : assignmentList){
                tempMaxAmount = assignm.apeDistributed;
                if(mapByManualAmount.containsKey(assignm.agentId)){
                    tempUserAssignment tua = new tempUserAssignment();
                    tua.totalPolicy = mapByManualAmount.get(assignm.agentId).totalPolicy + 1;
                    tua.totalAPE = mapByManualAmount.get(assignm.agentId).totalAPE + dis.APE_Total_Child__c;

                    if ((tempMaxAmount - tua.totalApe) > 0){
                        system.debug('***tua.totalAPE:'+tua.totalAPE);
                        tosaveCallLine = new Call_Line__c();
                        tosaveCallLine.id = dis.id;
                        tosaveCallLine.Agent__c = assignm.agentId;
                        tosaveCallLine.ownerId = assignm.agentId; 
                        //tosaveCallLineList.add(tosaveCallLine);   
                        mapByManualAmount.put(assignm.agentId, tua);
                        break;
                    }
                    else {
                        continue;
                    }
                }
                else{
                    tempUserAssignment tua = new tempUserAssignment();
                    tua.totalPolicy = 1;
                    tua.totalAPE = dis.APE_Total_Child__c;

                    mapByManualAmount.put(assignm.agentId, tua);
                    break;
                }    
            }
        }

Best Answer

break and continue work on the innermost loop.

Your logic is complicated, and can be greatly reduced by prewarming the map.

Also, you should check to see if the item should be created before modifying the tempUserAssignment object.

All of the optimizations so far end up looking like this:

Map<String,tempUserAssignment> mapByManualAmount = new map <String,tempUserAssignment>();
for(AgentAssignment assignm: assignmentList) {
    tempUserAssignment tua = new tempUserAssignment();
    tua.totalPolicy = 0.0;
    tua.totalAPE = 0.0;
    mapByManualAmount.put(assignmentList.agentId, tua);
}

for(Call_Line__c dis : callLineList){
    for(AgentAssignment assignm : assignmentList) {
        tempUserAssignment tua = mapByManualAmount.get(assignm.agentId);
        if(tua.totalApe + dis.APE_Total_Child__c <= assignm.apeDistributed) {
            tua.totalPolicy += 1.0;
            tua.totalAPE += dis.APE_Total_Child__c;
            tosaveCallLineList.add(new Call_Line__c(Id=dis.Id, Agent__c=assignm.agentId, OwnerId=assignm.agentId));
            break;
        }
    }
}

However, if you're looking for more of a balanced distribution system, you can also rework the code so that each person gets first shot at a record:

for(Call_Line__c dis : callLineList){
    for(AgentAssignment assignm : assignmentList) {
        // code from above //
    }
    // The first becomes last, and the second becomes first, a "rotate-left" operation.
    assignmentList.add(assignmentList.remove(0));
}

Related Solutions

[SalesForce] Problem with a trigger loop

Not something I can test locally, but some things I changed looking at it:

I use a Set to keep track of all possible names before querying, to filter out duplicates. I calculated the arrays of names once and stored those arrays in an array of the same length and indices as the trigger.new array. (We've found that pre-allocating arrays of known length doesn't make much different to CPU governor usage, especially here as the array is no bigger than 200).

Set<String> allSubAccountNames = new Set<String>();
List<List<String>> subAccountNamesByOverview = new List<List<String>>;

for (Contract_Overview__c newCont : Trigger.New) 
{
   String[] subAccountNames = splitField(newCont.Subsidiaries_On_Contract__c);
   allSubAccountNames.addAll(subAccountNames);
   subAccountNamesByOverview.add(subAccountNames);
}

Map<String, Id> subAccIdsByName=new Map<String, Id>();
for (SubsidiariesAndBrands__c subAcc : [select id, Name from SubsidiariesAndBrands__c where Name in :allSubAccountNames]) 
{
   subAccIdsByName.put(subAcc.Name, subAcc.id);
}

My split function is

private String[] splitField(String value)
{
   value = value.replaceAll('\[|\]','');
   return value.split(',');
}

It may be possible to do this in a single REGEX, but we become more obtuse.

The other main difference is I did an insert not an upsert at the end as they're new records.

List<Subs_Serviced_On_Contract__c> subs = new List<Subs_Serviced_On_Contract__c>();
for (Integer i = 0; i < Trigger.New.size(); i++) 
{
    Contract_Overview__c newContract = Trigger.New[i];
    String[] subAccountNames = subAccountNamesByOverview[i];

    for(String subName : subAccountNames)
    {
        Id subId = subAccIdsByName.get(subName);
        System.assert(subId != null, 'Failed to find subaccount by name ' + subName);

        Subs_Serviced_On_Contract__c ssoc = new Subs_Serviced_On_Contract__c(
            Name = subName,
            Contract_Overview__c = newContract.Id,
            Account__c = newContract.Account__c
            Subsidiaries_and_Brands__c = subId,  
            Contract_and_Sub__c = newContract.Name + '~' + subName,
            Contract_Start_Date__c = newContract.Contract_Start_Date__c,
            Contract_End_Date__c = newContract.Contract_End_Date__c, 
            Logo_Usage_Allowed__c = 'Yes');

        subs.add(ssoc);
    }
}
insert subs;

[SalesForce] How to run multiple test scenarios in one test code, for the Same APEX code

Depending on how complicated the terms of the if statement are I'd do different things.

If it's a simple switch based on some user input then doing it in one method is perfectly fine, if things are more complicated than that it's often easier to read and understand the test code when you have a method per scenario.

You can often write the tests for an entire controller in a single method, but it can get messy and test code is something you will always be coming back to in order to update and fix it as it depends on so many other factors; therefore it's code that you want to be as easy to maintain as possible, so let that guide your decision.

Your particular issues sound like issues with your test code and you should post that for help with it, but there's no reason why you shouldn't be able to delete the account you've created and inserted. Also, consider whether you need to delete it or if updating the record will be enough.

Best Answer

Related Solutions

[SalesForce] Problem with a trigger loop

[SalesForce] How to run multiple test scenarios in one test code, for the Same APEX code

Related Topic