[SalesForce] Apex Trigger – Move Attachments from Task to Account

I have a user which attached JPGs to the wrong object (Task vs Account). I wrote this trigger thinking I could quickly fix it but I am getting this error:

Error: Compile Error: Illegal assignment from LIST to SOBJECT:Account at line 9 column 13

Help! 😀

trigger Update_Attachment_Parent on Attachment (after insert, after update) {
//Create a List to store the Ids of Attachments to be deleted
List<Id> forDeletionIds = new List<Id>();
for (Attachment a : trigger.new){
    //Check to see if the Attachment has a Task as the Parent Record
    String parentIdString = String.valueof(a.parentId);
    if (parentIdString.substring(0,3) == '00T'){
        //Select the AccountId from the Task
        Account parent = [SELECT AccountId FROM Task WHERE WhatId = :a.parentId];
        //Check to see if the Account exists
        if (parent.AccountID != null){
            //Select the Attachment body (it isn't in memory for an update)
            Attachment body = [SELECT Body FROM Attachment WHERE Id = :a.Id];
            //Create a new Attachment, preserving as much as is possible
            Attachment newA = New Attachment(
                Name = a.Name,
                Body = body.Body,
                ContentType = 'image/jpeg',
                Description = 'Account Photo',
                OwnerId = a.OwnerId,
                ParentId = parent.AccountId
            );
            //Insert the new Attachment
            insert newA;
            //Add the now duplicate Attachment ID to a list
            forDeletionIds.add(a.Id);
        }
    }
}
//List and then delete all duplicate Attachments
List<Attachment> forDeletion = [SELECT Id FROM Attachment WHERE Id IN :forDeletionIds];
delete forDeletion;
}

Best Answer

Account parent = [SELECT AccountId FROM Task WHERE WhatId = : a.parentId];

i think it is

task  parent =[SELECT AccountId FROM Task WHERE WhatId = : a.parentId];

There is a illegal assignment from task to account

Related Solutions

[SalesForce] Move EmailMessage’s attachments from one Case to another

Sethu

I did think about this and here is a condensed answer

Given that an incoming EmailMessage may not have any Attachments, then a trigger on Attachment won't work as it would never fire if an attachment-less EmailMessage arrived.

A trigger on EmailMessage wouldn't work as it would miss the attachments added after the EmailMessage trigger executed

So, the general approach to take is for the EmailMessage trigger to create the clone Case and:

include in the cloned Case the ID of the original Case
a boolean flag that says is_emailMsg_reparenting_required__c

Then, you can use your favorite async pattern to soql query all the cloned Cases waiting the email reparenting and then do the reparenting through APEX DML, resetting the boolean flag when done

I'd look first at @future but I'm not sure you can guarantee that the future will always run after the Attachments are inserted as the transaction context of EmailToCase is not known to me without more research

Other options would be an apex class implementing the new queueable interface, a scheduled apex class that runs regularly, or the Dan Appleman Async Apex Design Pattern which is quite elegant and can run every few seconds handling all your async needs, not just this particular use case.

[SalesForce] Unit Test is Providing 0% Coverage for Apex Trigger

The trigger code is having lot of redundancy, So I modified it. before posting the modified code few lines of explanation what I changed. you collected account Ids twice and did the condition check twice where once is more enough. I am also made changes to the test class, where Task data is provided which is not required because the trigger has to create it once the necessary conditions are met. I am expecting this trigger should work for you, if there is any errors feel free to post as a comment.

trigger OpportunityAfter on Opportunity (after update){

    Set AccountIDs = new Set();

    for(Opportunity o : trigger.new){
        if(opp.StageName == 'Closed - Lost' && opp.Business_Line__c == 'Workforce' && 
            opp.Survey_Type__c != 'APulse' && trigger.oldMap.get(opp.Id).StageName != opp.StageName){

                AccountIDs.add(o.AccountId);
         }
    }

    Task[] tasksToInsert = new Task[]{};

    for (Account acc : [Select Id, Name, OwnerId from Account where Id IN :AccountIds]){
        for (Opportunity opp : trigger.new){
            if(opp.AccountId == acc.Id){
                Task tas = new Task();
                tas.WhatId=acc.Id;
                tas.OwnerId=opp.OwnerId;
                tas.Subject='Follow-up: ' + opp.name + ' - ' + acc.name;
                tas.ActivityDate=(opp.CloseDate + 180);
                tas.Description='Follow up to see how engagement initiatives are going and if Avatar can help. Refer to lost opportunity: ' + opp.name;
                tasksToInsert.add(tas);                                                         
            }
        }
    }
    if(tasksToInsert != null && !tasksToInsert.isEmpty())
    Database.insert(tasksToInsert);

}

@isTest
public class TestClass {

    static testMethod void myUnitTest() {

    //Set up user
    User u1 = [SELECT Id FROM User WHERE Email='abc@sampleemail.com'];
    test.startTest();  
    //Run As U1
    System.RunAs(u1){

    System.debug('Testing trigger... (single record validation)');

    //NEW Account record
    Account acc = new account();
    acc.Name = 'Test Account';
    acc.Industry = 'Healthcare';

    insert acc;

    //NEW Opportunity record
    Opportunity opp = new Opportunity();
    opp.Name = 'Test Opportunity'; 
    opp.CloseDate = System.today();
    opp.StageName = 'S1 - Investigative';
    opp.Type = 'Repeat Business - Wrkforce HC';
    opp.AccountId = acc.Id;
    opp.Survey_Type__c = 'Product Name';

    insert opp;

    opp.StageName = 'Closed - Lost';
    opp.Reason_Won_Lost__c = 'Relationship';
    opp.Business_Line__c = 'Workforce'  //added this line to meet the if condition while collecting the set of id in the trigger.

    update opp;
   test.stopTest();
    // Here I am expecting the task has been inserted and doing a query for it         and check it in the assert statement.
   Task  testTask=[Select Id, WhatId from Task where WhatId=:acc.Id];
    //Validate single insert
    System.assertEquals(acc.Id, testTask.WhatId);

    }
    }
}

Best Answer

Related Solutions

[SalesForce] Move EmailMessage’s attachments from one Case to another

[SalesForce] Unit Test is Providing 0% Coverage for Apex Trigger

Related Topic