[SalesForce] API Callout (apex class) from workflow – You have uncommitted work pending,please commit before calling out

I want to make an api call to an external webservice, parse the result and create records with the results. I started by Creating a class to do those steps, called the apex in a workflow providing the inputs from the calling record. I then created a process to start the workflow when an organisation (Account) is created or updated. However, I get the exception

"Error Occurred: An Apex error occurred: System.CalloutException: You
have uncommitted work pending. Please commit or rollback before
calling out".

I believe this is because you cannot have a call out AND DML operations in the same transaction, so to narrow down the problem I altered the apex class to ONLY do the api call out (not even take inputs, and to return null – But I still get the same exception.

I started by implementing Process.Plugin, but now I am using @InvocableMethod – Same issue with both.

Example Apex class, part of workflow started by process –

global class invokeAreasCallout{
    @InvocableMethod(label='Areas Callout')
    //global static List<String> doAreaCallout(List<String> postcode) {
    global static List<String> doAreaCallout() {

        String postcode='B302PF';
        HttpResponse res;
        // Instantiate a new http object
        Http h = new Http();

        // Instantiate a new HTTP request, specify the method (GET) as well as the endpoint
        HttpRequest req = new HttpRequest();
        String requestURL='http://mapit.mysociety.org/postcode/';
        requestURL=requestURL+postcode;
        req.setEndpoint(requestURL);
        req.setMethod('GET');

        // Send the request, and return a response
        res = h.send(req);

       return null;
    }
}

Best Answer

You can't callout during the life cycle of a DML operation directly. This limitation was put in place to prevent excessive row lock times. You can callout and perform DML in the same transaction, provided you callout first. Usually, this means you need to perform your callout asynchronously:

global class invokeAreasCallout{
    @InvocableMethod(label='Areas Callout')
    //global static List<String> doAreaCallout(List<String> postcode) {
    global static List<String> doAreaCallout() {
        doAreaCalloutAsync();
        return null;
    }
    @future(callout=true) global static void doAreaCalloutAsync() {
        String postcode='B302PF';
        HttpResponse res;
        // Instantiate a new http object
        Http h = new Http();

        // Instantiate a new HTTP request, specify the method (GET) as well as the endpoint
        HttpRequest req = new HttpRequest();
        String requestURL='http://mapit.mysociety.org/postcode/';
        requestURL=requestURL+postcode;
        req.setEndpoint(requestURL);
        req.setMethod('GET');

        // Send the request, and return a response
        res = h.send(req);
    }
}

Note that this means you can't get the results from your callout during the initial record transaction, so you'll probably want to modify your invocable method to accept a list of record ID values, and perform a query in the future method (then callout, and finally commit any changes back to the database).

Related Solutions

[SalesForce] You have uncommitted work pending. Please commit or rollback before calling out

This is a very common issue that one encounters

The issue happens you are doing a DML before you do a Callout .To replicate this issue one can try things like

Account acc=new Account();
acc.Name='Test exception';
insert acc;//insert a dummy account

Http h = new Http();//DO a HTTP callout 
HttpRequest req = new HttpRequest();
 req.setEndPoint(SpringCM_Uploader_Settings__c.getOrgDefaults().Heroku_service__c+'/downloadDocument?documentId='+log.SpringCM_Document_Id__c);
req.setMethod('GET');
HttpResponse res = h.send(req);
System.debug('response body is'+res.getBody());

Resolution when using button to invoke

This workaround splits the transaction into two separate Ajax processes. The first inserts the record and the second performs the callout and is able to update the newly inserted record.****

   <!-- TestWsCallout.page -->
   <apex:page controller="TestWsCallout" tabstyle="Account">
    <apex:form >
    <apex:actionFunction action="{!InsertRecord}" name="InsertRecord_JS" Rerender="statuses" status="Status1" oncomplete="CallWebService_JS();"/>
    <apex:actionFunction action="{!CallWebService}" name="CallWebService_JS" status="Status2" reRender="statuses, msg"/>
    <apex:outputPanel id="statuses">
        <apex:actionStatus id="Status1" startText="...Inserting Record Into DB..." />
        <apex:actionStatus id="Status2" startText="...Calling Web Service..." />
    </apex:outputPanel>
    <apex:outputPanel id="msg">
        <apex:pageMessages />
    </apex:outputPanel>
    <div><input name="DoAction" class="btn" type="button" value="Do Action" onclick="InsertRecord_JS();return false;"/></div>
</apex:form>

// TestWsCallout.cls
  public class TestWsCallout{
   Account myAccount;

  public PageReference InsertRecord() {
    myAccount = new Account(name = 'Test Account');
    insert myAccount;
    // Calling a Web Service here would throw an exception
    return null;
  }

public PageReference CallWebService() {

    // Execute a call to a Web Service
    HttpRequest req = new HttpRequest();
    req.setEndpoint('http://MyWebService12345678790.com?id=' + myAccount.Id);
    req.setMethod('GET');
    HttpResponse response = new Http().send(req);

    // Simulate an update
    myAccount.Name = 'Test Account 2';
    update myAccount;        
    ApexPages.addMessage(new ApexPages.Message(ApexPages.Severity.CONFIRM, 'WebService Called on New Account: ' + myAccount.Name));
    return null;
   }
 }

Resolution when using In Trigger

If your transaction allows you to split your calls,that will be best route.One call will be for DML and other for Callout(Mutiple future callouts)

**Another way will be first do a Callout and then do a DML and even this would also avoid this exception .

[SalesForce] Apex Batch : You have uncommitted work pending. Please commit or rollback before calling out

Problem

Actually, webservice or http callouts and a DML won't take place in the same transaction. And that's why you are getting the error. Read about this problem.

Solution

You could break your code into two parts, as per the suggestion in the above article, Webservice part and the DML part.
Use @Future annotation. I had such problem and resolved using that.

Code Sameple This is just a out-of-mind code. but you need make changes or test this as per your need.

//global variable at the top
Map<String,Object> mapObject;
//start ()
execute () {
      CallWebService();
      Map<String,Object> rawObj = mapObject;
      // Your remaining code
}

@future
public PageReference CallWebService() {
    // initialize the global variable.
    mapObject = new Map<String,Object>();


    HttpRequest req = new HttpRequest();
    req.setMethod('GET');
    req.setEndpoint('https://www.publicstuff.com/api/2.0/request_view?request_id='+newReq');
    Http http = new Http();
    HTTPResponse res = http.send(req);

    String resonseBody = res.getBody();
    String jsonString = resonseBody;
    mapObject = (Map<String,Object>) JSON.deserializeUntyped(jsonString);
}

Best Answer

Related Solutions

[SalesForce] You have uncommitted work pending. Please commit or rollback before calling out

[SalesForce] Apex Batch : You have uncommitted work pending. Please commit or rollback before calling out

Related Topic