[SalesForce] Approval Matrix using custom settings and its method

Could you help me with my method for my approval flow? I created a custom settings named Approver_Matrix . Here is a sample:

enter image description here

Note: Private Account and Public Account fields were checkbox.
For my method, the expected return of the method is a Map of Integer and object type Approver_Matrix : Map.

Public Map<Integer, Approval_Matrix__c > ApprovalProcess(Opportunity oppty) {
    Map<Integer, Approval_Matrix__c > approvalMap = new Map<Integer, Approval_Matrix__c >();

    Decimal contractAmount = Opportunity.Contract_Amount__c;
    String acctMgrRole =  Opportunity. Account_Manager__r.UserRole.Name;
    Boolean pubAcc =  acctMgrRole.contains(‘Public Account’);
    Boolean prvAcc = acctMgrRole.contains(‘Private Account’);

    List< Approval_Matrix__c > approverList = new List< Approval_Matrix__c > ([SELECT Name, Limit__c, Position__c, Approver__c, Approver_Email__c, Public_Account__c, Private_Account__c WHERE  Public_Account__c  =: pubAcc && Private_Account__c  =: prvAcc]);
    Integer approverCtr = 1;
    For (Approval_Matrix__c apr :approverList) {
        If (contractAmount <= apr.Limit__c) {
            approvalMap.add(approverCtr, apr);
            approverCtr ++;
        }
    }

    Return approvalMap;
}

Questions:

What will be the differences between querying the custom settings using these List< Approval_Matrix__c > apr = Approval_Matrix__c.getall().values() VS SELECT Name, Limit__c, Position__c, Approver__c, Approver_Email__c, Public_Account__c, Private_Account__c WHERE Public_Account__c =: pubAcc && Private_Account__c =: prvAcc?
What would be the effective one to be used?
When using the SOQL query (see above), got an error saying unexpected token: ‘:’. What to do here?
What missing code will do the work if the opportunity’s contract amount is 25, 000 and role of Account Manager is neither Public nor Private the following approver would be retrieved.

enter image description here

Best Answer

On 1, 2 and 3, I would choose to query for the value because all the conveniences of SOQL are then available:

Integer approverCtr = 1;
for (Approval_Matrix__c am : [
        SELECT Name, Limit__c, Position__c, Approver__c, Approver_Email__c,
                Public_Account__c, Private_Account__c
        FROM Approval_Matrix__c
        WHERE Public_Account__c = :pubAcc
        AND Private_Account__c =:prvAcc
        AND Limit__c >= :contractAmount
        ORDER BY Approver_Email__c
        ]) {
    approvalMap.put(approverCtr, am);
}

If you use Approval_Matrix__c.getAll().values(), you have to do more work in your Apex code with the only benefit being avoiding one SOQL query.

I don't understand your question 4.

Related Solutions

[SalesForce] Getting error “System.LimitException: Too many query rows: 50001” what i do in this case.

If your controller does not have any DML operation than you can easily solve above two salesforce governer limits using the attribute readOnly="true" by default it's value is false.

Query Rows limits increased from 50001 to 1 million rows
collection size limits increased from 1001 to 10,000

[SalesForce] Simple Apex class to return a list of strings

You can't instantiate a List like that using an integer. You don't need to explicitly specify how much items are going into the list when it is created. Instead, just remove the integer:

//Instantiate the list
String[] myArray = new List<String>();

You're logic in your loop seems to be incorrect as well. Specifically, myArray's size will always be 0 when you instantiate it. Change your loop logic to:

for(Integer i=0;i<length;i++) {
   // code
}

You want to generate a List of strings based on the i variable. You will want to change your internal logic to:

//Populate the array
myArray.add('Test ' + i);

// Write value to the debug log
System.debug(myArray[i]);

Finally, you want to return that Array. You need to change your method so the return type is no longer void by changing its signature:

public static String[] generateStringArray(Integer length)

then it is just a matter of returning that array at the end of your method:

return myArray;

This would bring it all together as:

public class StringArrayTest {
    //Public Method
    public static String[] generateStringArray(Integer length) {
        //Instantiate the list
        String[] myArray = new List<String>();

        //Iterate throught the list
        for(Integer i=0;i<length;i++) {
            //Populate the array
            myArray.add('Test ' + i);

            // Write value to the debug log
            System.debug(myArray[i]);
        } //end loop

        return myArray;
    }//end method       
}// end class

Some more info on Arrays and Lists, Loops, and Class methods for future reference.

Best Answer

Related Solutions

[SalesForce] Getting error “System.LimitException: Too many query rows: 50001” what i do in this case.

[SalesForce] Simple Apex class to return a list of strings

Related Topic