[SalesForce] Before Delete Trigger record selection – contents of Trigger.old

I'm writing my first Before Delete trigger (2nd half of the trigger) and am a bit confused about a couple of issues. In this particular case, the isDeleted field doesn't exist on the custom object and since the record hasn't yet been deleted, it also wouldn't have been set to true anyway for me to be able to sort on.

The object the trigger fires on are related to opportunity. The trigger performs roll-up calculation of the number of related records per opportunity (there's a many to one relationship between the object Ids per opportunity) and saves the calculation to a field in Opportunity.

My understanding is that trigger.new will be empty of records, so my question is, will trigger.old only contain the object records that are to be deleted? If not, how can I determined which records have been selected for deletion? I have no other criteria to go on that I know of. Beyond that, I believe the relevant trigger code would look something like this:

trigger RecapRollupToOpp on Recap_Form__c (after insert, before delete) {

   if (Trigger.isBefore && Trigger.isDelete) {            
      set<Id> OIds = trigger.oldmap.keySet();
      system.debug('RecapForms Deleted = '+ OIds.size());
      list <Opportunity>OppsUp = new list<Opportunity>();
      list<Recap_Form__c>PrMoRC = new list<Recap_Form__c>();    
      set<Id>OpId = new set<Id>();

      for(Id OI:OIds){

         OpId.add(Id.valueOf(trigger.oldmap.get(OI).PromoEvent__c));    
      }

      map<Id,Opportunity> PrMoUp = new map<Id,Opportunity>([SELECT Id,Recap_Count_New__c, (SELECT Id, PromoEvent__c FROM Recap_Forms_New__r)FROM Opportunity WHERE Id IN: OpId ]);

      set<Id>PrMoIds = PrMoUp.keySet();

      /* Use loops to retrieve lists of Opps and Recap_Forms */
      for (Id OpportunityId : PrMoIds) {

         Opportunity opp = PrMoUp.get(OpportunityId);

         PrMoRC = opp.Recap_Forms_New__r;
         PrMoUp.get(OpportunityId).Recap_Count_New__c = 0; // Reset count to zero

         for(Recap_Form__c RC: PrMoRC){

            system.debug(RC.PromoEvent__c +'='+ OpportunityId);     

            if(OIds.contains(RC.Id)==false){
               PrMoUp.get(OpportunityId).Recap_Count_New__c = PrMoUp.get(OpportunityId).Recap_Count_New__c + 1;
               OppsUp.add(PrMoUp.get(OpportunityId));

            }else if(OIds.contains(RC.Id)==true){
               PrMoUp.get(OpportunityId).Recap_Count_New__c = PrMoUp.get(OpportunityId).Recap_Count_New__c - 1;
               OppsUp.add(PrMoUp.get(OpportunityId));
            }       
               // This adds 1 for each related Recap_Form__c returned from the query for the Opportunity
               // and subtracts 1 for each related Recap Form in the set of RC ID's being deleted to get a new total

         } // end for(Recap_Form__c RC: PrMoRC) // Recap_Form__c

         if(PrMoUp.get(OpportunityId).Recap_Count_New__c < 0){ 
            PrMoUp.get(OpportunityId).Recap_Count_New__c = 0;
            // can't have a value less than zero
            OppsUp.add(PrMoUp.get(OpportunityId));
         }  
      } // end for for (Id OpportunityId : PrMoIds)

      system.debug('Num Opps Updated = '+ OppsUp.size() + ' vs Recaps Deleted = '+ OIds.size());

      if(OppsUp.isEmpty() == false) update OppsUp;

   } // END if (Trigger.isBefore && Trigger.isDelete)       
}

Best Answer

When the Trigger.isDelete is true, all the records in Trigger.old are being deleted.

Related Solutions

[SalesForce] Before Insert Trigger – Query Only Related Records To Incoming Record

What exactly is your requirement? it is a little hazy to understand. As far as I can tell you want to do the following.

Check the field Flag_c when an MyActivity_c record is inserted where the recordtypeID on the inserted record is "Record Type Name" and set it to No if its value is yes
Gather a list of existing MyActivity_c records where the recordtype is "Record Type Name" and the field "Contact_c" matches the original inserted record.

A couple of questions

Is Flag__c a Checkbox? maybe consider if it should be (true,false) rather than "Yes" / "No".
Why are we checking if the field is Yes before setting to No, if the field is No already there is no difference.
What do you want to do with the list of existing MyActivity__c records once you have them?

That being said there are a number of issues with this trigger, starting with the fact that you are executing a SOQL query within a for loop which is against best practice. Always try to execute queries outside of any loop structure.

Also when you query a Recordtype you should also try to query the objecttype not just the name and preferably the developer name (Usually the same as name with underscores, but the name may change, hence why its good to query developername)

Here is an example of how you might write this trigger based on what I can gather from your requirements, with comments explaining step by step.

trigger MyTrigger on MyActivity__c (before insert)
{

    // a map to store your Contact__c to related MyActivity__c records
    map<Id,list<myActivity__c>>     mapIdtoActivities   = new map<Id, list<myActivity>>();

    // OR you just get one big old list depending on what you want to do with them
    list<myActivity__c>             listOtherActivities = new list<myActivity>();

    // Query the correct recordtype
    ID rtId = [SELECT Id FROM RecordType WHERE sobjectType='MyActivity__c' AND DeveloperName = 'Record Type Name'].Id;

    for(MyActivity__c r: trigger.new)
    {
        // For the activity records in the trigger context that have this recordtype
        if(r.RecordTypeId == rtId)
        {
            // set the flag to no
            r.Flag__c == 'No'; // Or false if you change to checkbox

            // Create a key value for each Contact__c
            mapIdtoActivities.put(r.Contact__c. null);
        }
    }

    // Query the other activity records related to the ones in your trigger (map keys & recordtype & flag = no)
    for(MyActivity__c OtherActivityRecord : [   SELECT Id, Contact__c FROM MyActivity__c
                                                WHERE RecordTypeId = : rtId AND Flag__c = 'No'
                                                AND Contact__c IN : mapIdtoActivities.keyset()])
    {
        // NOW depending on what you want to do with them you can either create multiple lists per contact i.e.

            // Check if we have already created a list for this contact__c record
            if(mapIdtoActivities.get(r.Contact__c) == null)
            {
                // There is no list of Activities so create one and add the first activity record to it
                mapIdtoActivities.put(r.Contact__c, new list<MyActivity__c>{OtherActivityRecord});
            }
            else    
            {
                // There is a list of Activities so add to it
                mapIdtoActivities.get(r.Contact__c).add(OtherActivityRecord);
            }

         // OR you can just dump them all in one big list

         listOtherActivities.add(OtherActivityRecord);
    }

    // Do something with your shiny new lists here.


    // no need to query the size anymore so I am told
    //if(contactrecords.size()>0)
    //{
        update listOtherActivities;
    //}   
}

[SalesForce] Updating a related record in a trigger

Even if the suggested solution provided by @sfdcfox of querying the lead again may solve your problem, I see another logic flaw in your trigger.

if ( Trigger.oldMap.get(po.Id).AttachedLeadId__c != NULL) { oldLeads.put(po.AttachedLeadId__c, NULL); }

This code populates the oldLeads map with the new lead id po.AttachedLeadId__c. So when you change the lead from lead A to lead B, your trigger will first update lead B's hasCustomObject__c field to true as its available in newLeads map. Then oldLeads map also have lead B only and updates its hasCustomObject__c to false.

So lead A will be having true and lead B will still have false.

So change that part to

if ( Trigger.oldMap.get(po.Id).AttachedLeadId__c != NULL) { oldLeads.put( Trigger.oldMap.get(po.Id).AttachedLeadId__c , NULL); }

Hope I make some sense.

Best Answer

Related Solutions

[SalesForce] Before Insert Trigger – Query Only Related Records To Incoming Record

[SalesForce] Updating a related record in a trigger

Related Topic