[SalesForce] Create an event after a record has been approved

I want to create a event after my record have been approved, I have a checkbox checked when my record is approved so I can create my event, but the record will be locked !!!!

There were custom validation error(s) encountered while saving the affected record(s). The first validation error encountered was:

"Apex trigger TRTimeOffAfterUpdate caused an unexpected exception,
contact your administrator: TRTimeOffAfterUpdate: execution of
AfterUpdate caused by: System.FinalException: Record is read-only:
Trigger.TRTimeOffAfterUpdate: line 4, column 1".

trigger TRTimeOffAfterUpdate on Time_Off__c (after update) {

    for (Time_Off__c toEvent : Trigger.new) {
        if(toEvent.Is_approved__c=true){
       // Event event = new Event
       Event ev= new Event 
       (
            OwnerId = toEvent.CreatedById,
            StartDateTime = toEvent.Start_date__c,
            EndDateTime = toEvent.End_date__c,
            Subject = toEvent.Pattern__c,
            Description =  toEvent.Comment__c,
            ShowAs = 'Out of Office'
        );
        insert ev ;             
    }
}

Best Answer

First, I made a small edit to your trigger. Instead of the single equal sign, you need a double equal sign. Also, I made it check if the old value was unchecked so you don't keep making records over and over.

trigger TRTimeOffAfterUpdate on Time_Off__c (after update) {

for (Time_Off__c toEvent : Trigger.new) {
    if(toEvent.Is_approved__c==true && Trigger.oldMap.get(toEvent.Id).Is_approved__c == false){
   // Event event = new Event
   Event ev= new Event 
   (
        OwnerId = toEvent.CreatedById,
        StartDateTime = toEvent.Start_date__c,
        EndDateTime = toEvent.End_date__c,
        Subject = toEvent.Pattern__c,
        Description =  toEvent.Comment__c,
        ShowAs = 'Out of Office'
    );
    insert ev ;             
}
}

Does this work?

Related Solutions

[SalesForce] Records retaining lock when recall of approval process is complete

Why don´t you approve this process by quering the ProcessInstanceWorkitem, you can access the ProcessInstance Object to check for pending, rejected or approved requests and do specific actions on each case. Here is an example on how to approve one Item:

public static void approveApproval(Id aeId) {
        List<ProcessInstanceWorkitem> listaAprobacionPendiente = [SELECT Id, ProcessInstance.TargetObjectId
                                                                    FROM ProcessInstanceWorkitem
                                                                   WHERE ProcessInstance.TargetObjectId =:aeId];


        Approval.ProcessWorkitemRequest req = new Approval.ProcessWorkitemRequest();
        req.setComments('Aprobado desde proceso automático de aprobación.');
        req.setAction('Approve');
        req.setWorkitemId(listaAprobacionPendiente[0].Id);
        Approval.ProcessResult result = Approval.process(req);
}

[SalesForce] Error on Trigger Before Delete[Trigger.old]

You can modify the values of the record before their final deletion in a Before Delete trigger event, but you need a separate DML statement for this. Example follows:

if(Trigger.isDelete) {
    Contact[] contacts = new Contact[0];
    for(Contact record: Trigger.old) {
        if(record.RecordTypeId == RecordType1 && record.Registered_on_ITV_Media__c) {
            contacts.add(new Contact(Id=record.Id, Status__c='Inactive'));
        }
    }
    update contacts;
}

Notice how I construct a new instance of the record using new Contact so it doesn't trigger the "record is read-only" error. Note that your before/after update logic will also be called, meaning the inactive status will be sent to your webservice automatically without handling this explicitly in your before delete trigger event (in other words, don't call the web service explicitly in your delete trigger event).

Best Answer

Related Solutions

[SalesForce] Records retaining lock when recall of approval process is complete

[SalesForce] Error on Trigger Before Delete[Trigger.old]

Related Topic