[SalesForce] Create Task Activity in Unit Test

I am apparently missing something in the creation of my unit test data. I would like to create both an Account and an Open Activity (task) for the account.

I am able to successfully insert both records, and I receive results when querying the Account and Task individually. My issue is when I attempt to find the Open Activities for the Account.

Account Creation Code

Account a = new Account(Name='Sample Account');
insert a;

Task Creation Code

List<Task> tasks = new List<Task>();
tasks.add(new Task(
    ActivityDate = Date.today().addDays(7),
    Subject='Sample Task',
    WhatId = a.Id,
    OwnerId = UserInfo.getUserId(),
    Status='In Progress'));

insert tasks;

After the records are created, this query returns results:

Id aId = a.Id;
List<Task> taskRecords = [Select Id, WhatId, Subject from Task where WhatId = :aId];

While this does not:

List<Account> accountWithOpenActivities = [Select Name, (Select Id, WhatId, Subject From OpenActivities) from Account where Id = :aId];

Best Answer

Any chance your running user in the testmethod falls afoul of these restrictions (from SFDC Doc)

In order to prevent performance issues while still providing the related list functionality, there are some restrictions on users who do not have “View All Data” permission. Such users must comply with the following restrictions:

In the main clause of the relationship query, you can reference only one record. For example, you cannot filter on all records where the account name starts with A, but must reference a single account record.

You cannot use WHERE clauses.

You must specify a limit to the number of rows returned, less than 500.

You must sort on ActivityDate and LastModifiedDate, descending order: ORDER BY ActivityDate DESC, LastModifiedDate DESC

Related Solutions

[SalesForce] Create test fixtures for Apex Unit Tests

Many people set up test data creation classes. Lots of time you will see them referred to as factories. So you could set up a TestFactory like below

public with sharing class TestDataFactory {

           public static Account accountCreator(string name){
                   Account myAccount = new Account();
                   myAccount.Name = name;
                   insert myAccount;
                   return myAccount;
           }

           public static Contact contactCreator(Id accountID, string fname, string lname){
                   Contact myContact = new Contact();
                   myContact.firstName = fname;
                   myContact.lastName = lname;
                   myContact.AccountId = accountID;
                   insert myContact;
                   return myContact;
          }
    }

Now your test method that used to look like this

static testMethod void myTestMethod() {

     Account a = new Account();
     a.Name = 'test';
     insert a;

     Contact c = new Contact();
     c.FirstName = 'Joe';
     c.LastName = 'Schmoe';
     c.AccountId = a.Id;
     Insert c;
     //Rest of your code
}

Now looks like this

static testMethod void myTestMethod() {

     Account a = TestDataFactory.accountCreator('Test Account');
     Contact con = TestDataFactory.contactCreator(a.Id, 'Joe', 'Schmoe');
     //Rest of your code
}

8 Lines becomes 2. You can imagine how much time and code this can save you in complex test classes. Your code is much cleaner and its totally reusable. This is just a very simple example, you can do quite a bit with this and expand on it to save you lots of time in creating your test data. Hope this helps

[SalesForce] Unit Test is Providing 0% Coverage for Apex Trigger

The trigger code is having lot of redundancy, So I modified it. before posting the modified code few lines of explanation what I changed. you collected account Ids twice and did the condition check twice where once is more enough. I am also made changes to the test class, where Task data is provided which is not required because the trigger has to create it once the necessary conditions are met. I am expecting this trigger should work for you, if there is any errors feel free to post as a comment.

trigger OpportunityAfter on Opportunity (after update){

    Set AccountIDs = new Set();

    for(Opportunity o : trigger.new){
        if(opp.StageName == 'Closed - Lost' && opp.Business_Line__c == 'Workforce' && 
            opp.Survey_Type__c != 'APulse' && trigger.oldMap.get(opp.Id).StageName != opp.StageName){

                AccountIDs.add(o.AccountId);
         }
    }

    Task[] tasksToInsert = new Task[]{};

    for (Account acc : [Select Id, Name, OwnerId from Account where Id IN :AccountIds]){
        for (Opportunity opp : trigger.new){
            if(opp.AccountId == acc.Id){
                Task tas = new Task();
                tas.WhatId=acc.Id;
                tas.OwnerId=opp.OwnerId;
                tas.Subject='Follow-up: ' + opp.name + ' - ' + acc.name;
                tas.ActivityDate=(opp.CloseDate + 180);
                tas.Description='Follow up to see how engagement initiatives are going and if Avatar can help. Refer to lost opportunity: ' + opp.name;
                tasksToInsert.add(tas);                                                         
            }
        }
    }
    if(tasksToInsert != null && !tasksToInsert.isEmpty())
    Database.insert(tasksToInsert);

}

@isTest
public class TestClass {

    static testMethod void myUnitTest() {

    //Set up user
    User u1 = [SELECT Id FROM User WHERE Email='abc@sampleemail.com'];
    test.startTest();  
    //Run As U1
    System.RunAs(u1){

    System.debug('Testing trigger... (single record validation)');

    //NEW Account record
    Account acc = new account();
    acc.Name = 'Test Account';
    acc.Industry = 'Healthcare';

    insert acc;

    //NEW Opportunity record
    Opportunity opp = new Opportunity();
    opp.Name = 'Test Opportunity'; 
    opp.CloseDate = System.today();
    opp.StageName = 'S1 - Investigative';
    opp.Type = 'Repeat Business - Wrkforce HC';
    opp.AccountId = acc.Id;
    opp.Survey_Type__c = 'Product Name';

    insert opp;

    opp.StageName = 'Closed - Lost';
    opp.Reason_Won_Lost__c = 'Relationship';
    opp.Business_Line__c = 'Workforce'  //added this line to meet the if condition while collecting the set of id in the trigger.

    update opp;
   test.stopTest();
    // Here I am expecting the task has been inserted and doing a query for it         and check it in the assert statement.
   Task  testTask=[Select Id, WhatId from Task where WhatId=:acc.Id];
    //Validate single insert
    System.assertEquals(acc.Id, testTask.WhatId);

    }
    }
}

Best Answer

Related Solutions

[SalesForce] Create test fixtures for Apex Unit Tests

[SalesForce] Unit Test is Providing 0% Coverage for Apex Trigger

Related Topic