[SalesForce] Database.query() default sort order

Does a Database.query() result maintain the order of the WHERE clause list I'm searching by?

List<Id> myList = new List<Id>;
myList.add('My Opportunity 1');
myList.add('My Opportunity 2');
myList.add('My Opportunity 3');
String soql = 'SELECT FROM Opportunity WHERE Name IN (\'' + myList.get(0) + '\',\'' + myList.get(1) + '\',\'' + myList.get(2) + '\')';
List<Opportunity> myResult = Database.query(soql);

Is it valid that:

myResult.get(0).Name == 'My Opportunity 1'
myResult.get(1).Name == 'My Opportunity 2'
myResult.get(2).Name == 'My Opportunity 3'

Use case is I'm trying to build a deep cloning tool which accepts any record and clones all children, grand-children, great-grand-children, etc. Part of this method requires me to be able to identify which cloned grand-child is related to which original grand-child (so as to parent to the correct cloned great-grand-children). I would like to compare the input list with the output list and associate (0) with (0) and (1) with (1), but that only works if the Database.query() method maintains the same sort order.

One option is to create a field on all the objects that stores the "cloned from" ID, but this is far from ideal for a truly scalable cloning utility. I'd like to be able to dynamically associate the recently cloned&inserted records with their originals while traversing down the chain of children.

Best Answer

Almost certainly not; the order is undefined.

Perhaps a silly question, but why not add an order by clause? It sounds like, for your purposes, the order doesn't matter as long as it's consistent. You may be able to just order by id asc or createddate desc.

Related Solutions

[SalesForce] Cloning opportunities – identifying which deals are “clones”

You can do that using triggers. To Answer your second question, see the explanation below

First create a custom text field on Opportunity object, and let's call it RecordId.
Create a workflow rule that on create, populates RecordId with SFDC Id.
In our create trigger, you can check for the RecordId.
If RecordId == '', then the record is new.
If RecordId != ”, then the record is being cloned.

This is because trigger is executed before the workflow rule, and as a result whenever a new record is created this RecordId will not contain any value.

But when a record is being cloned this field RecordId will contain the SFDC record Id of the original object from where it is being cloned. You will be able to identify if this is new record or cloned record and take appropriate action

Actually both of your questions are related and can be answered with above solution.

Please let me know in case of any queries. If this answer helps you resolving your query, mark this as best answer.

[SalesForce] Cloning a record and its children

You are returning the parent and redirecting to another page before creating and inserting the children. Try this:

public class surveyBuilderController {

public List <Survey__c> surveyTemplatesList {get;set;}
public List <SelectOption> surveyTemplatesOptions {get;set;}
public String surveySelected {get;set;}
public String buSelected {get;set;}
public Survey__c cloneSelectedSurvey {get;set;}
public ID contactID {get;set;}
public ID newSurveyID {get;set;}
private Map<Id, Survey__c> surveyMap;

Public surveyBuilderController(){

    contactID = ApexPages.currentPage().getParameters().get('Id');
    surveySelected = '';
    surveyTemplatesOptions = new List<SelectOption>();
    surveyMap = new Map<Id, Survey__c>([SELECT Id, Name,Survey_Name__c FROM Survey__c WHERE Is_template__c =: TRUE]);

    for(Survey__c obj : surveyMap.values()){
        surveyTemplatesOptions.add(new SelectOption(obj.Id,obj.Survey_Name__c));
    }
}

public PageReference cloneSelectedSurvey() {
    Savepoint sp = Database.setSavepoint();
    try {
        cloneSelectedSurvey = new Survey__c(
            Survey_Name__c = surveyMap.get(surveySelected).Survey_Name__c,
            Business_Unit__c = buSelected,
            Contact__c = contactID,
            Status__c = 'Open',
            is_Template__c = FALSE
        );

        insert(cloneSelectedSurvey);

        List<Survey_Question__c> questions = new List<Survey_Question__c>();
         for (Survey_Question__c que : [Select que.Id, que.name FROM Survey_Question__c que WHERE Survey__c = :surveySelected]) {
            Survey_Question__c newq = que.clone(false);
            newq.Survey__c = cloneSelectedSurvey.id;
            questions.add(newq);
        }
        insert questions;

        PageReference cloneSelectedSurvey = new PageReference('/'+cloneSelectedSurvey.Id);
        cloneSelectedSurvey.setRedirect(true);
        return cloneSelectedSurvey;

    }
    catch(System.Exception e) {
        ApexPages.addMessage(new ApexPages.message(ApexPages.severity.ERROR,'Error cloning survey.'));
        Database.rollback(sp);
    }
    return null;
}

I also added a savepoint/rollback in there so that if you have an error inserting the children, the parent won't be created.

EDIT: You're also not setting surveySelected to the survey's Id. Changed your SelectOption definition above.

EDIT 2 Updated code above to include changes to correctly set survey name.

Related Topic