[SalesForce] DML statement cannot operate on Trigger.new or Trigger.old

I have an afterInsert trigger on Events. When the Script is finished, I would like to delete the event. I keep getting this error message.

DML statement cannot operate on Trigger.new or Trigger.old

If I cannot do this within Trigger.new, what is the best way to do this? If SOQL is involved, what field am I looking for? event.ID?

Best Answer

You cannot operate on records from the trigger context. You can take those same records and perform DML on them if you simply change the reference.

List<Event> nonTriggerEvents = new List<Event>();
for (Event triggerEvent : trigger.new)
{
    nonTriggerEvents.add(new Event(Id = triggerEvent.Id));
}
update nonTriggerEvents;

However, in this case you can take a simpler approach and call Database.delete on a List<Id>.

List<Id> eventIdsToDelete = new List<Id>();
for (Event newEvent : trigger.new)
{
    eventIdsToDelete.add(newEvent.Id);
}
Database.delete(eventIdsToDelete);

Related Solutions

[SalesForce] Unable to delete the current record

I expect you're receiving this error (including spelling mistake, well done SF):

System.SObjectException: DML statment cannot operate on trigger.new or trigger.old

That's because the record you are trying to delete is in the Trigger.new collection. You would need to re-query the records first:

List<Company__c> companies = [Select Id From Company__c Where Id IN :Trigger.new];

Then, loop companies instead of Trigger.new. The error message is self explanatory.

[SalesForce] Getting error CANNOT INSERT UPDATE ENTITY

Your trigger looks quite dangerous in that if ever two or more SO_Detail__c objects that are children of the same Outbound_Sales_Order__c parent are inserted or updated or deleted at the same time then the duplicate ID error will occur. (You may not expect that this will happen right now, but some upload or bulk update in the future may well cause that condition and bring proceedings to a halt.)

A way to avoid the error is to use a map keyed by the Outbound_Sales_Order__c ID and make some decision about which child object "wins". Making this change may work-around your test failures (which in some ways is a bad thing because why the failure is happening when the test only uses one SO_Detail__c is certainly unclear to me) and will make the normal production use of the trigger more reliable.

This is how the map would be used to make sure there are never duplicate IDs when the update is done:

Map<Id, Outbound_Sales_Order__c> osos = new Map<Id, Outbound_Sales_Order__c>();

...

    Outbound_Sales_Order__c oso = osos.get(p.Outbound_Sales_Order__c);
    if (oso == null) {
        oso = new Outbound_Sales_Order__c(Id = p.Outbound_Sales_Order__c);
        osos.put(p.Outbound_Sales_Order__c, oso);
    }
    oso.x1_Issue__c = String.valueof(p.SOD_Issue__c);
    ...
...

update osos.values();

Best Answer

Related Solutions

[SalesForce] Unable to delete the current record

[SalesForce] Getting error CANNOT INSERT UPDATE ENTITY

Related Topic