[SalesForce] Empty values in a picklist

Root-cause: From the controller alone, it adds empty values but it can be removed with javascript though the javascript doesn't work.

 VF PAGE

 <apex:column rendered="{!allowDiscount}" id="DiscountCol">
                                <apex:facet name="header">Discount %</apex:facet>
                                <apex:selectList id="Discount" size="1" multiselect="false" value="{!results.Discount}" rendered="{!AND(results.allowDiscountItem,allowDiscount,results.showDetails)}">
                                    <apex:selectOptions id="discOptions" rendered="{!allowDiscountFlag}" value="{!DiscountList}"/>
                                </apex:selectList>
</apex:column>


//javascript removing empty spaces 
<script>
                                    var entries = document.getElementById("{!$Component.j_id0:form:discDetail:discSection:discountTabTable:1:Disc}").value;
                                    for(var i = entries.length - 1; i>=0; i--){
                                        if(entries.discountList[i].text == ""){
                                           entries.remove(i);
                                        }
                                    }
</script>

CONTROLLER

 public List<SelectOption> getDiscountList() 
    {
        List<SelectOption> discountList = new List<SelectOption>();

        List<Product__c> familyDiscount = [SELECT Discount__c FROM Product__c where name =: business._Product__c];

        SelectOption sOption = new SelectOption('1', '<optgroup style="background:#FFFFFF;"></optgroup>');
        sOption.setEscapeItem(false);
        discountList.add(sOption);

        for(Product__c pf: familyDiscount)
        {
            if(pf.Discount__c != NULL)
            {
                string color;
                for(string discount: pf.Discount__c.split(','))
                {
                    if(integer.valueOf(discount) <= integer.valueOf('12')) 
                    {
                        color = 'green';
                    }
                    else{
                        color = 'red';
                    }
                    //system.debug('color:'+color);
                    SelectOption entry = new SelectOption(discount,'<option value="'+discount+'" style="color:'+color+';">' + discount+'%'+'</option>');        
                    entry.setEscapeItem(false);
                    system.debug(entry);
                    if(entry != null){
                        discountList.add(entry);
                    }
                }
            }
        }

        return discountList;
    }

Help me to get rid of this empty spaces.
enter image description here

What could be probably changes in the code to be made?

Best Answer

Try below,

public List<SelectOption> getDiscountList() 
    {
        List<SelectOption> discountList = new List<SelectOption>();

        List<Product__c> familyDiscount = [SELECT Discount__c FROM Product__c where name =: business._Product__c];

        SelectOption sOption = new SelectOption('1', '<optgroup style="background:#FFFFFF;"></optgroup>');
        sOption.setEscapeItem(false);
        discountList.add(sOption);

        for(Product__c pf: familyDiscount)
        {
            if(pf.Discount__c != NULL)
            {
                string color;
                for(string discount: pf.Discount__c.split(','))
                {
                    discount=discount.trim();
                    if(integer.valueOf(discount) <= integer.valueOf('12')) 
                    {
                        color = 'green';
                    }
                    else{
                        color = 'red';
                    }
                    //system.debug('color:'+color);
                    if(discount!=''){
                        SelectOption entry = new SelectOption(discount,'<option value="'+discount+'" style="color:'+color+';">' + discount+'%'+'</option>');        
                        entry.setEscapeItem(false);                        
                        discountList.add(entry);
                    }
                }
            }
        }

        return discountList;
    }

Related Solutions

[SalesForce] Colored Picklist Values in VF Page

Do not use inline styles for this. Instead use CSS.

And don't use JS to remove Options from the Select. Use Apex code.

So the way to do it would be something along these lines:

Page:

<style type="text/css">
.low-discount {
  color: green;
}

.high-discount {
  color: red;
}
</style>

.....

<apex:selectList id="Disc" size="1" multiselect="false" value="{!results.Discount}" }">
  <apex:repeat value="{!discounts}" var="discount">
    <option class="{!discount < 12 ? 'low-discount' : 'high-discount'}">
      {!discount}
    </option>
  </apex:repeat>
</apex:selectList>

And write a controller method getDiscounts that returns a list of numbers that are the discount values. Something like this:

public List<Integer> getDiscounts() {
  //  get data somehow into familyDiscount

  // use a set to make each value unique
  Set<Integer> retVal = new Set<Integer>();
  for (Product__c p: familyDiscount) {
    if (p.Discount__c != null) {
      for (String discount: pf.Discount__c.split(',')) {
        // I guess this is a check you need?
        if (discount != '') {
          // turn the String into an Integer and add it to the set
          retVal.add(Integer.valueOf(discount));
        }
      }
    }
  }
  return new List<Integer>(retVal);
 }

[SalesForce] Display default picklist value as Read-only on Custom Object

As for the read-only aspect of your question, end users will not be able to modify the value on the page you have specified, as you are using an apex:outputField, which is read-only by default (it's the first thing mentioned in the documentation).

Here is how you would retrieve the deault programatically. Check out the Schema.PicklistEntry documentation, specifically isDefaultValue.

public class MyCustomObjectServices
{
    public static Schema.PicklistEntry myPicklistDefaultEntry
    {
        get
        {
            // Lazy load if you wish
            // You may prefer to return just the Label/Value
            for (Schema.PicklistEntry entry : myPickListEntries)
            {
                if (entry.isDefaultValue()) return entry;
            }
            return null;
        }
    }
    public static List<Schema.PicklistEntry> myPickListEntries
    {
        get
        {
            // Lazy load if you wish
            return MyCustomObject__c.MyPickList__c.
                getDescribe().getPicklistValues();
        }
    }
}

You could reference these in your controller with ease:

public MyCustomObjectExt(ApexPages.StandardController standardcontroller){
    MyCustomObject__c customObject = new MyCustomObject__c();
    customObject.MyPickList__c = MyCustomObjectServices.myPicklistDefaultEntry.getValue();
    this.controller = standardcontroller;
}

Best Answer

Related Solutions

[SalesForce] Colored Picklist Values in VF Page

[SalesForce] Display default picklist value as Read-only on Custom Object

Related Topic