[SalesForce] “Expression cannot be assigned at line -1 column -1”

The challenge with triggers across multiple objects is that there are many cases to consider such as:

• the Opportunity changing to match the condition
• the Opportunity changing to not match the condition
• the Opportunity being deleted
• the OpportunityContactRole being inserted or updated
• the OpportunityContactRole being deleted

A trigger of the following form will (I think - tests need adding to be more sure) handle the first two. (If all 5 conditions are reasonable you will need to write further triggers for those.)

trigger Is_In_Pipe_v3 on Opportunity (after update, after insert) {
    // Find the Opportunites where the key fields have changed
    Set<Id> changedOppIds = new Set<Id>();
    for (Opportunity newOpp : Trigger.new) {
        Opportunity oldOpp = Trigger.oldMap.get(newOpp.Id);
        Boolean isNew = newOpp.Type == 'New (Renewable)'
                && newOpp.StageName != 'Closed Won'
                && newOpp.StageName != 'Closed Won';
        Boolean isOld = oldOpp.Type == 'New (Renewable)'
                && oldOpp.StageName != 'Closed Won'
                && oldOpp.StageName != 'Closed Won';
        if (isOld != isNew) {
            changedOppIds.add(newOpp.Id);
        }
    }
    if (changedOppIds.size() > 0) {
        List<Contact> contacts = new List<Contact>();
        for (AggregateResult ar : [
                select ContactId i, count(OpportunityId) c
                from OpportunityContactRole
                where OpportunityId in :changedOppIds
                and Opportunity.Type = 'New (Renewable)'
                and Opportunity.StageName not in ('Closed Won', 'Closed Lost')
                group by ContactId
                ]) {
           Id contactId = (Id) ar.get('i');
           Integer oppCount = (Integer) ar.get('c');
           contacts.add(new Contact(Id = contactId, InPipe__c = oppCount > 0));
        }
        update contacts;
    }
}

The "bulkification" is that the work is minimised by only looking at specific changes to Opportunity, there are no queries inside loops, and the minimum amount of looping is done in Apex (by making use of the databases aggregation capability). Performance will be pretty linear depending on how many Contacts are affected by the change, rather than rising exponentially as more Contacts are affected because of nested loops.

The above code is making use of Relationship Queries. These allow you to query across multiple objects in one go, reducing the need to connect together separate queries in code. If you are going to be writing many triggers, it is worth understanding these well.

The other important technique to get used to when writing triggers is the use of maps and sets; see e.g. Common Bulk Trigger Idioms.

Have you considered using a Worfklow Rule or Formula Field to meet this requirement? It looks like you simply want the Business_Division__c field to be in sync with the owners Busines_Division__c field. To do that you could use a Workflow Rule / Field Update to copy Owner.Default_Business_Division__c into Contact.Business_Division__c.

The Formula Field would be on Contact, and its formula would be Owner.Business_Division__c. You could even add the check in the Formula or Field Update to ignore the API User.

Moving this to "Clicks not Code" via Workflow Rule or Formula Field will save you Apex Code, Unit Tests, and Deployment troubles. It is also best practice to use "Clicks" wherever possible.