[SalesForce] Fetching Record Type Name / Id values from Custom Settings – best practise

I need to check that the Record Type of the record whose change caused my trigger to fire is listed in a Custom Setting WEID__c.

Until now I have been been using

trigger WE_MRFv2 on Opportunity (after insert, after update) {

    List<WEID__c> weids = WEID__c.getall().values();
    Set<Id> validRecordTypeIds = new Set<Id>();

    // add Opportunity Record Type Ids from Custom Setting to list of valid Ids      
    for(WEID__c weid : weids) {
        try {
            validRecordTypeIds.add(weid.WEOppId__c);
        } catch (System.StringException e) {
            System.debug(
                System.LoggingLevel.ERROR,
                'Invalid Record Type Id ' + weid.WEOppId__c);
        }
    }

If(Trigger.isInsert){
        for(Opportunity o : Trigger.New){
            if(validRecordTypeIds.contains(o.RecordTypeId))
            {
            //do something
            }
        }
    }

But it's been suggested that I change this to

trigger WE_MRFv2 on Opportunity (after insert, after update) {

    WEID__c weid = WEID__C.getAll().values();

    If(Trigger.isInsert){
        for(Opportunity o : Trigger.New){
            if(weid.get(o.RecordType.Name) != null)
            {
            //do something
            }
        }
    }

As the Record Type name is more stable (when copying code between Sandboxes & Production) and I can then avoid hard coding Record Type Ids when creating / referencing Custom Settings in my Test Classes.

UPDATE —

In the end the below portion of my question was irrelevant since even if I could fetch the Record Type Name from the Custom Setting, I can't check that against the Opportunity Record Type Name.

—

The only problem is that I have several fields in the Custom Setting containing the same value and I'd like to avoid having to create a new Custom Setting each time I need a new list of Record Types (which are currently just stored in a new field for the same Custom Setting).

So I see the following error

System.QueryException: List has more than 1 row for assignment to SObject

Supposedly at line WEID__c weid = WEID__C.getAll().values();. But I'm guessing that the issue actually occurs when I try to fetch the values from weid at line if(weid.get(o.RecordTypeId) != null)?

The 'cost' of fetching the values from the Custom Setting using an SOQL query outweighs the benefit of switching to using Record Type Names, from my point of view.

Is there alternative way to fetch the Custom Setting values which I need (contained in field WEOppId__c), to query later in the Trigger?

Best Answer

A problem with switching to the name is that in triggers only the immediate fields of objects are available. So RecordTypeId is available but the related field that has the record type name RecordType.Name is not without performing an extra query.

ID values in sandboxes are the same as in production because a sandbox is a clone of production.

So I suggest that you do not make this change.

Related Solutions

[SalesForce] Unit Test is Providing 0% Coverage for Apex Trigger

The trigger code is having lot of redundancy, So I modified it. before posting the modified code few lines of explanation what I changed. you collected account Ids twice and did the condition check twice where once is more enough. I am also made changes to the test class, where Task data is provided which is not required because the trigger has to create it once the necessary conditions are met. I am expecting this trigger should work for you, if there is any errors feel free to post as a comment.

trigger OpportunityAfter on Opportunity (after update){

    Set AccountIDs = new Set();

    for(Opportunity o : trigger.new){
        if(opp.StageName == 'Closed - Lost' && opp.Business_Line__c == 'Workforce' && 
            opp.Survey_Type__c != 'APulse' && trigger.oldMap.get(opp.Id).StageName != opp.StageName){

                AccountIDs.add(o.AccountId);
         }
    }

    Task[] tasksToInsert = new Task[]{};

    for (Account acc : [Select Id, Name, OwnerId from Account where Id IN :AccountIds]){
        for (Opportunity opp : trigger.new){
            if(opp.AccountId == acc.Id){
                Task tas = new Task();
                tas.WhatId=acc.Id;
                tas.OwnerId=opp.OwnerId;
                tas.Subject='Follow-up: ' + opp.name + ' - ' + acc.name;
                tas.ActivityDate=(opp.CloseDate + 180);
                tas.Description='Follow up to see how engagement initiatives are going and if Avatar can help. Refer to lost opportunity: ' + opp.name;
                tasksToInsert.add(tas);                                                         
            }
        }
    }
    if(tasksToInsert != null && !tasksToInsert.isEmpty())
    Database.insert(tasksToInsert);

}

@isTest
public class TestClass {

    static testMethod void myUnitTest() {

    //Set up user
    User u1 = [SELECT Id FROM User WHERE Email='abc@sampleemail.com'];
    test.startTest();  
    //Run As U1
    System.RunAs(u1){

    System.debug('Testing trigger... (single record validation)');

    //NEW Account record
    Account acc = new account();
    acc.Name = 'Test Account';
    acc.Industry = 'Healthcare';

    insert acc;

    //NEW Opportunity record
    Opportunity opp = new Opportunity();
    opp.Name = 'Test Opportunity'; 
    opp.CloseDate = System.today();
    opp.StageName = 'S1 - Investigative';
    opp.Type = 'Repeat Business - Wrkforce HC';
    opp.AccountId = acc.Id;
    opp.Survey_Type__c = 'Product Name';

    insert opp;

    opp.StageName = 'Closed - Lost';
    opp.Reason_Won_Lost__c = 'Relationship';
    opp.Business_Line__c = 'Workforce'  //added this line to meet the if condition while collecting the set of id in the trigger.

    update opp;
   test.stopTest();
    // Here I am expecting the task has been inserted and doing a query for it         and check it in the assert statement.
   Task  testTask=[Select Id, WhatId from Task where WhatId=:acc.Id];
    //Validate single insert
    System.assertEquals(acc.Id, testTask.WhatId);

    }
    }
}

[SalesForce] Trigger to copy child object picklist values to parent object separated by comma

The code you have shared will not at all compile.

use close brace here for (Opportunity childObj : Trigger.new)
use childObj.AccountId instead of childObj.Account to access AccountId
When you use relationship query be sure to use Opportunities instead of Opportunity.
You should put Opportunity's Opp_Location__c into a List. Then use String.join() to add those with comma delimited.
And finally update accounts.

Trigger

trigger UpdateAmount on Opportunity (after insert, after update) { 
  Map<ID, Account > parentOpps = new Map<ID, Account>(); 
  Set<Id> listIds = new Set<Id>();

  for (Opportunity childObj : Trigger.new) {
    listIds.add(childObj.AccountId);
  }

  parentOpps = new Map<Id, Account>([SELECT id, Location_Type__c ,
                                        (SELECT ID, Opp_Location__c  FROM Opportunities) 
                                    FROM Account WHERE ID IN :listIds]);

  List<Account> lstAccount = new List<Account>();

  for(Account acct:parentOpps.values())
  {  
      List<String> strType = new List<String>();
      for(Opportunity oppty:acct.Opportunities)
      {
          strType.add(oppty.Opp_Location__c);
      }
      acct.Location_Type__c = String.join(strType,',');

  }

  update parentOpps.values();
}

Best Answer

Related Solutions

[SalesForce] Unit Test is Providing 0% Coverage for Apex Trigger

[SalesForce] Trigger to copy child object picklist values to parent object separated by comma

Related Topic