[SalesForce] How to compare values in for loop ? – in Trigger

I have 2 objects Timecard (pse__Timecard_Header__c) and Periods (c2g__codaPeriod__c).

There is a lookup field in Timecard Period__c which is related to Period.

From Timecard, I need
end date pse__End_Date__c and company id (lookup field) pse__Project__r.pse__Region__r.ffpsai__OwnerCompany__r.Id

From Periods, I need
start date c2g__StartDate__c and owner company c2g__OwnerCompany__c.

The idea is here to compare these fields i.e.

end date(timecard) = start date (period) and
company id(timecard) = owner company (period)

I am stuck at the last step as how to compare these values and if they are matched then assign it to the respective fields.

trigger Timecard on pse__Timecard_Header__c (after insert) {

    List<pse__Timecard_Header__c> tc_list = [select Id, pse__End_Date__c, pse__Project__r.pse__Region__r.ffpsai__OwnerCompany__r.Id 
        from pse__Timecard_Header__c
        where Id IN :Trigger.newMap.KeySet()];

    system.debug('TC_LIST: ' + tc_list);

    Set<Date> tc_set = new Set<Date>();

    for (pse__Timecard_Header__c tcdate: tc_list)
    {
        Date aDate = tcdate.pse__End_Date__c.toStartOfMonth();
        tc_set.add(aDate);
    }

    Set<String> tc_setofId = new Set<String>();
    for (pse__Timecard_Header__c tcId: tc_list)
    {
        String s = tcId.pse__Project__r.pse__Region__r.ffpsai__OwnerCompany__c;
        tc_setofId.add(s);
    }

    List <c2g__codaPeriod__c> periodDetails = [Select Id, c2g__StartDate__c,c2g__EndDate__c, c2g__OwnerCompany__c, c2g__Closed__c 
        from c2g__codaPeriod__c
        where c2g__StartDate__c IN: tc_set
        and c2g__OwnerCompany__c IN: tc_setofId];

    for (pse__Timecard_Header__c timecardCompare: tc_list){

        for (c2g__codaPeriod__c periodCompare: periodDetails){
            //if 
            //to do comparison here
        }
    }   
}

Best Answer

Your logic is incorrect and you are performing necessary queries as well as storing them in a way that make your code very difficult to process the record.

In the below code I have created a set of period record IDs.

The I create a map of those periods.

This allows you to cycle through the timecard headers and quickly access the associated period record and compare the values:

trigger Timecard on pse__Timecard_Header__c (after insert) {


  List<pse__Timecard_Header__c> tc_list = [select Id, Period__c, pse__End_Date__c, pse__Project__r.pse__Region__r.ffpsai__OwnerCompany__r.Id 
                                             from pse__Timecard_Header__c
                                             where Id IN :Trigger.newMap.KeySet()];

Set<ID> period_ids = new Set<ID>();

for (pse__Timecard_Header__c tc: tc_list)
    {
        period_ids.add(tc.Period__c);
    }


Map <ID,c2g__codaPeriod__c> periodDetails = New Map<ID,c26__codaPeriod__c>([Select Id, c2g__StartDate__c,c2g__EndDate__c, c2g__OwnerCompany__c, c2g__Closed__c 
                                            from c2g__codaPeriod__c
                                            where c2g__StartDate__c IN: tc_set
                                            and ID IN: period_ids]);

for (pse__Timecard_Header__c timecardCompare: tc_list){

    if(periodDetails.containsKey(timecarCompare.Period__c)){

      if(timeCardCompare.pse__End_Date__c == periodDetails.get(timeCardCompare.Period__c).c2g__EndDate__c){
        //do stuf if equal
      }

    }

}

}

Related Solutions

[SalesForce] get / compare children values on map

The children records will be contained within standard List collections under the parent object record.

Enhancing your much-too-genericized code sample:

Map<Id, Account> AcctOppCustomObjectMap = new Map<Id, Account>([SELECT Id
                                                                    ,(SELECT xxx 
                                                                        FROM xxx__r)
                                                                    ,(SELECT yyy 
                                                                        FROM yyy__r) 
                                                                FROM Account
                                                                WHERE Id IN :idSet]);

List<yyy__c> yThingsToUpdate = new List<yyy__c>();

for (Id accountId : AcctOppCustomObjectMap.keyset()) {
    Account acct = AcctOppCustomObjectMap.get(accountId);

    // the acct reference will have child lists for your subqueries
    // they will not be null, but they could be empty lists
    List<xxx__c> xxxList = acct.xxx__r;
    List<yyy__c> yyyList = acct.yyy__r;

    // iteration of the child records possible now using these two lists
    for (xxx__c xThing : xxxList) {
        for (yyy__c yThing : yyyList) {
            if (xThing.value == yThing.value) {
                // create your relationship and 
                // add to a list for bulk update / insert
                yThingsToUpdate.add(new yyy__c(Id = yThing.Id
                                                   , xxx__c = xThing.Id));

                break; // exit the for loop on the first match if desired
            }
        }
    }
}


if (!yThingsToUpdate.isEmpty()) {
    update yThingsToUpdate;
}

I would probably iterate each child list just once each to create maps of the contents by a desired key so that I could perform a Map.get() instead of repeatedly iterating lists to find the other child record to compare against. Your code sample needs more specific information in it.

Repeated iteration of the yyy list within the xxx list will limit your ability to process records since these will use script statements to iterate and match the records.

[SalesForce] Compare 2 Lists and Remove Duplicates

My first thought is to turn to a pair of Set<Timecard__c>.

Start by gathering the set of Ids representing the contractors from the selected Placement__c records
create Timecard__c records (only in memory, no DML insert at this stage), setting Contractor__c, Week_Start_Date__c, and Week_End_Date__c. Put these records into a Set<Timecard__c>
Run a query for the Contact records matching those contractor Ids, and include a parent-child subquery for all related Timecard__c records
- Make sure the subquery only pulls in the same fields as you set when creating the initial set of Timecard__c records
Iterate over the Contacts, and put all of the related Timecard__c records into a different set
Finally, set1.removeAll(set2)

The idea is that the hash function underlying the Set type should produce identical results if you pass in different object instances with exactly the same fields populated, and exactly the same values for those fields.

That allows you to use remove() or removeAll() to do the heavy lifting.

In testing this myself, the general idea works but a query will also pull the Id and RecordTypeId, which means you'd need to iterate over the related Timecard__c records and explicitly create new Timecards that omit the Id and RecordTypeId rather than just being able to directly addAll() on the second set from the list of related Timecard__c records on the Contact.

code would look like this:

// startDate and endDate defined elsewhere
List<ts2__Placement__c> selectedPlacements = new List<ts2__Placement__c>();
Set<Id> contactIds = new Set<Id>();
Set<Timecard__c> timecards = new Set<Timecard__c>();
Set<Timecard__c> existingTCs = new Set<Timecard__c>();

for (pPlacement pPla : getPlacements()) {
  if (pPla.selected == true) {
    selectedPlacements.add(pPla.pla);
    contactIds.add(pPla.ts2__Employee__c);
    timecards.add(
      new Timecard__c(
        Contractor__c = pPla.ts2__Employee__c,
        Week_Start_Date__c = startDate,
        Week_End_Date__c = endDate
      )
    );
  }
}

if (!selectedPlacements.isEmpty()) {
  for (Contact con :[SELECT Id, (SELECT Contractor__c, Week_Start_Date__c, Week_End_Date__c FROM Timecards__r) FROM Contact WHERE Id IN :contactIds]) {
    for(Timecard__c tc :con.Timecards__r){
      existingTCs.add(new Timecard__c(
      Contractor__c = tc.ts2__Employee__c,
      Week_Start_Date__c = tc.Week_Start_Date__c,
      Week_End_Date__c = tc.Week_End_Date__c);
    }
  }
}

timecards.removeAll(existingTCs);

insert timecards;

Best Answer

Related Solutions

[SalesForce] get / compare children values on map

[SalesForce] Compare 2 Lists and Remove Duplicates

Related Topic