[SalesForce] how to get Product name using product2 from opportunitylineitems

here is my code in which i am trying to get the product name from opportunity line item but its returning back NULL value. can anyone please help me to get that product name. I can get id from product2 but i want the name of product so that i can abbreviate it and can store it in Order_Name__c field of orderItem. After adding the product only i am firing this trigger.

   public class Procuct_Adding_To_Order{

public static void productOrder(List<OpportunityLineItem> oli){ 
   system.debug('-----------------------');

    set<id> prodset = new set<Id>();
for(OpportunityLineItem item : oli)
{
  prodSet.add(item.product2id);
}
// collect products
Map<Id, product2> prodMap = new Map<Id, Product2>([select name from product2 where id in :prodSet]); 

// create a map for OLIid & corresponding Product Name
Map<Id, string> OLIprodMap = new Map<Id, string>();

for(OpportunityLineItem item : oli)
{
 OLIprodMap.put(item.id, OLIprodMap.get(oli.product2id).name); //getting Error in this line.
}


   set<Id> setOppId = new set<Id>(); 
    for(OpportunityLineItem obj: oli){ 
        setOppId.add(obj.OpportunityId); 
    } 

   list<opportunity> needed = [Select Master_Opportunity__c from opportunity Where Opportunity.id =: setOppId];
        List<OrderItem> orderIt = new List<OrderItem>();
    for(Order ord: [Select id from Order where opportunityId =: needed[0].Master_Opportunity__c])
      {
       for(OpportunityLineItem o : oli)
       {  
        OrderItem op = new OrderItem(); 
        op.Opportunity_del__c = needed[0].Master_Opportunity__c; 
        op.orderId = ord.id;
        op.Order_Name__c = o.product2Id;
        system.debug('-----------------------3333333333333333333333'+ o.Product2Id);
        op.PriceBookEntryId = o.PriceBookEntryId;
        op.Quantity = o.Quantity;
        op.UnitPrice = 100;
        orderIt.add(op);

          } 
        }
    upsert orderIt; 
}
}

Best Answer

As you are calling this method from trigger so you can't direct access parent field from the 'Trigger.New' what you can do here is first store product ID in set and query of Product object and get Name of product and store it in the map. Now iterate over the list and using the Product Id get Product name from Map and use it in your code.

Related Solutions

[SalesForce] get / compare children values on map

The children records will be contained within standard List collections under the parent object record.

Enhancing your much-too-genericized code sample:

Map<Id, Account> AcctOppCustomObjectMap = new Map<Id, Account>([SELECT Id
                                                                    ,(SELECT xxx 
                                                                        FROM xxx__r)
                                                                    ,(SELECT yyy 
                                                                        FROM yyy__r) 
                                                                FROM Account
                                                                WHERE Id IN :idSet]);

List<yyy__c> yThingsToUpdate = new List<yyy__c>();

for (Id accountId : AcctOppCustomObjectMap.keyset()) {
    Account acct = AcctOppCustomObjectMap.get(accountId);

    // the acct reference will have child lists for your subqueries
    // they will not be null, but they could be empty lists
    List<xxx__c> xxxList = acct.xxx__r;
    List<yyy__c> yyyList = acct.yyy__r;

    // iteration of the child records possible now using these two lists
    for (xxx__c xThing : xxxList) {
        for (yyy__c yThing : yyyList) {
            if (xThing.value == yThing.value) {
                // create your relationship and 
                // add to a list for bulk update / insert
                yThingsToUpdate.add(new yyy__c(Id = yThing.Id
                                                   , xxx__c = xThing.Id));

                break; // exit the for loop on the first match if desired
            }
        }
    }
}


if (!yThingsToUpdate.isEmpty()) {
    update yThingsToUpdate;
}

I would probably iterate each child list just once each to create maps of the contents by a desired key so that I could perform a Map.get() instead of repeatedly iterating lists to find the other child record to compare against. Your code sample needs more specific information in it.

Repeated iteration of the yyy list within the xxx list will limit your ability to process records since these will use script statements to iterate and match the records.

[SalesForce] How to insert and get value for lookup field (Trigger)

Lets start with populating lookup fields:

Order_product__c= [select Product2 OrderItem where OrderItemNumber='0000000028']

It's clear what you're trying to do, but that won't work. Firstly, the SOQL statement can return an (empty) list or object, but a lookup field is actually populated with the ID. Conveniently you have this value as you're in the After Insert context!

Order_product__c = o.id;

That's it!

Though, I'd like to point your attention to bulkification. It's good to see that you're putting all your new records in a list and only inserting your list of new records to the database once your for-loop is over. That's a core way of dealing with bulk processing of records, another important one is avoiding SOQL queries in your for-loops.

So in any future trigger, where you would need to query for related data, you'd first collect all the ID's for which you need to query, do the query to get the data, and then apply it to your list of records.

Welcome to developing in salesforce and salesforce.Stackexchange :-)

Related Topic