[SalesForce] how to insert records in an object only when there are no records present in it before

How to insert records in an object only when there are no records present in it before… the following trigger inserts records in payment_schedule object(child to opportunity) when a checkbox is true.

The problem is,it keeps on inserting whenever i update something!! :(.Only once record should be inserted

trigger generatePS on Opportunity (after insert,after update) {
List<Id> projectIds = new List<Id>();
id Oid;
for(opportunity opp :Trigger.new) {
    if(opp.Generate_Payment_Schedule__c == true )
    {
        projectIds.add(opp.project_name__c);
        oid = opp.id;
    }
}
system.debug('Project ID'+ projectIds);  
List<Payment_Schedule__c> ps = new List<Payment_Schedule__c>();
List<Payment_Schedule_Template__c> pst = [select name,Project__c,Due_Date__c,Amount_Percentage_Made__c from Payment_Schedule_Template__c where Project__c in :projectIds ];
system.debug('PST'+ pst);

    for(Payment_Schedule_Template__c psinsert:pst)
    {

        Payment_Schedule__c payshcedule = new Payment_Schedule__c();
        payshcedule.name = psinsert.name;
        payshcedule.Amount_Percentage_Made__c = psinsert.Amount_Percentage_Made__c;
        payshcedule.Due_Date__c = psinsert.Due_Date__c;
        payshcedule.Opportunity__c = Oid;
        ps.add(payshcedule);

    }


    system.debug('Payment Schedule to insert'+PS);

     insert ps;
     }

What am I doing wrong ?

Best Answer

Ok, first of all, do you want your code to run both on insert or also on update?

If you would let the code run only on insert, when checking your box Generate_Payment_Schedule__c after the record was inserted, the code wouldn't run.

If your code should run only on insert, remove the "after update" from your trigger. (first line)

If your code should run on both insert and update, you will need to check if the Generate_Payment_Schedule__c checkbox was changed from false to true.

@Phil Hawthorn posted the following samplecode on how to compare the "old" to the "new" values (Just update when a specific field changes):

for( Account accountId : Trigger.newMap.keySet() )
{
  if( Trigger.oldMap.get( accountId ).Antecipado__c != Trigger.newMap.get( accountId ).Antecipado__c )
  {
     // do something here because your field has changed
  }
}

You should use such code to check for which opportunities it needs to generate the child records.

Related Solutions

[SalesForce] Only execute Before Update trigger if conditions are met

You can add this sort of guard in your trigger:

Set<Id> ids = new Set<Id>();
for (Opportunity opp : Trigger.new) {
    if (opp.Checkbox__c) {
        Opportunity old = Trigger.oldMap.get(opp.Id);
        if (opp.Checkbox__c != old.Checkbox__c) {
            ids.add(opp.Id);
        }
    }
}
if (ids.size() > 0) {
    // Query
}

so that the queries are only done if the checkbox is checked and when the checkbox value has changed (if that is appropriate too).

[SalesForce] Unit Test is Providing 0% Coverage for Apex Trigger

The trigger code is having lot of redundancy, So I modified it. before posting the modified code few lines of explanation what I changed. you collected account Ids twice and did the condition check twice where once is more enough. I am also made changes to the test class, where Task data is provided which is not required because the trigger has to create it once the necessary conditions are met. I am expecting this trigger should work for you, if there is any errors feel free to post as a comment.

trigger OpportunityAfter on Opportunity (after update){

    Set AccountIDs = new Set();

    for(Opportunity o : trigger.new){
        if(opp.StageName == 'Closed - Lost' && opp.Business_Line__c == 'Workforce' && 
            opp.Survey_Type__c != 'APulse' && trigger.oldMap.get(opp.Id).StageName != opp.StageName){

                AccountIDs.add(o.AccountId);
         }
    }

    Task[] tasksToInsert = new Task[]{};

    for (Account acc : [Select Id, Name, OwnerId from Account where Id IN :AccountIds]){
        for (Opportunity opp : trigger.new){
            if(opp.AccountId == acc.Id){
                Task tas = new Task();
                tas.WhatId=acc.Id;
                tas.OwnerId=opp.OwnerId;
                tas.Subject='Follow-up: ' + opp.name + ' - ' + acc.name;
                tas.ActivityDate=(opp.CloseDate + 180);
                tas.Description='Follow up to see how engagement initiatives are going and if Avatar can help. Refer to lost opportunity: ' + opp.name;
                tasksToInsert.add(tas);                                                         
            }
        }
    }
    if(tasksToInsert != null && !tasksToInsert.isEmpty())
    Database.insert(tasksToInsert);

}

@isTest
public class TestClass {

    static testMethod void myUnitTest() {

    //Set up user
    User u1 = [SELECT Id FROM User WHERE Email='abc@sampleemail.com'];
    test.startTest();  
    //Run As U1
    System.RunAs(u1){

    System.debug('Testing trigger... (single record validation)');

    //NEW Account record
    Account acc = new account();
    acc.Name = 'Test Account';
    acc.Industry = 'Healthcare';

    insert acc;

    //NEW Opportunity record
    Opportunity opp = new Opportunity();
    opp.Name = 'Test Opportunity'; 
    opp.CloseDate = System.today();
    opp.StageName = 'S1 - Investigative';
    opp.Type = 'Repeat Business - Wrkforce HC';
    opp.AccountId = acc.Id;
    opp.Survey_Type__c = 'Product Name';

    insert opp;

    opp.StageName = 'Closed - Lost';
    opp.Reason_Won_Lost__c = 'Relationship';
    opp.Business_Line__c = 'Workforce'  //added this line to meet the if condition while collecting the set of id in the trigger.

    update opp;
   test.stopTest();
    // Here I am expecting the task has been inserted and doing a query for it         and check it in the assert statement.
   Task  testTask=[Select Id, WhatId from Task where WhatId=:acc.Id];
    //Validate single insert
    System.assertEquals(acc.Id, testTask.WhatId);

    }
    }
}

Best Answer

Related Solutions

[SalesForce] Only execute Before Update trigger if conditions are met

[SalesForce] Unit Test is Providing 0% Coverage for Apex Trigger

Related Topic