[SalesForce] How to tell if this trigger is firing

I'm a newbie here, and this is my first trigger.

This is a trigger which was given to me on here. It is in a sandbox in my organization. It is meant to create child records based upon a multi-value field in a parent record at the time the parent is saved. It doesn't seem to be creating the records upon being saved :

trigger AutoCreateSubs on Contract_Overview__c (after insert) {
 List<Subs_Serviced_On_Contract__c> subs = new List<Subs_Serviced_On_Contract__c>();

    //For each position processed by the trigger, add a new  

    //Subs_Serviced_On_Contract record for the specified Subsidiaries_On_Contract__c.  

    //Note that Trigger.New is a list of all the new positions  

    //that are being created.  

    for (Contract_Overview__c newContract : Trigger.New) {
        if (newContract.Subsidiaries_On_Contract__c != null) {
            // split out the multi-select picklist using the semicolon - or comma -delimiter
            for(String subsoncontract: newContract.Subsidiaries_On_Contract__c.split(',')){
                subs.add(new Subs_Serviced_On_Contract__c(
                        Name = newContract.Id,
                        Contract_Overview__c = newContract.Id,
                        Subsidiary_Name__c = (Id)subsoncontract,
                        Logo_Usage_Allowed__c = 'Yes'));
            }
        } 
    }
    insert subs;

}

The trigger is at 100% code coverage and is Active. There is a value in the Subsidiaries_On_Contract_c field, so that wouldn't be preventing it from firing off.

Does anybody see anything wrong with this code which would prevent it from creating the records ? I'm not sure if it is error-ing out or not even firing off. Can somebody give me some direction on this ?

Thank you very much for your help.

Best Answer

The Subsidiaries_On_Contract__c field needs to be populated and in addition have some values separated by a comma.

Eg abc,def

The code is trying to split based on the comma and creating a record for each part.

So check that the Subsidiaries_On_Contract__c field is populated.

You can set up debug monitor using Setup > Monitoring > Debug Logs

Add the name of the executing user, perform the save, and then come and look at the debug logs to see if there is any activity. (Worth adding some debugs in the trigger to print out say Subsidiaries_On_Contract__c - so System.debug('Subsidiaries_On_Contract__c ' + newContract.Subsidiaries_On_Contract__c); within the for loop)

Related Solutions

[SalesForce] Trigger upsert questions

It would seem like the Subsidiary_Name__c is a Unique field (possibly External Id) on Subs_Serviced_On_Contract__c. Navigate to the field and check to see if the Unique checkbox is checked.

If so uncheck it.

If however it is only an external id, then you need to explicitly specify the field to use that as an external id, else the salesforce id is used for the upsert.

upsert subs Subsidiary_Name__c;

To create a composite key, create a new Text field, mark it as External Id and Unique. Then create a workflow, which populates this field to be Contract Name+Subsidiary Name using a field update.

[SalesForce] Problem with a trigger loop

Not something I can test locally, but some things I changed looking at it:

I use a Set to keep track of all possible names before querying, to filter out duplicates. I calculated the arrays of names once and stored those arrays in an array of the same length and indices as the trigger.new array. (We've found that pre-allocating arrays of known length doesn't make much different to CPU governor usage, especially here as the array is no bigger than 200).

Set<String> allSubAccountNames = new Set<String>();
List<List<String>> subAccountNamesByOverview = new List<List<String>>;

for (Contract_Overview__c newCont : Trigger.New) 
{
   String[] subAccountNames = splitField(newCont.Subsidiaries_On_Contract__c);
   allSubAccountNames.addAll(subAccountNames);
   subAccountNamesByOverview.add(subAccountNames);
}

Map<String, Id> subAccIdsByName=new Map<String, Id>();
for (SubsidiariesAndBrands__c subAcc : [select id, Name from SubsidiariesAndBrands__c where Name in :allSubAccountNames]) 
{
   subAccIdsByName.put(subAcc.Name, subAcc.id);
}

My split function is

private String[] splitField(String value)
{
   value = value.replaceAll('\[|\]','');
   return value.split(',');
}

It may be possible to do this in a single REGEX, but we become more obtuse.

The other main difference is I did an insert not an upsert at the end as they're new records.

List<Subs_Serviced_On_Contract__c> subs = new List<Subs_Serviced_On_Contract__c>();
for (Integer i = 0; i < Trigger.New.size(); i++) 
{
    Contract_Overview__c newContract = Trigger.New[i];
    String[] subAccountNames = subAccountNamesByOverview[i];

    for(String subName : subAccountNames)
    {
        Id subId = subAccIdsByName.get(subName);
        System.assert(subId != null, 'Failed to find subaccount by name ' + subName);

        Subs_Serviced_On_Contract__c ssoc = new Subs_Serviced_On_Contract__c(
            Name = subName,
            Contract_Overview__c = newContract.Id,
            Account__c = newContract.Account__c
            Subsidiaries_and_Brands__c = subId,  
            Contract_and_Sub__c = newContract.Name + '~' + subName,
            Contract_Start_Date__c = newContract.Contract_Start_Date__c,
            Contract_End_Date__c = newContract.Contract_End_Date__c, 
            Logo_Usage_Allowed__c = 'Yes');

        subs.add(ssoc);
    }
}
insert subs;

Best Answer

Related Solutions

[SalesForce] Trigger upsert questions

[SalesForce] Problem with a trigger loop

Related Topic