[SalesForce] I have created a trigger ..i am updating contact address using account address

as soon a I create account record I want to update the contact record's mailing address field. I have written trigger on account because if I update account address field automatically related contacts address field should update I have written this trigger m not finding result.

trigger createopp on Account (after insert,after update) {
    List<Contact> opp = New List<Contact>();
    set<id> ids=new set<id>();

    for(Account  con:trigger.new) {
        list<Contact> oppsi=[select id,mailingstreet,mailingcity,mailingstate,mailingpostalcode  from contact where accountid :con.id ];
        if(oppsi.size()==0){
            Contact opp1 = new Contact();
            opp1.AccountID= con.id;
            opp1.mailingstreet = con.Shippingstreet;
            opp1.mailingcity = con.Shippingcity;
            opp1.mailingstate = con.Shippingstate;
            opp1.mailingpostalcode =con.shippingpostalcode;
            opp.add(opp1);
        }
    }
    try {
        insert opp;
    } catch(Dmlexception e) {}
}

Best Answer

Please see code below and comments inside

trigger Account on Account (after insert, after update) {
    List<Contact> contactsForUpsert = New List<Contact>();

    // We want to avoid SOQL inside the for loop, because it might be a reason of troubles
    // and in order to follow best practices, thus we queried all needed information about Contacts
    // which are related with Accounts which are under insert/update
    // You have to think in 200 record's context when working with triggers
    // -->
    Map<Id, Contact> contactsByAccountId = new Map<Id, Contact>();
    List<Contact> contacts = [SELECT Id,
                                     AccountId,
                                     mailingstreet,
                                     mailingcity,
                                     mailingstate,
                                     mailingpostalcode
                            FROM Contact WHERE AccountId IN: Trigger.newMap.keySet()];
    for (Contact cont: contacts) {
        contactsByAccountId.put(cont.accountId, cont);
    }
    // <-- finished collecting information about Contacts. All contacts were placed in Map<AccountId, Contact>

    for (Account account: Trigger.new) {
        // old records are available only in update call
        Account old;
        if (Trigger.isUpdate) {
            old = Trigger.oldMap.get(account.Id);
        }
        // we want to perfoem the update of contact address fields in two cases:
        //  1. we insert new account, but there is a question: is that right business case for inserting Contact record here?
        //  2. we updated ShippingAddress in an exisitng account, I do believe that we do not want to update Contact record 
        //  each time when other fields were changed
        Boolean isShippingAddressChangedOrNew = Trigger.isInsert ? true :
                                                (   account.ShippingStreet != old.ShippingStreet
                                                 || account.ShippingCity != old.ShippingCity
                                                 || account.ShippingState != old.ShippingState
                                                 || account.ShippingPostalCode != old.ShippingPostalCode
                                                 || account.ShippingCountry != old.ShippingCountry) ? true : false;
        // check that field was changed
        if (isShippingAddressChangedOrNew) {
            // get existing Contact if exist
            Contact relatedContact = contactsByAccountId.get(account.Id);
            if (relatedContact == null) { // for insert call we create new Contact record
                relatedContact           = new Contact();
                relatedContact.AccountID = account.Id;
                relatedContact.LastName = 'test';
            }
            relatedContact.mailingstreet     = account.Shippingstreet;
            relatedContact.mailingcity       = account.Shippingcity;
            relatedContact.mailingstate      = account.Shippingstate;
            relatedContact.mailingpostalcode = account.shippingpostalcode;
            contactsForUpsert.add(relatedContact);
        }

    }

    try {
        upsert contactsForUpsert;
    } catch(Dmlexception e) {
        System.debug(LoggingLevel.ERROR, 'Contact insert from createopp.trigger has failed with message:' + e.getMessage());
    }
}

Read articles about trigger best practice:

Related Solutions

[SalesForce] Insert Trigger on Account(Using MAP)

There are a lot of improvements that need to be done on your code.
1.

  Map<Id,Contact> mp = new Map<Id,Contact>();  // new map 
  for(Contact con :trigger.new){  
     mp.put(con.AccountId,con);  // enter contact id in map
  }

Here you need not create a map if you are using the map.keySet() method in the SOQL. Instead create a Set<Id> and use it in the SOQL.
2.

  Map<Id,Account> mp1 = new Map<Id,Account>();  // new map 
  for(Account a : listacc){  //  enter the list details in a
     mp1.put(a.Id,a);   //   enter account id in map
  }

Here as you are fetching the listacc from SOQl, you can directly create a Map<Id, Account> from it. Use:

Map<Id, Account> mapIdAccount = new Map<Id, Account>([YOUR SOQL QUERY]);

When you pass a list of sObjects as a parameter to the map constructor, it creates a map of Id and the sObject. Refer Salesforce Map Documentation
3.

  for(Contact con :trigger.new){   //new contacts 
     con.Description = mp1.get(con.AccountId).Description;  //  discription field 
  }

Here before you set con.Description, check whether mp1.get is null or not. If the map doesn't contain that key, the get() method simply returns null. Hence it produces a NullPointerException.
Use

if(mp1.containsKey(con.AccountId))
   con.Description = mp1.get(con.AccountId).Description;

[SalesForce] Insert trigger on Account creates new case and After Trigger on Case failed to Update case

Your trigger on Case should be before insert not after insert. You can not update records in an after trigger.

Best Answer

Related Solutions

[SalesForce] Insert Trigger on Account(Using MAP)

[SalesForce] Insert trigger on Account creates new case and After Trigger on Case failed to Update case

Related Topic