[SalesForce] Illegal Integer but only after threshold

We are deploying a tiered schedule for pricing related to products based on a firms assets under management. The tiers have breakpoints based on these aum fields (currency).

In apex I have a method for building tier schedules, which works fine until I hit the $3B entry breakpoint. When I run the method at this breakpoint, I get a message in the developer console about an 'Illegal Integer'.

The Apex Method that I have accepts the following parameters and then processes the new tier schedules:

public static List<rbTier__c> createTiers(Id productFamilyId, Integer batchSize, Decimal beginningAUM, decimal aumIncrement, Decimal beginningBasePrice, Decimal basePriceIncrement)
{
    List<rbTier__c> tierList = new List<rbTier__c>();
    List<rbTierFamily__c> familyList = [Select Id, Name, RB_Product__c From rbTierFamily__c WHere Id = :productFamilyId];
    List<rbTier__c> existingTiers = getTiersForFamilies(familyList);
    Integer sequence = 0;
    INteger plusOne = 1;
    Integer minusOne = -1;
    Decimal aumFloor = beginningAUM;
    Decimal aumCeiling = aumFloor + aumIncrement + minusOne;
    if(existingTiers.size() > 0)
    {
        sequence = existingTiers.size() + plusOne;
    }
    else
    {
        sequence = 1;
    }
    for(Integer i = 0;i < batchSize; i++)
    {
        if(sequence == 1)
        {
            rbTier__c t = new rbTier__c();
            t.AUM_Floor__c = aumFloor;
            t.AUM_Ceiling__c = beginningAUM + aumIncrement;
            t.Sequence__c = sequence + (1 * i);
            t.Name = 'Tier '+ String.valueOf(sequence + (1 * i));
            t.Base_Amount__c = beginningBasePrice + (basePriceIncrement * i);
            t.RB_Tier_Family__c = productFamilyId;
            tierList.add(t);
            aumFloor = aumCeiling + plusOne;
            aumCeiling = aumFloor + aumIncrement + minusOne;
        }
        else
        {
            System.debug('aum floor entering loop is '+aumFloor+ ' and aum ceiling entering is '+ aumCeiling);
            rbTier__c t = new rbTier__c();
            t.AUM_Floor__c = aumFloor;
            t.AUM_Ceiling__c = aumCeiling;
            t.Sequence__c = sequence + (1 * i);
            t.Name = 'Tier '+ String.valueOf(sequence + (1 * i));
            t.Base_Amount__c = beginningBasePrice + (basePriceIncrement * i);
            t.RB_Tier_Family__c = productFamilyId;
            tierList.add(t);
            aumFloor = aumCeiling + plusOne;
            aumCeiling = aumFloor + aumIncrement + minusOne;
            System.debug('aum floor exiting loop is '+aumFloor+ ' and aum ceiling exiting is '+ aumCeiling + ' and AUM increment is '+ aumIncrement);

        }
    }
    if(tierList.size() > 0)
    {
        try 
        {
            RBS_GlobalDMLHandler.insertObjectList(tierList);    
        } 
        catch(Exception ex) 
        {
            System.debug('Problem encountered inserting the tier batch | '+ex.getMessage());
        }
    }
    return tierList;
}

I ran this in from the developer console in stages as outlined here:
(note the Id is hardcoded only for the purposes of testing)

RBS_TierHelper.createTiers('a184B000000xdd9QAA', 1, 0, 99999999, 10000, 0);
RBS_TierHelper.createTiers('a184B000000xdd9QAA', 8, 100000000, 50000000, 11250, 1250);
RBS_TierHelper.createTiers('a184B000000xdd9QAA', 5, 500000000, 100000000, 22500, 2500);
RBS_TierHelper.createTiers('a184B000000xdd9QAA', 8, 1000000000, 250000000, 35000, 2500);
RBS_TierHelper.createTiers('a184B000000xdd9QAA', 4, 3000000000, 500000000, 55000, 5000);

The outputs for the first four traunches generate results as expected. The fifth traunch, beginning at $3,000,000,000 returns an error from the dev console; 'Line 7, Column 53 Illegal Integer'.

Does anyone know what is going wrong here?

Thanks in advance for any insight you can provide!

Best Answer

Integers in Salesforce are signed, 32-bit (and 2's compliment, I assume)

The maximum value that can be held in an Integer type is therefore (2^31) - 1 = 2,147,483,647

If you need to work with values larger than that, then you'll need to use the Long type instead of Integer

Related Solutions

[SalesForce] Compile Error: Illegal assignment from Decimal to Integer

http://www.salesforce.com/us/developer/docs/apexcode/Content/apex_methods_system_integer.htm

itemlst.Quantity = integer.valueOf(templook[i].Quantity__c);

Integer.valueOf will work.

Edit:

 Decimal myDecimal = 4.12;
 Integer a=myDecimal.intValue();
  System.debug('*****'+a);

I used Decimal.intValue() and it works as shown.

[SalesForce] Map messes up stored records ! Salesforce Bug or developer’s bug

The values() list is not guaranteed to be in order by default, because the hashing algorithm may arbitrarily reorder the elements in the list. I am not sure if I would classify this as a bug, but I do know I would never depend on the values() list being in any particular order; Visualforce has a hard time dealing with maps in general.

What I would do is instead create a wrapper class that keeps the list in a predefined order. I created this technique after I ran across a bug where Visualforce would die unexpectedly when a key was missing from a map, but I'm sure it has other uses as well. Here's the design pattern:

public class Controller {
    Map<Id, SObject> objects;
    public ObjectWrapper[] objectList { get; set; }

    public class ObjectWrapper {
        Controller controller;
        Id key;

        public ObjectWrapper(Controller controller, Id key) {
            this.controller = controller;
            this.key = key;
        }

        public SObject record { 
            get { return controller.get(value); } 
            set { controller.put(key, value); }
        }
    }

    public Controller() {
        objects = new Map<Id, SObject>();
        objectList = new ObjectWrapper[0];
        for(SObject record: [...]) {
            objects.put(record.Id, record);
            objectList.add(new ObjectWrapper(this, record.Id);
        }
    }
}

The basic premise is that the objectList provides a stable ordering of records which guarantees that the data won't be obliterated during deserialization. You can add values to the objectList, and you can even specify the same key twice to cause the value to appear more than once (but then you risk the object being clobbered randomly).

Best of all, you could implement Comparable to allow automatic sorting of the objectList while leaving the map alone. Since the map is naturally unordered, storing the order as a separate list will set things straight. Best of all, this pattern specifically avoids the "missing map key" error.

Update

As an example version of faulty logic, imagine we have the following code:

Opportunity[] records = somemap.values().deepClone(true, true, true);
String[] fields = new String[] { 'Name', 'CloseDate', 'Id' };

for(Opportunity record: records)
    record.closedate = System.Today()+(1000*Math.random()).intValue();

for(Integer fdx = 0; fdx < fields.size(); fdx++)
    for(Integer idx = 0; idx < records.size(); idx++)
        somemap.values()[idx].put(fdx, records[idx].get(fields[fdx]));

This code would be perfectly sane if we replaced somemap.values() with someList, instead. That's because Map.values() returns an unordered list, which means that the results are subject to re-order themselves arbitrarily, probably due to internal hashing. Therefore, since somemap.values() is not guaranteed to return the same order, the fields could easily become scrambled; you may as well be calling: somemap.values()[(somemap.size()*Math.random()).intValue()].put(fdx, records[idx].get(fields[fdx]));

Hopefully this illustrates the problem better. It's nothing to do with serializing or deserializing, it has to do with the values() list not necessarily retaining its order, since it is, by definition, an unordered list.

Best Answer

Related Solutions

[SalesForce] Compile Error: Illegal assignment from Decimal to Integer

[SalesForce] Map messes up stored records ! Salesforce Bug or developer’s bug

Update

Related Topic