[SalesForce] Multiple OR conditions not working IF statement

In my Apex Trigger I have code that I want to execute when any of the conditions are met.

trigger NewLeadSendToInfusionsoft on Lead (before insert, before update) {
    for (Lead l : Trigger.new) {
       if(l.LeadSource != 'dup' || l.LeadSource != 'Package Installation' || l.Email != null || l.Status != 'At Infusionsoft') {

           LeadInfusionsoft.sendNewLeadToInfusionsoft(l.FirstName, l.LastName, l.Title, l.Company,
                                                      l.Street, l.City, l.State, l.PostalCode,
                                                      l.Country, l.Phone, l.MobilePhone, l.Email, l.LeadSource);
       }
    }
}

The problem I have is it always executes, even though in the debug log it says the Email field is null.

Best Answer

When you have a != b || a != c where b != c, it will always be true. In this case, you always know this part of the clause will return true:

l.LeadSource != 'dup' || l.LeadSource != 'Package Installation'

It seems like you may just want to join all your clauses with && instead.

Related Solutions

[SalesForce] Only execute Before Update trigger if conditions are met

You can add this sort of guard in your trigger:

Set<Id> ids = new Set<Id>();
for (Opportunity opp : Trigger.new) {
    if (opp.Checkbox__c) {
        Opportunity old = Trigger.oldMap.get(opp.Id);
        if (opp.Checkbox__c != old.Checkbox__c) {
            ids.add(opp.Id);
        }
    }
}
if (ids.size() > 0) {
    // Query
}

so that the queries are only done if the checkbox is checked and when the checkbox value has changed (if that is appropriate too).

[SalesForce] Before Trigger is not picking up BillingCountry on the Account Object

You will have to check the code of Sales_AutoPopulateState.Sales_AutoPopulateState(Trigger.new);, you must be nulling out the value of Billing Country field in Sales_AutoPopulateState method.

I tried with your code and created records both in Classic and Lightning (although it should not matter) and I was able to get the value of Billing Country in logs.

You can confirm this by moving your debug statements before calling Sales_AutoPopulateState method, I am sure you would be able to find the value of Billing Country in logs.

Update

But from the screenshot that you mentioned in your question, it appears that you enabled State and Country picklists in your organization because both these fields are displayed as picklists and not text fields.

If that's the case, you will have to use BillingStateCode and BillingCountryCode in your trigger to get the selected values. And your logic should be based on those fields rather than BillingState and BillingCountry.

Change your trigger to below and you should be able to get the values in log

trigger AccountMasterTrigger on Account (before insert, before update) {
     if (Trigger.isBefore) {
        Sales_AutoPopulateState.Sales_AutoPopulateState(Trigger.new);
        for(Account acts : Trigger.new){
            System.debug('State: '+acts.BillingStateCode);
            System.debug('PostalCode: '+acts.BillingPostalCode);
            System.debug('Country: '+acts.BillingCountryCode);
        }
    }
}

Best Answer

Related Solutions

[SalesForce] Only execute Before Update trigger if conditions are met

[SalesForce] Before Trigger is not picking up BillingCountry on the Account Object

Related Topic