[SalesForce] page reloads before related record is updated

SEE SOLUTION AT BOTTOM OF QUESTION SINCE I WAS ABLE TO ANSWER IT ON MY OWN

I have a VF page that overrides the Opportunity view page, this is so that I can implement my own product related list. The related list has a Delete link that fires a delete of the opportunity line and also fires a trigger that calls a class method to perform an summary calculation up to the opportunity for some fields.

My problem comes because the Delete link fires this delete action but yet the page reloads BEFORE the opportunity update is completed. This causes the end user to see the "old" opportunity values even though they are being updated. This is true since a second refresh will show the updated opportunity values. What I need is for the Opportunity to be displayed AFTER it is updated and not before. See code below:

Opportunity View Override VF page code:

<apex:column headerValue="Action" style="text-align:center;width:50px;">
            <apex:outputLink target="_blank" title="Click to view record details (new tab/page)" value="/{!oli.id}">
                View  
            </apex:outputLink>
            <apex:commandLink title="Click to delete record" action="{!del}" styleClass="DelBTN" >
                Delete
                 <apex:param name="delname" value="{!oli.id}" assignTo="{!delOLIid}"/> 
            </apex:commandLink>
        </apex:column>

Controller:

 public PageReference Del () {
    if(delOLI!= null) {
    Delete delOLI;
    getOppFieldAndHistory(opp);
    queryOLIs(opp.id);
    }
    return null;
}

Please let me know if you have any input into this issue…

UPDATED SOLUTION:

I found the solution so posting in hope that it may help some other lost soul.
Basically I added a Page reference to the view of the Opportunity (see updated code below), whereas before I was simply letting the page refresh by not providing any rerender attribute.

public PageReference Del () {

    if(delOLI!= null) {
    Delete delOLI;
    getOppFieldAndHistory(opp);
    queryOLIs(opp.id);
    }
    PageReference oppPage = new ApexPages.StandardController(opp).view();
    oppPage.setRedirect(true);
    return oppPage;
}

Best Answer

SOLUTION:

I found the solution so posting in hope that it may help some other lost soul. Basically I added a Page reference to the view of the Opportunity (see updated code below), whereas before I was simply letting the page refresh by not providing any rerender attribute.

public PageReference Del () {

    if(delOLI!= null) {
    Delete delOLI;
    getOppFieldAndHistory(opp);
    queryOLIs(opp.id);
    }
    PageReference oppPage = new ApexPages.StandardController(opp).view();
    oppPage.setRedirect(true);
    return oppPage;
}

Related Solutions

[SalesForce] Button redirects page before async call is finished in another field

I think the user clicks on the Save button before the AJAX call is finished and the record is not saved, right? My solution is just to block the input elements on the page while the AJAX call works, and only if it finished - release the inputs. So user can not click on the Save button while your controller works.

Simple controller example:

public with sharing class test1 {
    // We will show some account on the page
    public List<Account> accounts { get; set; }

    public test1(){
        // Reading accounts
        accounts = [Select Id, Name, CustomerPriority__c From Account Limit 3];
    }

    public PageReference someAction(){
        // Your 'save' logic is here ....
        return null;
    }
}

Visualforce page. I will use JQuery to block the input elements on the page:

<apex:page controller="test1">
    <!-- Dynamically including the jQuery to the page -->
    <apex:includeScript value="https://ajax.googleapis.com/ajax/libs/jquery/1.9.1/jquery.min.js"/>

    <!-- This is a javascript function that will block and release elements -->
    <script>
        function blockAllInputs(param){
            if(param){
                jQuery('input[type=button], input[type=submit]').attr('disabled','disabled').removeClass('btn').addClass('btnDisabled');
                jQuery('select').attr('disabled','disabled');
            }
            else{
                jQuery('input[type=button], input[type=submit]').removeAttr('disabled').removeClass('btnDisabled').addClass('btn');
                jQuery('select').removeAttr('disabled');
            }
        }
    </script>

    <apex:form>
        <apex:pageBlock title="My Block">
            <apex:pageBlockButtons>
                <apex:commandButton value="Save" reRender="none"/>
            </apex:pageBlockButtons>
            <apex:pageBlockTable value="{!accounts}" var="a">
                <apex:column headerValue="{!$ObjectType.Account.fields.CustomerPriority__c.label}">
                    Value: 
                    <apex:actionRegion>
                        <apex:inputField value="{!a.CustomerPriority__c}" id="myField">
                            <apex:actionSupport event="onchange"
                                                action="{!someAction}"
                                                reRender="myField"
                                                onsubmit="blockAllInputs(true)"
                                                oncomplete="blockAllInputs(false)"/>
                        </apex:inputField>
                    </apex:actionRegion>
                </apex:column>            
            </apex:pageBlockTable>
        </apex:pageBlock>
    </apex:form>
</apex:page>

How it will looks like:

enter image description here

[SalesForce] Field Values In Dynamic Component Not Retaining After Error

We have used dynamic components in one piece of code and based on that experience since then have avoided them.

When normal Visualforce tags are used, the component tree is part of the serialized view state and that is necessary for the entered values to be displayed under error conditions. (The life cycle is likely to be this or similar.)

But you will notice that you have to use get methods for dynamic components and can't hold (non-transient) references to them. When we created a case on this (in 2013), the Salesforce support response was:

... dynamic components are not serializable ... is completely something working as designed ...

(Our assumption is that if they can't be serializable as controller fields they probably can't be serialized as part of the page component tree either.)

The bottom line appears to be that dynamic components don't behave well when errors occur. So the straightforward choices are to either just live with that or to re-implement without the dynamic components.

Had another case where dynamic components were the simplest way and have successfully (so far) worked around the field value not being retained problem via JavaScript. See the answer to How to keep components out of the Visualforce view state when they are not needed?.

Best Answer

Related Solutions

[SalesForce] Button redirects page before async call is finished in another field

[SalesForce] Field Values In Dynamic Component Not Retaining After Error

Related Topic