[SalesForce] Recall Approval Process through Trigger and Controller

I need to unlock a custom object (Events__c) record when an Task is created.
Hence I propose to recall the approval process when the Task is created by using an After Insert Trigger.

Here is the below code…

Task Trigger

trigger TaskTrigger on Task (after insert) {
    if(Trigger.IsInsert){
         TaskSequenceController.afterInsert(trigger.new);    
    }  
}

Sequence Controller

public class TaskSequenceController{
     /**
    * Method Name : afterInsert
    * Parameter   : 
    * Return type : None
    * Description : This method is used to perform operation on after Insert event of TaskTrigger
    */
    public static void afterInsert(List<Task> taskList){           
        TaskTriggerOperation.taskOnInsert(taskList);           
    } 
 }

Operation Controller

public class TaskTriggerOperation{
    /**
    * Method Name : taskOnInsert
    * Parameter   : 
    * Return type : None
    * Description : This method is used to perform operation on before Insert event of TaskTrigger
    */
    public static void taskOnInsert( List<Task> taskList){  
        Set<Id> eventIds = new Set<Id>();
      for (Task  tsk : taskList) {
       if(tsk.WhatId != null ) { 
        eventIds.add(tsk.whatId);
System.debug('All Event Ids:' +eventIds);
    } 

}
}
    /*
    * Method Name : recallApproval
    * Parameter   : 
    * Return type : None
    * Description : This method is used to perform recall Approval process on Event record
    */
     public static void recallApproval(Id eventIds)    
    {        

        List<ProcessInstanceWorkitem> piwi = [SELECT Id, ProcessInstanceId, ProcessInstance.TargetObjectId
        FROM ProcessInstanceWorkitem WHERE ProcessInstance.TargetObjectId =: eventIds];
        System.debug('Target Object ID:' +eventIds);
        Approval.ProcessWorkitemRequest req = new Approval.ProcessWorkitemRequest();
        req.setComments('Recalling and unlocking request.');
        req.setAction('Removed');        
        req.setWorkitemId(piwi.get(0).Id);
        req.setNextApproverIds(new Id[] {UserInfo.getUserId()});
        Approval.process(req,false);
    } 
    }

I am kinda new to Apex.Aplogies for the amateurish coding.However the code is not working exactly the way I want.Email is sent to user , task is getting created but record is still locked as the approval process in not recalled.I checked the debug logs and found that the Event Id is getting populated correctly at the end of taskonInsert method but no ID is generated in the debug log for Recall Approval methos.I guess I am not passing the parameters correctly in the Recall Approval method.
Can anyone suggest me what to do and where I am missing out?
Thanks in advance!!

Best Answer

Your code as shown never calls the recallApproval method.

You'll also need to change the recallApproval method to accept a parameter of type Set<Id> instead of just a single Id value and then modify the code within that method to be bulk-safe. i.e. Not using only the first element in the query result list for the work item.

public static void taskOnInsert( List<Task> taskList){  
    Set<Id> eventIds = new Set<Id>();
    for (Task  tsk : taskList) {
        if(tsk.WhatId != null ) { 
            eventIds.add(tsk.whatId);
            System.debug('All Event Ids:' +eventIds);
        } 

    }

    // call the recallApproval method for these eventIds
    recallApproval(eventIds);
}

Related Solutions

[SalesForce] Maximum stack depth reached: 1001

I am confused as to what you are really trying to accomplish with this structure. You don't need to create any logic for the actual order of execution (which, correct me if I am wrong, it appears you are trying to do here). Triggers have a very specific order of execution. It will actually run through your trigger several times to hit before and after logic.

Wouldn't it be much easier to do something like:

trigger OpportunityTrigger on Opportunity (after insert, after update, before delete) {
    if(Trigger.isAfter && Trigger.isInsert){
        OpportunityHandler.createScheduleLines(Trigger.newMap);
    }

    if(Trigger.isAfter && Trigger.isUpdate){
        OpportunityHandler.adjustScheduleLines(Trigger.newMap, Trigger.oldMap);
    }

    if(Trigger.isBefore && Trigger.isDelete){
        OpportunityHandler.removeScheduleLines(Trigger.oldMap);
    }

}

public class OpportunityHandler{

    public static void createScheduleLines(Map<Id, Opportunity> newMap) {
        // logic
    }

    public static void adjustScheduleLines(Map<Id, Opportunity> newMap, Map<Id, Opportunity> oldMap) {
        // logic
    }

    public static void removeScheduleLines(Map<Id, Opportunity> oldMap) {
        // logic
    }

}

Let Salesforce worry about the order they are executed.

[SalesForce] Unit Test is Providing 0% Coverage for Apex Trigger

The trigger code is having lot of redundancy, So I modified it. before posting the modified code few lines of explanation what I changed. you collected account Ids twice and did the condition check twice where once is more enough. I am also made changes to the test class, where Task data is provided which is not required because the trigger has to create it once the necessary conditions are met. I am expecting this trigger should work for you, if there is any errors feel free to post as a comment.

trigger OpportunityAfter on Opportunity (after update){

    Set AccountIDs = new Set();

    for(Opportunity o : trigger.new){
        if(opp.StageName == 'Closed - Lost' && opp.Business_Line__c == 'Workforce' && 
            opp.Survey_Type__c != 'APulse' && trigger.oldMap.get(opp.Id).StageName != opp.StageName){

                AccountIDs.add(o.AccountId);
         }
    }

    Task[] tasksToInsert = new Task[]{};

    for (Account acc : [Select Id, Name, OwnerId from Account where Id IN :AccountIds]){
        for (Opportunity opp : trigger.new){
            if(opp.AccountId == acc.Id){
                Task tas = new Task();
                tas.WhatId=acc.Id;
                tas.OwnerId=opp.OwnerId;
                tas.Subject='Follow-up: ' + opp.name + ' - ' + acc.name;
                tas.ActivityDate=(opp.CloseDate + 180);
                tas.Description='Follow up to see how engagement initiatives are going and if Avatar can help. Refer to lost opportunity: ' + opp.name;
                tasksToInsert.add(tas);                                                         
            }
        }
    }
    if(tasksToInsert != null && !tasksToInsert.isEmpty())
    Database.insert(tasksToInsert);

}

@isTest
public class TestClass {

    static testMethod void myUnitTest() {

    //Set up user
    User u1 = [SELECT Id FROM User WHERE Email='abc@sampleemail.com'];
    test.startTest();  
    //Run As U1
    System.RunAs(u1){

    System.debug('Testing trigger... (single record validation)');

    //NEW Account record
    Account acc = new account();
    acc.Name = 'Test Account';
    acc.Industry = 'Healthcare';

    insert acc;

    //NEW Opportunity record
    Opportunity opp = new Opportunity();
    opp.Name = 'Test Opportunity'; 
    opp.CloseDate = System.today();
    opp.StageName = 'S1 - Investigative';
    opp.Type = 'Repeat Business - Wrkforce HC';
    opp.AccountId = acc.Id;
    opp.Survey_Type__c = 'Product Name';

    insert opp;

    opp.StageName = 'Closed - Lost';
    opp.Reason_Won_Lost__c = 'Relationship';
    opp.Business_Line__c = 'Workforce'  //added this line to meet the if condition while collecting the set of id in the trigger.

    update opp;
   test.stopTest();
    // Here I am expecting the task has been inserted and doing a query for it         and check it in the assert statement.
   Task  testTask=[Select Id, WhatId from Task where WhatId=:acc.Id];
    //Validate single insert
    System.assertEquals(acc.Id, testTask.WhatId);

    }
    }
}

Best Answer

Related Solutions

[SalesForce] Maximum stack depth reached: 1001

[SalesForce] Unit Test is Providing 0% Coverage for Apex Trigger

Related Topic