[SalesForce] Removing Duplicate from map

I have created a map of type

Map<Id, Set<Id>> missingProduct= new Map<Id, Set<Id>>();
Set<Id> prd = new Set<Id>();

However on running the loop and storing the values duplicate map values are been stored without removing the value of the previous map.

for(Product_Objective__c  prdObj :allObjectives ){ 
      prdobject = new Product_Objective__c  ();

      prd.add(prdobject.Product__c);


      missingProduct.put(prdobject.Account__c,prd);

      system.debug('missingProduct'+missingProduct);
}

Map is having the values of the previous set also stored with all value. I am unable to make it null for new key.

 Set<Id> prd = new Set<Id>();

Best Answer

I am guessing that Product_Objective__c is a child of Account and you want a map of AccountIds to a set of Product_Objective__c Ids.

You need to check if the map contains the account id or not, if yes fetch the existing set from the map and then add the new item or create a new set and put in the map.

Problems with your existing code.

for(Product_Objective__c  prdObj :allObjectives ){ 
      prdobject = new Product_Objective__c  (); //new instance

      prd.add(prdobject.Product__c); //so, Product__c will be null anyway.


      missingProduct.put(prdobject.Account__c,prd); //putting the one id Set against the account id.
//you are not nullifying the set here to reuse it next time.
      system.debug('missingProduct'+missingProduct);
}

Rather, make it cleaner.

for(Product_Objective__c  prdObj :allObjectives ){ 

    if(missingProduct.containsKey(prdObj.Account__c))
    {
        missingProduct.get(prdObj.Account__c).add(prdObj.Id);
    }
    else
    {
        missingProduct.put(prdObj.Account__c, new Set<Id>{prdObj.Id});
    }
}
System.debug('missingProduct'+missingProduct);

This should give you a map of Account Ids to a set of Product_Objective__c Ids.

Related Solutions

[SalesForce] How to access values from Map

This code...

map <string, Campaign> ExpenseCampaignMap = 
   new map <string, Campaign>(
     [select Id, UtmCampaign_ID__c 
        from Campaign
        where UtmCampaign_ID__c in :UTMCampaignId]);

Results in your Map being keyed by the Id field not the value of your UtmCampaign_ID__c field value.

So the following code will only work if utmcampaign__c on your Contact object contains an actual Campaign record Id or is a Lookup field to Campaign.

UTMCampaign = ExpenseCampaignMap.get(con.utmcampaign__c);

You need to populate your Map using the UtMCompaign_ID__c not the Id. Unfortunatly this has to be done manually by iterating over the results of the query like so...

List<Campaign> ExpenseCampaignList = 
     [select Id, UtmCampaign_ID__c 
        from Campaign
        where UtmCampaign_ID__c in :UTMCampaignId];
Map<string, Campaign> ExpenseCampaignMap = new map <string, Campaign>();
for(Campaign c : ExpenseCampaignList)
    ExpenseCampaignMap.put(c.UtmCampaign_ID__c, c);

[SalesForce] How to get a Map value inside for loop

Create a new subclass - say QueryServiceResult it would look something like this:

public class QueryServiceResult{
    Map<Id, VEH_Vehicle__c> vehiclesByIdMap {get;set;}
    Map<Id, CST_Carset__c> carsetsByVehicleIdMap {get;set;}

    public QueryServiceResult(){
        vehiclesByIdMap = new Map<Id, VEH_Vehicle__c>();
        carsetsByVehicleIdMap = new Map<Id, CST_Carset__c>();
    }
}

Then, in the your final loop in the getQuerySevice method, change it to:

QueryServiceResult qsr = new QueryServiceResult();

for (String  strVin : mapResponse.keyset() ) {
    VEH_Vehicle__c oVeh = mapResponse.get(strVin) ;
    CST_Carset__c lServices = mCarset.get(oVeh.UnitOrder__r.CarSet__r.id);

    qsr.vehiclesByIdMap.put(oVeh.Id,oVeh);
    qsr.carsetsByVehicleIdMap.put(oVeh.Id,lServices);
} 

return qsr;

(Your will need to change the return type of your method to QueryServiceResult)

Finally, in the outer loop, extract the values like this:

for(Id vehicleId : qsr.vehiclesByIdMap.keyset()) {
    VEH_Vehicle__c vehicle = qsr.vehiclesByIdMap.get(vehicleId);
    CST_Carset__c carSet = qsr.carsetsByVehicleIdMap.get(vehicleId);
}

A word of advice. Name your variables very carefully. Minimize abbreviations. It will make your code easier to read.

Best Answer

Related Solutions

[SalesForce] How to access values from Map

[SalesForce] How to get a Map value inside for loop

Related Topic