[SalesForce] Run before update trigger on after insert

So I have a trigger that I want to run everytime a record is updated and created. However, when I use after insert and before update I get a record is locked error when creating the record.

How can I run this trigger on both record edit and creation?

Better yet, is it possible to update any field "after update" or "after insert"?

trigger CalcBenefit on EA_App__c (before update, after insert) {
//works for update only.  insert throws error because I'm trying to change value
for (EA_App__C ea : Trigger.new){

    EA_App__C oldEA = Trigger.oldMap.get(ea.Id);

    if (ea.X3_Month_Income__c > CalculateBenefit.getMax(integer.valueOf(ea.Family_Size__c))){
        ea.App_Status__c = 'DENIED';            
        ea.Benefit_Amount__c = 0;                 

    }else if (ea.X3_Month_Income__c <= CalculateBenefit.getMin(integer.valueOf(ea.Family_Size__c)) && ea.App_Status__c != 'PAID'){
        //how to compare to old? 
        //&& (ea.X3_Month_Income__c != oldEA.X3_Month_Income__c || ea.Family_Size__c != oldEA.Family_Size__c)
        ea.Benefit_Amount__c = 0;                 
        ea.App_Status__c = 'SENT FOR APPROVAL';                

    }else{
        ea.App_Status__c = 'PAID';
        ea.Benefit_Amount__c = CalculateBenefit.calc(ea.X3_Month_Income__c, integer.valueOf(ea.Family_Size__c), ea.Fuel_Cost__c, '2015');
    }

}

}

Best Answer

You can use before insert to modify records before they're saved to the database, which should work well enough for your purposes.

You can simply set oldEA to a blank record, which will also satisfy your "changed fields" conditions:

EA_App__C oldEA = Trigger.isInsert? new EA_App__c(): Trigger.oldMap.get(ea.Id);

If it doesn't work, you can also choose to update the records recursively:

if(Trigger.isAfter && Trigger.isInsert) {
    update Trigger.new.deepClone(true);
} else {
    // Before Update Logic
}

Related Solutions

[SalesForce] Need a Update trigger to fire after record insert

Members of Trigger.new are read only in the after cycle.

In order to take action on an record in Trigger.new after insert/update, you need to create a new instance of each sObject record you want to work with and add it to a new list for update purposes.

...assuming after insert trigger on account...
List<Account> accts = new List<Account>();
for (Account a: Trigger.new) {

  if (some condition) {
    ...take action on a...
    Account acctToUpdate = new Account(id=a.Id, ...other updates...);
    accts.add(acctToUpdate);
  }
}

update accts;

The only thing here is if you also do this on update, you will run into a recursive trigger problem, but this is easily remedied by using the recursive trigger pattern found here in this cookbook recipe.

[SalesForce] Update same record in after insert/update in a trigger context

In a Before Trigger, Trigger.new and Trigger.old both contain the same values. However, in a Before Trigger, one can operate on the values in Trigger.new and change their values.

In an After Trigger, Trigger.new will contain the the Id's and field values of any records that have been changed by a DML operation. The values contained in Trigger.new can be compared to Trigger.old in order to determine which records meet the criteria for firing the trigger and need to be operated on. Unlike in a Before Trigger, the values in Trigger.new cannot be changed or edited.

Recursion is frequently handled by setting a boolean static variable to "true" when a trigger initially fires. Upon entry to the trigger, that static variable is tested. If the boolean is "true" when re-entered in the same execution context, then the trigger is exited rather than allowing it to run again. There are a variety of methods for handling recursion and this is probably the most common.

Edit

I think what you're looking for are trigger patterns such the one described by Dan Appleman in his book Advanced Apex Programming for Salesforce and Force.com (Note: sample code available from App Exchange as an unmanaged package), Hari Krishan's Architecture Framework to Handle Triggers or Kevin O'Hara's Trigger Framework among others that exist or have been espoused which you can find through searching that go beyond the Trigger Pattern for Tidy, Streamlined, Bulkified Triggers.

Using a Main Dispatcher class, these approaches take charge of trigger execution, extending it to an enterprise level application that's scalable, can have it's own diagnostics classes and error reporting, utilize common helper classes and much more. One can also control trigger execution order; something that can't be done with triggers that operate independently of one other without some kind of central control for each object or, as is the case with some architures, potentially for related objects as well.

Discussing them in depth is beyond the scope of this forum, but I'll point you to at least a few posts that you may find relevant including: Controlling Trigger Execution, One Trigger Approach: Any Logic in Trigger?, Difficulties with Appleman's Trigger Classes and General trigger bulkification - best practices.

Best Answer

Related Solutions

[SalesForce] Need a Update trigger to fire after record insert

[SalesForce] Update same record in after insert/update in a trigger context

Related Topic