[SalesForce] Self Reference From Trigger error – Recursive Trigger

I have two before Triggers, one on my Project object & the other on Opportunities.

The Project Trigger takes the value from the Project record's field MPM4_BASE__Deadline__c and copies it into the related Opportunity's field Implementation_Revenue__c & the Opportunity trigger copies the updated value from that field into the Opportunity_Imp_Revenue_Com_Date__c field of a record for junction object ProjectxOpp__c which relates Projects to Opportunities.

Lastly, the value from the ProjectxOpp__c's Opportunity_Imp_Revenue_Com_Date__c is rolled up, using a standard rollup field, to the Project record.

When I edit the MPM4_BASE__Deadline__c field on the Project record, it causes an error

execution of BeforeUpdate caused by: System.DmlException: Update failed. SELF_REFERENCE_FROM_TRIGGER, Object (id = a5E7000000008zR) is currently in trigger WE_IMProjCmpltnUp, therefore it cannot recursively update itself: [] Trigger.WE_ProjxOppUp: line 61, column 1: []: Trigger.WE_IMProjCmpltnUp: line 55, column 1.

Line 61 for Trigger WE_ProjxOppUp is update juncRecs; & line 55 for Trigger WE_IMProjCmpltnUp is update updOpps;.

I've seen several, posts about the error & the knowledge article but none seem to explain the cause of my error. Can anyone see a potential cause?

trigger WE_IMProjCmpltnUp on MPM4_BASE__Milestone1_Project__c (before insert, before update) {


//section of code removed, creates validRecordTypeIds list

    Set<Id> projects = new Set<Id>();
    Map<Id,Date> deadlineDates = new Map<Id,Date>();
    List<Opportunity> updOpps = new List<Opportunity>();

    If(Trigger.isInsert){
        for(MPM4_BASE__Milestone1_Project__c p : Trigger.new){
            if(validRecordTypeIds.contains(p.RecordTypeId) && p.MPM4_BASE__Deadline__c != null)
            {
                projects.add(p.Id);
                deadlineDates.put(p.Id, p.MPM4_BASE__Deadline__c);
            }
        }
    }

    If(Trigger.isUpdate){
                for(MPM4_BASE__Milestone1_Project__c p : Trigger.new){
                    if(validRecordTypeIds.contains(p.RecordTypeId) && p.MPM4_BASE__Deadline__c != null)
                    {
                        MPM4_BASE__Milestone1_Project__c oldP = Trigger.oldMap.get(p.Id);

                        if(oldP.MPM4_BASE__Deadline__c != p.MPM4_BASE__Deadline__c){
                            projects.add(p.Id);
                            deadlineDates.put(p.Id, p.MPM4_BASE__Deadline__c);
                        }
                    }
                }
    }

    if(projects.size() > 0){

        for(ProjectxOpp__c junc : [SELECT Project__c, Opportunity__r.Implementation_Revenue__c FROM ProjectxOpp__c
                                    WHERE Project__c In :projects])
        {
            Opportunity o = junc.Opportunity__r;
            Date newCompDate =  deadlineDates.get(junc.Project__c);
            if(newCompDate > o.Implementation_Revenue__c){
                o.Implementation_Revenue__c = newCompDate;
            }
            updOpps.add(o);
        }
        update updOpps;
    }
}

trigger WE_ProjxOppUp on Opportunity (before update) {

//section of code removed, creates validRecordTypeIds list

    Set<Id> opps = new Set<Id>();
    Map<Id,Date> oppCls = new Map<Id,Date>();
    Map<Id,Decimal> oppNetFSR = new Map<Id,Decimal>();
    Map<Id,Date> oppImpCom = new Map<Id,Date>();
    List<ProjectxOpp__c> juncRecs = new List<ProjectxOpp__c>();

    for(Opportunity o : Trigger.New){
        if(validRecordTypeIds.contains(o.RecordTypeId)){
            Opportunity oldO = Trigger.oldMap.get(o.Id);

            if(oldO.CloseDate != o.CloseDate){
                opps.add(o.Id);
                oppCls.put(o.Id, o.CloseDate);
            }
            if(oldO.Net_Full_Service_Revenue__c != o.Net_Full_Service_Revenue__c){
                opps.add(o.Id);
                oppNetFSR.put(o.Id, o.Net_Full_Service_Revenue__c);
            }               
             if(oldO.Implementation_Revenue__c != o.Implementation_Revenue__c){
                 opps.add(o.Id);
                 oppImpCom.put(o.Id, o.Implementation_Revenue__c);
             }
        }
    }

    if(opps.size() > 0){

        for(ProjectxOpp__c junc : [SELECT Opportunity__c, Opportunity_Net_FSR__c, Opportunity_Close_Date__c, Opportunity_Imp_Revenue_Com_Date__c FROM ProjectxOpp__c
                                    WHERE Opportunity__c IN :opps])
        {
            Date clsDt = oppCls.get(junc.Opportunity__c);
            if(clsDt != null){
                junc.Opportunity_Close_Date__c = clsDt;
            }
            Decimal netFSR = oppNetFSR.get(junc.Opportunity__c);
            if(clsDt != null){
                junc.Opportunity_Net_FSR__c = netFSR;
            }
            Date impRevComDt = oppImpCom.get(junc.Opportunity__c);
            if(impRevComDt != null){
                junc.Opportunity_Imp_Revenue_Com_Date__c = impRevComDt;
            }
            juncRecs.add(junc);
        }
        update juncRecs;
    }
}

Best Answer

The cause of the issue was my Project roll-up fields, which were rolling up values from the ProjxOpp junction object and would have caused the triggers on the Project to execute again.

But interestingly, in this instance Salesforce seems to have been anticipating the roll-ups causing the second Project save procedure because the Project triggers didn't appear in my my debug logs a second time, before the error occurred.

Since my WE_IMProjCmpltnUp Trigger isn't updating the Projectobject, I was able to change it's execution to after insert, after update and this prevents the error from occurring.
This is because you can't update a record from within it's Before trigger, even though the roll-up actually causes the recalculation in the After context.
Again, it looks like this is Salesforce anticipating the change but not taking into account the context, when that change will be made.

Note - it wasn't necessary to also change the WE_ProjxOppUp Trigger to after update & doing that but not changing WE_IMProjCmpltnUp does not solve the issue.

Applying the solution from the Salesforce Knowledge Article on this topic - How to avoid Recursive trigger - which also seems to have been proposed in this answer didn't solve my issue.

Related Solutions

[SalesForce] Lead Conversion Trigger Order of Execution

The usual order of execution detailed at http://www.salesforce.com/us/developer/docs/apexcode/Content/apex_triggers_order_of_execution.htm still applies with some special considerations

The Before triggers and validation rules do not fire unless that checkbox is ticked under Customise > Lead > Settings. Note that for orgs created prior to '08 you'll need to contact support to enable this (related answer)

After triggers still always fire irrespective of the above setting

To check if a Lead has been converted and do custom lead conversion logic, the best home for such is the LeadAfter trigger, where you can check

If (trigger.isUpdate && Lead.IsConverted && !trigger.oldmap.get(lead.id).IsConverted)
//do your stuff

Here you will have access to the convertedAccountId, convertedContactId, ConvertedOpportunityId and any OpportunityContactRoles

This is also a good place to re parent any custom related list records from the converted Lead to either of Company or Contact

Just added some debug logs to triggers, and here's the order of execution : (This is with the Enforce Validations and Triggers on Lead Conversion Enabled)

Account Custom Field Mappings
Account Before                 (Fires based on lead settings)
Account After
Contact Custom Field Mappings
Contact Before                 (Fires based on lead settings)
Contact After
Opportunity Field Mappings
Opportunity Before             (Fires based on lead settings)
Opportunity After              (OCR's not available)
Lead Before
Lead After                     (OCR's available)

If the Enforce Validations and Triggers setting is turned off, none of the Before triggers fire. The After triggers however still fire.

[SalesForce] Unit Test is Providing 0% Coverage for Apex Trigger

The trigger code is having lot of redundancy, So I modified it. before posting the modified code few lines of explanation what I changed. you collected account Ids twice and did the condition check twice where once is more enough. I am also made changes to the test class, where Task data is provided which is not required because the trigger has to create it once the necessary conditions are met. I am expecting this trigger should work for you, if there is any errors feel free to post as a comment.

trigger OpportunityAfter on Opportunity (after update){

    Set AccountIDs = new Set();

    for(Opportunity o : trigger.new){
        if(opp.StageName == 'Closed - Lost' && opp.Business_Line__c == 'Workforce' && 
            opp.Survey_Type__c != 'APulse' && trigger.oldMap.get(opp.Id).StageName != opp.StageName){

                AccountIDs.add(o.AccountId);
         }
    }

    Task[] tasksToInsert = new Task[]{};

    for (Account acc : [Select Id, Name, OwnerId from Account where Id IN :AccountIds]){
        for (Opportunity opp : trigger.new){
            if(opp.AccountId == acc.Id){
                Task tas = new Task();
                tas.WhatId=acc.Id;
                tas.OwnerId=opp.OwnerId;
                tas.Subject='Follow-up: ' + opp.name + ' - ' + acc.name;
                tas.ActivityDate=(opp.CloseDate + 180);
                tas.Description='Follow up to see how engagement initiatives are going and if Avatar can help. Refer to lost opportunity: ' + opp.name;
                tasksToInsert.add(tas);                                                         
            }
        }
    }
    if(tasksToInsert != null && !tasksToInsert.isEmpty())
    Database.insert(tasksToInsert);

}

@isTest
public class TestClass {

    static testMethod void myUnitTest() {

    //Set up user
    User u1 = [SELECT Id FROM User WHERE Email='abc@sampleemail.com'];
    test.startTest();  
    //Run As U1
    System.RunAs(u1){

    System.debug('Testing trigger... (single record validation)');

    //NEW Account record
    Account acc = new account();
    acc.Name = 'Test Account';
    acc.Industry = 'Healthcare';

    insert acc;

    //NEW Opportunity record
    Opportunity opp = new Opportunity();
    opp.Name = 'Test Opportunity'; 
    opp.CloseDate = System.today();
    opp.StageName = 'S1 - Investigative';
    opp.Type = 'Repeat Business - Wrkforce HC';
    opp.AccountId = acc.Id;
    opp.Survey_Type__c = 'Product Name';

    insert opp;

    opp.StageName = 'Closed - Lost';
    opp.Reason_Won_Lost__c = 'Relationship';
    opp.Business_Line__c = 'Workforce'  //added this line to meet the if condition while collecting the set of id in the trigger.

    update opp;
   test.stopTest();
    // Here I am expecting the task has been inserted and doing a query for it         and check it in the assert statement.
   Task  testTask=[Select Id, WhatId from Task where WhatId=:acc.Id];
    //Validate single insert
    System.assertEquals(acc.Id, testTask.WhatId);

    }
    }
}

Best Answer

Related Solutions

[SalesForce] Lead Conversion Trigger Order of Execution

[SalesForce] Unit Test is Providing 0% Coverage for Apex Trigger

Related Topic