[SalesForce] SOQL SORTING WITH 2 FIELDS

Sorting on picklist fields is a bit of a special case. Typically

"picklist sorting is defined by the picklist sort determined during setup." - ORDER BY Docs

You can refine this using the Reorder button on the picklist field.

However, NULLS LAST doesn't appear to be respected on picklists. See (and upvote) - Implement SOQL Order By NULLS LAST. It appears to be a long standing issue.

One possible workaround would be to create a text field that you populate with a workflow rule and field update. This would allow you to sort alphabetically and should respect null values. Note that you could get into issues with this if you multiple languages/translations (which I think is why picklists have sort orders).

Another thing to watch out for could be what are called "inactive picklist values". This is where you have assigned a value to the picklist that isn't in the current list of allowed values. These should appear after the defined values in sorting.

Java has multiple map classes such as LinkedHashMap that preserve insertion order but Apex only has one map type which does not. So in Apex a work-around is to keep a separate list of the keys as lists preserve insertion order and get the keys to iterate through from the list:

private Map<string, groupingWrapClass> map_lineitems_Group
        = new Map<string, groupingWrapClass>();
private List<String> ordered_keys = new List<String>();

private void addToMap(String key, groupingWrapClass grouping) {
    map_lineitems_Group.put(key, grouping);
    ordered_keys.add(key);
}

private void xyz() {
    ...
    addToMap('XYZ', keyvalues);
    addToMap('ABC', keyvalues);
    ...
    // Run through the map keys in insertion order
    for (String key : ordered_keys) {
        groupingWrapClass grouping = map_lineitems_Group.get(key);
        ...
    }
}

PS

On exposing this to Visualforce, make both ordered_keys and map_lineitems_Group visible (add getters or make properties) and then e.g.:

<apex:pageBlockTable value="{!ordered_keys}" var="ordered_key">
<apex:column headerValue="Year Name" value="{!map_lineitems_Group[ordered_key].yearname}"/>
...
</apex:pageBlockTable>

as expressions in Visualforce use [] for map access.

You could also add an apex:variable to factor out the common map_lineitems_Group[ordered_key] expression.