[SalesForce] System.FinalException: SObject row does not allow errors

Can someone point me in the direction of not getting the error

OpportunityTrigger: execution of AfterUpdate caused by: System.FinalException: SObject row does not allow errors: Trigger.OpportunityTrigger: line 34, column 1

trigger OpportunityTrigger on Opportunity (after delete, after insert, after undelete, after update, before delete, before insert, before update) {
    try {
        map<Id, Opportunity> sendVOCS = new map<Id, Opportunity>();
        map<id, Opportunity> stageChanged = new map<Id, Opportunity>();

        if (trigger.isAfter) {
            system.debug('OpportunityTrigger isAfter');
            if (trigger.isUpdate) {
                system.debug('OpportunityTrigger isAfter isUpdate');
                for (Opportunity record : trigger.newMap.Values()) {
                    Opportunity oldMapMatch = trigger.oldMap.get(record.Id);
                    if (record.StageName != oldMapMatch.StageName) {
                        // Voice of Customer Survey criteria
                        if (record.StageName == 'Closed - Awarded' || record.StageName == 'Closed - Lost') {
                            sendVOCS.put(record.Id, record);
                        }
                        // add newMap opportunity to a id/opp map
                        stageChanged.put(record.Id, record);
                    }
                }
                // send voice of customer surveys if they should be - criteria is above
                if (sendVOCS.keySet().Size() > 0) {
                    SendMail sendMail = new SendMail();
                    sendMail.SendVoiceOfCustomerSurvey(sendVOCS);
                    system.debug('Send Voice of Customer Surveys');
                }
                if (stageChanged.keySet().Size() > 0) {
                    StatusAndStageLogging statusAndStageLogging = new StatusAndStageLogging();
                    statusAndStageLogging.logOpportunityStage(stageChanged, trigger.oldMap);
                    system.debug('Log Opportunity Stage');
                }

                for (Opportunity opp : trigger.old){
                    opp.addError ('Opportunities can not be deleted');
                }
            }
        }
    }
    catch (exception e){
        ErrorHandler error = new ErrorHandler();
        error.logError(e);
    }
}

Best Answer

You are getting this error because of this below lines

for (Opportunity opp : trigger.old){ 
    opp.addError ('Opportunities can not be deleted'); 
}

Triggers can be used to prevent DML operations from occurring by calling the addError() method on a record or field. When used on Trigger.new records in insert and update triggers, and on Trigger.old records in delete triggers, the custom error message is displayed in the application interface and logged. More help i.e. Trigger Exceptions on this link.

You cannot use Trigger.Old to addError in After Update context.

You will have to surround that code of yours by checking the condition so that it runs only in before delete context. You will have to remove the above code from Trigger.IsUpdate and Trigger.isAfter condition and add a separate condition.

if(Trigger.IsDelete && Trigger.IsBefore){
    for (Opportunity opp : trigger.old){ 
        opp.addError ('Opportunities can not be deleted'); 
    }
}

It is always a best practice to check in which context your particular code should execute.

Related Solutions

[SalesForce] Unit Test is Providing 0% Coverage for Apex Trigger

The trigger code is having lot of redundancy, So I modified it. before posting the modified code few lines of explanation what I changed. you collected account Ids twice and did the condition check twice where once is more enough. I am also made changes to the test class, where Task data is provided which is not required because the trigger has to create it once the necessary conditions are met. I am expecting this trigger should work for you, if there is any errors feel free to post as a comment.

trigger OpportunityAfter on Opportunity (after update){

    Set AccountIDs = new Set();

    for(Opportunity o : trigger.new){
        if(opp.StageName == 'Closed - Lost' && opp.Business_Line__c == 'Workforce' && 
            opp.Survey_Type__c != 'APulse' && trigger.oldMap.get(opp.Id).StageName != opp.StageName){

                AccountIDs.add(o.AccountId);
         }
    }

    Task[] tasksToInsert = new Task[]{};

    for (Account acc : [Select Id, Name, OwnerId from Account where Id IN :AccountIds]){
        for (Opportunity opp : trigger.new){
            if(opp.AccountId == acc.Id){
                Task tas = new Task();
                tas.WhatId=acc.Id;
                tas.OwnerId=opp.OwnerId;
                tas.Subject='Follow-up: ' + opp.name + ' - ' + acc.name;
                tas.ActivityDate=(opp.CloseDate + 180);
                tas.Description='Follow up to see how engagement initiatives are going and if Avatar can help. Refer to lost opportunity: ' + opp.name;
                tasksToInsert.add(tas);                                                         
            }
        }
    }
    if(tasksToInsert != null && !tasksToInsert.isEmpty())
    Database.insert(tasksToInsert);

}

@isTest
public class TestClass {

    static testMethod void myUnitTest() {

    //Set up user
    User u1 = [SELECT Id FROM User WHERE Email='abc@sampleemail.com'];
    test.startTest();  
    //Run As U1
    System.RunAs(u1){

    System.debug('Testing trigger... (single record validation)');

    //NEW Account record
    Account acc = new account();
    acc.Name = 'Test Account';
    acc.Industry = 'Healthcare';

    insert acc;

    //NEW Opportunity record
    Opportunity opp = new Opportunity();
    opp.Name = 'Test Opportunity'; 
    opp.CloseDate = System.today();
    opp.StageName = 'S1 - Investigative';
    opp.Type = 'Repeat Business - Wrkforce HC';
    opp.AccountId = acc.Id;
    opp.Survey_Type__c = 'Product Name';

    insert opp;

    opp.StageName = 'Closed - Lost';
    opp.Reason_Won_Lost__c = 'Relationship';
    opp.Business_Line__c = 'Workforce'  //added this line to meet the if condition while collecting the set of id in the trigger.

    update opp;
   test.stopTest();
    // Here I am expecting the task has been inserted and doing a query for it         and check it in the assert statement.
   Task  testTask=[Select Id, WhatId from Task where WhatId=:acc.Id];
    //Validate single insert
    System.assertEquals(acc.Id, testTask.WhatId);

    }
    }
}

[SalesForce] SObject row does not allow errors in Salesforce before trigger

This error arises when you try to call addError in a trigger but call it on a record that is not in the trigger collection, which is exactly what you are doing. You can only validate records that are being acted on.

Best Answer

Related Solutions

[SalesForce] Unit Test is Providing 0% Coverage for Apex Trigger

[SalesForce] SObject row does not allow errors in Salesforce before trigger

Related Topic