[SalesForce] System.LimitException: Too many DML rows: 10001

A user is trying to update some records in Salesforce, he is getting this error:

OrderHistory: System.LimitException: Too many DML rows: 10001.

He added that he is not able to insert 100 records at a time in Salesforce.
I checked OrderHistory Apex Trigger code, took the SOQL query out of the for loop (that may be causing the governor limit hit), still no luck.
Please can someone suggest how can i get rid off this error?

Best Answer

Your error doesn't have to do with a SOQL query in a for loop (although you really don't want that either). Your error has to do with too many records being inserted or updated at once. It sounds like the trigger has not been properly bulkified. If you have a trigger that is trying to update that many rows, you should really look into turning it into batch apex.

Related Solutions

[SalesForce] How does salesforce calculate DML rows? What is included to DML Rows Count

The DML rows are counted against one transaction not per DML statement for example below code will work as myList.add( new Account(name='xyz') ); is commented. if you uncomment the statement then it will hit Too many DML rows limit. Somewhere in your code there is more than 4 DML exists apart from the code shown which makes a total more than 10000 to make the code fail

List<Account> myList = new List<Account>();
   // myList.add( new Account(name='xyz') );
   // myList.add( new Account(name='xyz') );
   // myList.add( new Account(name='xyz') );
   // myList.add( new Account(name='xyz') );
   // myList.add( new Account(name='xyz') );

for ( Integer i = 0; i < 9996; i++) {
    myList.add( new Account(name='xyz') );
}

System.debug( 'myList.size() : ' + myList.size() ); // => here I see in debug myList.size() : 9996

insert myList;

[SalesForce] AddAccountTeamMember : System.LimitException: Too many DML rows: 10001

This issue is most likely caused from your nested for loops, shown below. This pattern will cause the number of records in the las List to grow exponentially as the amount of Accounts, Users and Custom settings grow.

for(Account acc : newList){
    for(CustomSettings__c s : CustomSettings__c.getAll().values()){
        for(User u : usr){
            ...
            AccountShare  nas = new AccountShare();
            ...
            las.add(nas);

For example, if you inserted 20 Accounts, had 25 Custom Settings and 30 Users then you would end up trying to insert 15,000 (20 x 25 x 30) AccountShare records. Add some debugging on las and latm to see how the size of them grow.

If you truly need to create that many sharing objects then you may need to consider doing it using Apex Batch instead.

Best Answer

Related Solutions

[SalesForce] How does salesforce calculate DML rows? What is included to DML Rows Count

[SalesForce] AddAccountTeamMember : System.LimitException: Too many DML rows: 10001

Related Topic