[SalesForce] System.LimitException: Too many query rows: 50001

What I am trying to do is to set a date in my date field and also update the object. I am using the class below to do so which works just fine in my sanbox but in production I am getting this error:

System.LimitException: Too many query rows: 50001

public with sharing class updateObject{
    public  List<NRProducts__c>  values;
    public PageReference updateObject() {
        values=[SELECT Refreshed_Date__c FROM NRProducts__c ];
        for (NRProducts__c s :values){
           s.Refreshed_Date__c =Date.today();
         } 
        update values;
        return null;                  
    }    
}

VF Page:

<apex:page showheader="false" controller="updateObject" sidebar="false">
<apex:form> 
<apex:commandButton action="{!updateObject}" value="Update"/>
</apex:form>
</apex:page>

Best Answer

You're running into this on production, because you have much more data there than in your sandbox. This is a limit which is a bit harder to test against and discover in advance. You'd do well to integrate it into your salesforce developer conscious.

total number of records retrieved by SOQL queries = 50,000

You will need to use Batch Apex, in which the 50k limit counts per batch execution

These limits count for each Apex transaction. For Batch Apex, these limits are reset for each execution of a batch of records in the execute method.

This is clearly stated in the limit documentation. Salesforce enforces these rules to "force" us to use scaleable and resource friendly implementation patterns.

Related Solutions

[SalesForce] Getting record count through WebService bypassing LIMITS

There is a way to do it, but it isn't pretty. You can have your Apex call the REST API and then parse the JSON to get the count. This works in my org with 1.5 million cases.

@RestResource(urlMapping='/count/*')
global with sharing class GetCount{
    @HttpGet
        global static Integer doCount() {
            RestRequest restreq = RestContext.request;        
            String objName = restreq.requestURI.split('/')[2];

            HttpRequest req = new HttpRequest(); 
            req.setMethod('GET');
            req.setEndpoint('https://na12.salesforce.com/services/data/v30.0/query/?q=SELECT+COUNT(Id)+FROM+' + objName);
            req.setHeader('Authorization', 'Bearer '+ UserInfo.getSessionId());
            req.setTimeout(60000);        
            Http http = new Http();
            HTTPResponse res = http.send(req);

            Map<String, Object> response = (Map<String, Object>) JSON.deserializeUntyped(res.getBody());
            List<Object> records = (List<Object>) response.get('records');
            return (Integer) ((Map<String, Object>) records[0]).get('expr0');
        }

    }

To use this you have to add your org in the remote site settings. You also shouldn't hard code the org instance in the class.

[SalesForce] System.LimitException: Too many query rows: 50001 but only have 32000 rows

The problem is that your first query returns 32,000 rows and your second query is actually including over 32,000 rows in the aggregation.

The first query is limiting the Opportunity results by the Account.BillingState which is returning the 32,000 rows. The second query is including ALL Opportunities since there is no WHERE clause. Even if you included the same WHERE clause as the first query, it would still be over the limit of 50,000 (total would be 64,000 rows).

You need to make sure you are being more selective in your queries and filtering to just the records you need. If you cannot make it more selective, consider asynchronous apex.

See documentation here: https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/langCon_apex_SOQL_agg_fns.htm

Queries that include aggregate functions are subject to the same governor limits as other SOQL queries for the total number of records returned. This limit includes any records included in the aggregation, not just the number of rows returned by the query. If you encounter this limit, you should add a condition to the WHERE clause to reduce the amount of records processed by the query.

Best Answer

Related Solutions

[SalesForce] Getting record count through WebService bypassing LIMITS

[SalesForce] System.LimitException: Too many query rows: 50001 but only have 32000 rows

Related Topic