[SalesForce] test class is not covering email messaging

trigger:

trigger TaskCompletion on Task (after insert,after update){ 
   IF(trigger.isinsert){
   for (Task E : Trigger.new){ 
         If((E.CreatedById != E.OwnerId)&&(E.Notification_on_Completion__c !=false)){
                User U= [select id,Email,Name from user where id =:E.CreatedById ];
                User U1= [select id,Email,Name from user where id =:E.OwnerId];
                Task EE = [Select What.Name,Who.Name from task where id = :E.Id]; 
                Messaging.SingleEmailMessage mail = new Messaging.SingleEmailMessage();
                String[] toAddresses = new String[] {U.Email};  
                mail.setToAddresses(toAddresses);                   
                mail.setSubject('Status of the Task' );                 
                mail.setPlainTextBody('Hi'+' '+U.Name +',' + '\n\n ' +'The task assigned to'+' '+U1.Name+' '+'is'+' '+E.Status+'.' 
                +'Details are below.'+'\n\n'+'Subject :'+' '+E.Subject+'\n'+'Comments :'+' '+E.Description+'\n'+'Related To :'+' '+EE.What.Name+'\n'+'Name :'+' '+
                EE.Who.Name+'\n'+'URL Link : https://ap1.salesforce.com/'+ E.Id +'\n\n'+'Regards,'+'\n'+'Admin.' );
                Messaging.sendEmail(new Messaging.SingleEmailMessage[] { mail }); 
        }

     }}
     IF(trigger.isupdate){
   for (Task E : Trigger.new){ 
         If((E.CreatedById != E.OwnerId)&&(E.Notification_on_Completion__c !=false)&&(trigger.oldmap.get(E.id).status!=trigger.newmap.get(E.id).status)){
                User U= [select id,Email,Name from user where id =:E.CreatedById ];
                User U1= [select id,Email,Name from user where id =:E.OwnerId];
                Task EE = [Select What.Name,Who.Name from task where id = :E.Id]; 
                Messaging.SingleEmailMessage mail = new Messaging.SingleEmailMessage();
                String[] toAddresses = new String[] {U.Email};  
                mail.setToAddresses(toAddresses);                   
                mail.setSubject('Status of the Task' );                 
                mail.setPlainTextBody('Hi'+' '+U.Name +',' + '\n\n ' +'The task assigned to'+' '+U1.Name+' '+'is'+' '+E.Status+'.' 
                +'Details are below.'+'\n\n'+'Subject :'+' '+E.Subject+'\n'+'Comments :'+' '+E.Description+'\n'+'Related To :'+' '+EE.What.Name+'\n'+'Name :'+' '+
                EE.Who.Name+'\n'+'URL Link : https://ap1.salesforce.com/'+ E.Id +'\n\n'+'Regards,'+'\n'+'Admin.' );
                Messaging.sendEmail(new Messaging.SingleEmailMessage[] { mail }); 
        }

     }}
}

test case:

@IsTest
private class TestTaskCompletion{
     static testmethod void TestTaskCompletion (){    
           Profile pf = [Select Id from Profile where Name = 'Standard User_1'];
             User u = new User();
                //u.FirstName = 'Test';
                u.LastName = 'Nicomatic2';
                u.Email = 'test@gmail.com.sandbox';
                u.CompanyName = 'test.com';
                u.Title = 'Test User';
                u.Username = 'test@gmail.com.sandbox';
                u.Alias = 'ni';
                u.CommunityNickname = 'ni';
                u.TimeZoneSidKey = 'America/Mexico_City';
                u.LocaleSidKey = 'en_US';
                u.EmailEncodingKey = 'ISO-8859-1';
                u.ProfileId = pf.Id;
                u.LanguageLocaleKey = 'en_US';       
                insert u;

           User u1 = new User();
                //u.FirstName = 'Test';
                u1.LastName = 'Nicomatic22';
                u1.Email = 'test1@gmail.com.sandbox';
                u1.CompanyName = 'tes1t.com';
                u1.Title = 'Test User1';
                u1.Username = 'test1@gmail.com.sandbox';
                u1.Alias = 'ni1';
                u1.CommunityNickname = 'ni1';
                u1.TimeZoneSidKey = 'America/Mexico_City';
                u1.LocaleSidKey = 'en_US';
                u1.EmailEncodingKey = 'ISO-8859-1';
                u1.ProfileId = pf.Id;
                u1.LanguageLocaleKey = 'en_US';       
                insert u1;

            System.runAs(u){
             Task t = New Task(Subject='test',Priority='Normal',Status='Completed',Notification_on_Completion__c=true);
                  Insert t;
             Task tt =[select id,CreatedById,OwnerId from task where Id =:t.Id];
             Task t1 = New Task(Subject='test',Priority='Normal',Status='Not started' );
                t1.OwnerId = u.Id;
               insert t1;

          }
         system.runas(u1){
                       Task t1 = New Task(Subject='test',Priority='Normal',Status='Not started' );
                t1.OwnerId = u1.Id;
               insert t1;
           t1.status='Need identified' ;
              update t1;
              system.assertequals(t1.status,'Need identified')  ;  
               emailmessage em = new emailmessage();
                em.fromaddress = 'Test@test.com';
                em.toaddress = 'test1@test.com';
                em.subject = 'Test Email';
                em.textbody = 'testing';
                em.parentid = t1.id;
                test.starttest();
                insert em;
                test.stoptest();  
          }
     }
}

I am not getting code coverage for messaging

 Messaging.SingleEmailMessage mail = new Messaging.SingleEmailMessage();
                    String[] toAddresses = new String[] {U.Email};  
                    mail.setToAddresses(toAddresses);                   
                    mail.setSubject('Status of the Task' );                 
                    mail.setPlainTextBody('Hi'+' '+U.Name +',' + '\n\n ' +'The task assigned to'+' '+U1.Name+' '+'is'+' '+E.Status+'.' 
                    +'Details are below.'+'\n\n'+'Subject :'+' '+E.Subject+'\n'+'Comments :'+' '+E.Description+'\n'+'Related To :'+' '+EE.What.Name+'\n'+'Name :'+' '+
                    EE.Who.Name+'\n'+'URL Link : https://ap1.salesforce.com/'+ E.Id +'\n\n'+'Regards,'+'\n'+'Admin.' );
                    Messaging.sendEmail(new Messaging.SingleEmailMessage[] { mail });

Help me to get the 100% code coverage

Thanks in advance

Best Answer

It is hard to tell but it appears that most of the code is duplicated between the insert and update cases. One solution to that would be to move most of the code out to a separate class, but in this case this sort of refactoring might be appropriate:

trigger TaskCompletion on Task (after insert, after update) {
    // Do all queries on User here based on sets of IDs obtained from Trigger.new
    Messaging.SingleEmailMessage[] emails = new Messaging.SingleEmailMessage[] {};
    for (Task t : Trigger.new) {
        if (t.CreatedById != t.OwnerId && !t.Notification_on_Completion__c) {
            // On insert or status change only
            if(Trigger.isInsert || E.Status != Trigger.oldMap.get(t.Id).Status) {
                // Add email to emails
            }
        }
    }
    Messaging.sendEmail(emails);
}

A problem with the test is that you are not changing the owner (in both cases):

system.runas(u1) {
    // Makes the owner u1 (the runAs User)
    Task t1 = New Task(Subject='test',Priority='Normal',Status='Not started');
    // Instead of u1.Id this should be u.Id...
    t1.OwnerId = u1.Id;
    t1.status='Need identified' ;
    update t1;

A final point is that as emails are not sent in tests asserting what has happened is awkward; one way around that is to create a class that the trigger uses to send:

public class Emails {
    @TestVisible
    private Messaging.SingleEmailMessage[] sent; 
    public void sendEmail(Messaging.SingleEmailMessage[] emails) {
        Messaging.sendEmail(emails);
        sent = emails;
    }
}

and the test can assert about the Emails.sent content.

Related Solutions

[SalesForce] Owner is null after insert – Test class

salesforce known bug :

None of the owner fields are accessible in a test class

https://success.salesforce.com/issues_view?id=a1p30000000SwHDAA0

Interesting fact 1: when you use myobject.ownerid assertion passed but when you do myobject.owner.id assertion fails

System.AssertException: Assertion Failed: Expected: 005d0000001U4iVAAS, Actual: null

Interesting fact 2: field name typo in the bug heading :P

While Using SeeAllData=false, owner filed not visible in SOQL on Custom Objects

[SalesForce] Unit Test is Providing 0% Coverage for Apex Trigger

The trigger code is having lot of redundancy, So I modified it. before posting the modified code few lines of explanation what I changed. you collected account Ids twice and did the condition check twice where once is more enough. I am also made changes to the test class, where Task data is provided which is not required because the trigger has to create it once the necessary conditions are met. I am expecting this trigger should work for you, if there is any errors feel free to post as a comment.

trigger OpportunityAfter on Opportunity (after update){

    Set AccountIDs = new Set();

    for(Opportunity o : trigger.new){
        if(opp.StageName == 'Closed - Lost' && opp.Business_Line__c == 'Workforce' && 
            opp.Survey_Type__c != 'APulse' && trigger.oldMap.get(opp.Id).StageName != opp.StageName){

                AccountIDs.add(o.AccountId);
         }
    }

    Task[] tasksToInsert = new Task[]{};

    for (Account acc : [Select Id, Name, OwnerId from Account where Id IN :AccountIds]){
        for (Opportunity opp : trigger.new){
            if(opp.AccountId == acc.Id){
                Task tas = new Task();
                tas.WhatId=acc.Id;
                tas.OwnerId=opp.OwnerId;
                tas.Subject='Follow-up: ' + opp.name + ' - ' + acc.name;
                tas.ActivityDate=(opp.CloseDate + 180);
                tas.Description='Follow up to see how engagement initiatives are going and if Avatar can help. Refer to lost opportunity: ' + opp.name;
                tasksToInsert.add(tas);                                                         
            }
        }
    }
    if(tasksToInsert != null && !tasksToInsert.isEmpty())
    Database.insert(tasksToInsert);

}

@isTest
public class TestClass {

    static testMethod void myUnitTest() {

    //Set up user
    User u1 = [SELECT Id FROM User WHERE Email='abc@sampleemail.com'];
    test.startTest();  
    //Run As U1
    System.RunAs(u1){

    System.debug('Testing trigger... (single record validation)');

    //NEW Account record
    Account acc = new account();
    acc.Name = 'Test Account';
    acc.Industry = 'Healthcare';

    insert acc;

    //NEW Opportunity record
    Opportunity opp = new Opportunity();
    opp.Name = 'Test Opportunity'; 
    opp.CloseDate = System.today();
    opp.StageName = 'S1 - Investigative';
    opp.Type = 'Repeat Business - Wrkforce HC';
    opp.AccountId = acc.Id;
    opp.Survey_Type__c = 'Product Name';

    insert opp;

    opp.StageName = 'Closed - Lost';
    opp.Reason_Won_Lost__c = 'Relationship';
    opp.Business_Line__c = 'Workforce'  //added this line to meet the if condition while collecting the set of id in the trigger.

    update opp;
   test.stopTest();
    // Here I am expecting the task has been inserted and doing a query for it         and check it in the assert statement.
   Task  testTask=[Select Id, WhatId from Task where WhatId=:acc.Id];
    //Validate single insert
    System.assertEquals(acc.Id, testTask.WhatId);

    }
    }
}

Best Answer

Related Solutions

[SalesForce] Owner is null after insert – Test class

[SalesForce] Unit Test is Providing 0% Coverage for Apex Trigger

Related Topic