[SalesForce] Too many SOQL queries: 101 issue with Unit Test Methods

We are facing couple of issue with Unit Test methods.

SOQL queries limit hits before "Test.StartTest()". We want to test a batch process and it needs to creates records for around 8 to 10 objects which has triggers. Because of that it is throwing limit exception before "Test.StartTest()".

Below is example of code.

@isTest
private class Test_Trigger_Contact
 {
     static testMethod void test1() 
     {        
       Student__c  studentToAdd; 
       List<Contact> contacts= new List<Contact>();  

      // To create Test data we are creating some test records of around 8-10 objects.
      // Internally it fires trigger and consumes diffrent SOQL queries, which cross 101 SOQL limit.
      // Because of this our test class fails before "Test.StartTest()"/"Test.StopTest()".
       for(integer i=0;i<101;i++)
         {
               contacts= [SELECT Id,Name FROM   Contact];

         }        
       test.startTest();
      // Do Some Unit Test for a batch process
      test.stopTest();
     }
 }

Another problem is, Salesforce is not resetting the Governor limit inside "Test.StartTest()" and "Test.StopTest()". Which is mentioned on below Salesforce issue.

https://success.salesforce.com/issues_view?id=a1p30000000T5R5AAK

With below example, you can reproduce this issue :

 @isTest
 private class Test_Trigger_Contact
 {
     static testMethod void test1() 
     {        
       Student__c  studentToAdd; 
       List<Contact> contacts= new List<Contact>();  

      // Below code is consuming 98 queries to generate Test Data
       for(integer i=0;i<98;i++)
         {
               contacts= [SELECT Id,Name FROM   Contact];

         }   
      // After that we are using "test.startTest()", to reset governer imit.
      // But it doesn't and throws 101 SOQL query error.
       test.startTest();
      // Do Some Unit Test for a batch process
       for(integer i=0;i<3;i++)
       {
               contacts= [SELECT Id,Name FROM   Contact];

         }  
      test.stopTest();
     }
 }

2nd issue will be fixed with Salesforce release as mentioned on above link.

I am not sure how can we fix 1st issue. Where we need to generate large data to test Batch Process. My understanding was, Salesforce calculates governor limits only inside "Test.startTest()" and "Test.stopTest()" for unit Test method and it doesn't calculates it while generating test data. Can someone please confirm my understanding regarding?

Thanks and Regards,
Ashish Shukla

Best Answer

By using the Test.startTest() & Test.stopTest() you get 2X governer limits.

In nutshell you have 2 context.

out side of Test.startTest() & Test.stopTest() and
inside of Test.startTest() & Test.stopTest().

In both context you get separate limits.

To fix this issue what you will have to do is:

Optimize and see if you can reduce the queries in trigger
Reduce the number of objects you are inserting
You can skip unnecessary trigger execution by checking if trigger being called by Test method if(Test.isRunningTest())
in worst case you can use SeeAllData = ture

Related Solutions

[SalesForce] Too many SOQL queries: 101 – Test Class w. no queries / DML inside loops

The reason for your limit exception is probably that you're trying to do to many operations in one transaction.

You need to know that all governor limits are counted against one transaction. Transaction is not one class execution - it is the whole stack of calls.

Example:

You insert opportunity // Transaction begins
beforeInsert trigger is executed (let's say it has 1 SOQL query inside - limit of soql for transaction equals 1 right now)
afterInsert trigger is executed (let's say it has 2 SQOL and update of related record - Account)
account beforeInsert is executed...
account afterInsert
End of transaction (success if no error, and governor limits are not exceeded)

So if you have your test class - in one method you're making multiple inserts - it's all counted as one transaction.

Best practice for test class development is to separate it to multiple methods - each testing one thing. This way each test method is executed separately and have separate governor limits. Also good practice is to include method with @testSetup method when you will insert all records required for other test methods.

@isTest
public class WE_OppUpdatesTest {

   @testSetup
   static void dataSetup() {
      ...
      insert user;
   }

   static void additionalDataSetup() {
      User u = [SELECT Id FROM User WHERE Name = 'yourname' LIMIT 1];
      System.runAs(u) {
         ... insert all additional records
      }
   }

   static testMethod void test_something() {
      additionalDataSetup();
      ...
   }

   static testMethod void test_somethingElse() {
      additionalDataSetup();
      ...
   }
}

Hope this helps.

[SalesForce] Deployment Test Failure – Too Many SOQL Queries: 101 but Query isn’t in a Loop

Your trigger looks fine to me. Just one quick tip. You don't actually need to do anything to the collection of Account_Administration__c records before calling DML update. You will cause your trigger to fire (assuming you have a before/after update trigger on Account_Administration__c) simply by virtue of calling update <collection>.

You could go so far as to just issue an update on the result set of a query.

update [SELECT Id, Enable_Online_Registration__c FROM Account_Administration__c WHERE Account_Name__c IN :acctIds];

Now, on to your failing test.

From the look of it, you're doing a ton of setup. I didn't count exactly how many dml updates were issued, but it's not a small number.

Each of those updates causes triggers to run, which probably contribute to the number of SOQL queries being run before your test proper even begins.

I have two suggestions:

see if you can consolidate some of those Event updates
wrap your actual test code inside Test.startTest() and Test.stopTest()

The second suggestion in particular will help you out. It is used to separate test setup from the actual test that you're trying to run. It also separates the governor limits, giving you a fresh set for use in your test proper.

+edit:

On further inspection, your unit test is also incomplete. There aren't any assertions being made, so you're not really testing anything. You're getting the code coverage, yes, but covered != tested.

I could still look over this test some more; but, after my second reading, I get the feeling that instead of being a single test, this should be broken up into multiple tests (each testing only one of the event updates, querying the account after the test, and making assertions against the result state of your account).

Best Answer

Related Solutions

[SalesForce] Too many SOQL queries: 101 – Test Class w. no queries / DML inside loops

[SalesForce] Deployment Test Failure – Too Many SOQL Queries: 101 but Query isn’t in a Loop

Related Topic