[SalesForce] Trigger to update 2 picklist values

I have a requirement for updating two picklist value if a checkbox is ticked.

Feedback__c is one object which has Status__c and Resolution__c picklists.
Feedback_Comments__c is another that will have a trigger and the checkbox.

If checkbox in Feedback_Comments__c is ticked then status in Feedback__c should be set to 'Closed' and Resolution to 'Fixed'.

I'm new to triggers. Following is my code.

trigger UpdateStatusResolution on Feedback_Comment__c (before insert) {
   for (Feedback_Comment__c fc: Trigger.new) {
        if(fc.Comment_closes_Feedback__c=true ) 
         Feedback__c.Status__c = 'Closed';
         Feedback__c.Resolution__c = 'Fixed';
    }
  }

Error: Compile Error: Expression cannot be assigned at line -1 column -1

Please guide me.

Thanks

Best Answer

Try

trigger UpdateStatusResolution on Feedback_Comment__c (before insert) {
    Feedback__c[] feedbacks = new Feedback__c[]{};
    for (Feedback_Comment__c fc: Trigger.new) {
        if(fc.Comment_closes_Feedback__c){ 
            feedbacks.add(new Feedback__c( Status__c = 'Closed',
                                           Resolution__c = 'Fixed'
                                           id = fc.Feedback__c
                                           ));
        }
    }

   if(!feedbacks.isEmpty()){
       update feedbacks;
   } 
}

Related Solutions

[SalesForce] Test Apex Class Error: Error: Compile Error: Expression cannot be assigned at line -1 column -1

You need to use the instance variable not the class!

Contact.FirstName = 'John';
Contact.LastName = 'Jones';

Should be:

newContact.FirstName = 'John';
newContact.LastName = 'Jones';

[SalesForce] Fire Trigger Only When Stages Moves to Closed Won

You need to adjust your IF() statement to something like this

If(opp1.isWon && !oldMap.get(opp1.Id).isWon){
    //code
}

Also need to ensure you have trigger.oldMap

trigger

trigger MainTriggerOpportunity on Opportunity (after update) {
    ClassRenewalOppClone updater13 = new ClassRenewalOppClone();
    updater13.cloneOpp(Trigger.new, trigger.oldMap);
}

Utility Class

public void cloneOpp(List<Opportunity> cloneOpp, map<Id,Opportunity> oldMap) {
    //code
}

You have a few issues with the trigger that you may also that are not best practice. You have SOQL within a For loop as well as DML statements within a For loop, so you are likely to run into some governor issues very soon.

I would try to utilize collections (Lists, Sets, and Maps) to move your SOQL and DML outside of the for loop.

See below for some best practices

https://developer.salesforce.com/page/Apex_Code_Best_Practices

https://developer.salesforce.com/page/Trigger_Frameworks_and_Apex_Trigger_Best_Practices

General trigger bulkification - best practices

http://blog.jeffdouglas.com/2011/01/06/fun-with-salesforce-collections/

Best Answer

Related Solutions

[SalesForce] Test Apex Class Error: Error: Compile Error: Expression cannot be assigned at line -1 column -1

[SalesForce] Fire Trigger Only When Stages Moves to Closed Won

Related Topic