[SalesForce] Trigger to update field on Account, on related opportunities, which is a custom lookup from Account to Opportunity

I have the below trigger to update count of Opportunities not equal to Stagename closed on the account page field Count_Of_Projects_Not_Lost__c

The below trigger is working for Deletes,inserts and if from opportunities the account association is removed.

But for testing purpose, if I change a opportunity from '9-Closed' to any other Open value, the count of project number is not getting updated

Can you please give me some pointers regarding this

trigger CountProjectonAccounts on Opportunity (after insert, after delete,after undelete,after update) {


    Set<Id> aId = new Set<Id>();

if(Trigger.isInsert || Trigger.isUndelete){
    for(Opportunity opp : Trigger.New){
        aId.add(opp.Oppor_Existing_Hotel_Plot_Portfolio__c);
    }
    List<Account> acc = [select id,Count_Of_Projects_Not_Lost__c from Account where Id in:aId];
    List<Opportunity> con = [select id from Opportunity where StageName!='9- Lost' and Oppor_Existing_Hotel_Plot_Portfolio__c in :aId];

    for(Account a : acc){
        a.Count_Of_Projects_Not_Lost__c=con.size();

    }update acc;
}

if(Trigger.isDelete){
    for(Opportunity opp : Trigger.old){
        aId.add(opp.Oppor_Existing_Hotel_Plot_Portfolio__c);
    }
    List<Account> acc = [select id,Count_Of_Projects_Not_Lost__c from Account where Id in:aId];
    List<Opportunity> con = [select id from Opportunity where StageName!='9- Lost' and Oppor_Existing_Hotel_Plot_Portfolio__c in :aId];

    for(Account a : acc){
        a.Count_Of_Projects_Not_Lost__c=con.size();

    }update acc;
}

if(Trigger.isUpdate){
   Set<Id> OldAId = new Set<Id>(); 
    for(Opportunity opp : Trigger.new){
    if(opp.Oppor_Existing_Hotel_Plot_Portfolio__c != Trigger.oldMap.get(opp.id).Oppor_Existing_Hotel_Plot_Portfolio__c)
        aId.add(opp.Oppor_Existing_Hotel_Plot_Portfolio__c);
        OldAId.add(Trigger.oldMap.get(opp.id).Oppor_Existing_Hotel_Plot_Portfolio__c);

    }
    if(!aId.isEmpty()){
    //for new Accounts
    List<Account> acc = [select id,Count_Of_Projects_Not_Lost__c from Account where Id in:aId];
    //For New Account Contacts
    List<Opportunity> con = [select id from Opportunity where StageName!='9- Lost' and Oppor_Existing_Hotel_Plot_Portfolio__c in :aId];

    /*
    This is For Old Contacts Count
                          */

    //for Old Accounts
    List<Account> Oldacc = [select id,Count_Of_Projects_Not_Lost__c from Account where Id in:OldAId];

    //For Old Account Contacts
    List<Opportunity> OldCon = [select id from Opportunity where StageName!='9- Lost' and Oppor_Existing_Hotel_Plot_Portfolio__c in :OldAId];

    //For New Accounts
    for(Account a : acc){
        a.Count_Of_Projects_Not_Lost__c=con.size();


    }update acc;

    //For Old Accounts
    for(Account a : Oldacc){
        a.Count_Of_Projects_Not_Lost__c=OldCon.size();

    }update Oldacc;
    }
}
}

Best Answer

I think you have a logic problem in addition to your what you state. The logic problem is that you are not associating the account being updated with the collection of opportunities. That will be problematic when you have more than one account in the collection.

I changed your code to be cleaner (less repetition) to adjust your logic problem and to solve your stated issue (you have to check if the stage changed, not only if the portfolio changed)

trigger CountProjectonAccounts on Opportunity (after insert, after delete,after undelete,after update) {


    Set<Id> aId = new Set<Id>();
    List<Opportunity> oppsToIterate;

    if(Trigger.isInsert || Trigger.isUpdate || Trigger.isUndelete) {
        oppsToIterate = trigger.new;
    } else if(Trigger.isDelete){
        oppsToIterate = trigger.old;  
    }

    for(Opportunity opp : oppsToIterate){
        if (! trigger.isUpdate) {
            aId.add(opp.Oppor_Existing_Hotel_Plot_Portfolio__c);
        } else if (opp.Oppor_Existing_Hotel_Plot_Portfolio__c != Trigger.oldMap.get(opp.id).Oppor_Existing_Hotel_Plot_Portfolio__c ||
                   opp.StageName != Trigger.oldMap.get(opp.id).StageName) {
            aId.add(opp.Oppor_Existing_Hotel_Plot_Portfolio__c);
            aId.add(Trigger.oldMap.get(opp.id).Oppor_Existing_Hotel_Plot_Portfolio__c);
        }

    }

    //Check the name `Oppor_Existing_Hotel_Plot_Portfolios__r` to make sure it matches your actual relationship name
    List<Account> acc = [select id,Count_Of_Projects_Not_Lost__c, (Select Id from Opportunities where StageName!='9-Lost') from Account where Id in:aId];

    for(Account a : acc){
        a.Count_Of_Projects_Not_Lost__c = a.Opportunities.size();

    }
    update acc;

}

Related Solutions

[SalesForce] Unit Test is Providing 0% Coverage for Apex Trigger

The trigger code is having lot of redundancy, So I modified it. before posting the modified code few lines of explanation what I changed. you collected account Ids twice and did the condition check twice where once is more enough. I am also made changes to the test class, where Task data is provided which is not required because the trigger has to create it once the necessary conditions are met. I am expecting this trigger should work for you, if there is any errors feel free to post as a comment.

trigger OpportunityAfter on Opportunity (after update){

    Set AccountIDs = new Set();

    for(Opportunity o : trigger.new){
        if(opp.StageName == 'Closed - Lost' && opp.Business_Line__c == 'Workforce' && 
            opp.Survey_Type__c != 'APulse' && trigger.oldMap.get(opp.Id).StageName != opp.StageName){

                AccountIDs.add(o.AccountId);
         }
    }

    Task[] tasksToInsert = new Task[]{};

    for (Account acc : [Select Id, Name, OwnerId from Account where Id IN :AccountIds]){
        for (Opportunity opp : trigger.new){
            if(opp.AccountId == acc.Id){
                Task tas = new Task();
                tas.WhatId=acc.Id;
                tas.OwnerId=opp.OwnerId;
                tas.Subject='Follow-up: ' + opp.name + ' - ' + acc.name;
                tas.ActivityDate=(opp.CloseDate + 180);
                tas.Description='Follow up to see how engagement initiatives are going and if Avatar can help. Refer to lost opportunity: ' + opp.name;
                tasksToInsert.add(tas);                                                         
            }
        }
    }
    if(tasksToInsert != null && !tasksToInsert.isEmpty())
    Database.insert(tasksToInsert);

}

@isTest
public class TestClass {

    static testMethod void myUnitTest() {

    //Set up user
    User u1 = [SELECT Id FROM User WHERE Email='abc@sampleemail.com'];
    test.startTest();  
    //Run As U1
    System.RunAs(u1){

    System.debug('Testing trigger... (single record validation)');

    //NEW Account record
    Account acc = new account();
    acc.Name = 'Test Account';
    acc.Industry = 'Healthcare';

    insert acc;

    //NEW Opportunity record
    Opportunity opp = new Opportunity();
    opp.Name = 'Test Opportunity'; 
    opp.CloseDate = System.today();
    opp.StageName = 'S1 - Investigative';
    opp.Type = 'Repeat Business - Wrkforce HC';
    opp.AccountId = acc.Id;
    opp.Survey_Type__c = 'Product Name';

    insert opp;

    opp.StageName = 'Closed - Lost';
    opp.Reason_Won_Lost__c = 'Relationship';
    opp.Business_Line__c = 'Workforce'  //added this line to meet the if condition while collecting the set of id in the trigger.

    update opp;
   test.stopTest();
    // Here I am expecting the task has been inserted and doing a query for it         and check it in the assert statement.
   Task  testTask=[Select Id, WhatId from Task where WhatId=:acc.Id];
    //Validate single insert
    System.assertEquals(acc.Id, testTask.WhatId);

    }
    }
}

[SalesForce] Trigger to copy child object picklist values to parent object separated by comma

The code you have shared will not at all compile.

use close brace here for (Opportunity childObj : Trigger.new)
use childObj.AccountId instead of childObj.Account to access AccountId
When you use relationship query be sure to use Opportunities instead of Opportunity.
You should put Opportunity's Opp_Location__c into a List. Then use String.join() to add those with comma delimited.
And finally update accounts.

Trigger

trigger UpdateAmount on Opportunity (after insert, after update) { 
  Map<ID, Account > parentOpps = new Map<ID, Account>(); 
  Set<Id> listIds = new Set<Id>();

  for (Opportunity childObj : Trigger.new) {
    listIds.add(childObj.AccountId);
  }

  parentOpps = new Map<Id, Account>([SELECT id, Location_Type__c ,
                                        (SELECT ID, Opp_Location__c  FROM Opportunities) 
                                    FROM Account WHERE ID IN :listIds]);

  List<Account> lstAccount = new List<Account>();

  for(Account acct:parentOpps.values())
  {  
      List<String> strType = new List<String>();
      for(Opportunity oppty:acct.Opportunities)
      {
          strType.add(oppty.Opp_Location__c);
      }
      acct.Location_Type__c = String.join(strType,',');

  }

  update parentOpps.values();
}

Best Answer

Related Solutions

[SalesForce] Unit Test is Providing 0% Coverage for Apex Trigger

[SalesForce] Trigger to copy child object picklist values to parent object separated by comma

Related Topic