[SalesForce] Trouble with Test Class

I need to create a test class to test an apex Controller/Extension I have created.

Functionality Objective: Embed flow in Visualforce page, so that the flow is started from a custom button on the standard task object, the flow marks the originating task as completed then takes the user to a screen input form pre-populated with information from the originating task. The user then updates additional information and a new Sales History (custom object) record is created. User is then taken to a page confirming the Sales History was successfully logged, and the user is routed to the new Sales History record when they click the finish button.

Visualforce page:

<apex:page standardController="Task" extensions="flowLSHfTaskContExt" showHeader="false" sidebar="false">
<flow:interview name="LogSalesHistoryFromTask" interview="{!historyFlow}" finishLocation="{!SalesHistoryPage}" >
   <apex:param name="TaskID" value="{!Task.Id}" />
 </flow:interview>

Apex Controller/Extension:

public class flowLSHfTaskContExt {
private final Task task;
public flowLSHfTaskContExt(ApexPages.StandardController stdController){}
public Flow.Interview.LogSalesHistoryFromTask historyFlow { get; set; }
public String getSalesHistoryID() {
    if (historyFlow==null) return '';
    else return historyFlow.SalesHistoryID;
    }
public PageReference getSalesHistoryPage(){
    return new PageReference('/' + getSalesHistoryID());
    }
}

I now need to create a test class to test the above controller/extension. Here's what I have so far:

@isTest
public class flowLSHfTaskContExtTest {
    @isTest
    public static void testflowLSHfTaskContExt() {
          PageReference pageRef = Page.SalesHistoryPage;
          Test.setCurrentPage(pageRef);

        flowLSHfTaskContExt controller = new flowLSHfTaskContExt(ApexPages.StandardController );
        String nextPage = controller.save().getUrl();

        // Add parameters to page URL
        ApexPages.currentPage().getParameters().put('SalesHistoryID');

        // Instantiate a new controller with all parameters in the page
        controller = new flowLSHfTaskContExt(); 
        controller.setSalesHistoryID('a0Xc0000003Zc4n');
        nextPage = controller.save().getUrl();
    }
}

I can't seem to get the test class to save, and am not sure if I am heading down the right path with this.

I updated my test class to create an account (required on final Sales History record), then a task with the account ID as the what ID, then call the standard task controller and the flows controller extension, but I am still getting errors, such as SalesHistoryPage does not exist.

I am not sure that this is the best approach for the test class, as I don't think you can start a flow from an apex class.

Ok… so the user is clicking a Custom Button (detail page button) on the task record, the content source is a Visualforce page, which kicks off a Flow and sets the Finish Location of the Flow to the newly created Sales History Record. During the Flow the user is taken to an Input Screen where they add details for the Sales History Record when the user clicks the Next Button in the flow, the Sales History Record is created, and the Controller Extension gets the SalesHistoryID and creates a a temporary Page Reference getSalesHistoryPage(), which returns a new PageReference [('/' + getSalesHistoryID())]. The user is then taken to another screen in the flow, letting them know that the Sales History record was successfully created. The VisualforcePage then sets the finishLocation for the flow as {!SalesHistoryPage} which the user is redirected to when they click the Finish Button in the flow.

I don't believe I need to test the flows creation of the SalesHistory record, wouldn't I just need to test the controller extensions ability to pass the SalesHistoryID to the finish location on the VF page?

Here is my updated class, everything that causes an error on save has been commented out.

@isTest
public class flowLSHfTaskContExtTest {
@isTest
public static void testflowLSHfTaskContExt() {
    //Insert Account
    Account testAccount = new Account(Name='TestClassTaskAccount');
    insert testAccount;

    // Retrieve the new Account
    testAccount = [SELECT Id FROM Account WHERE Id =:testAccount.Id];

    // Insert Task
    Task testTask= new Task(Subject='TestClassTask',Type='Task',KSI_Type__c='Discovery',WhatId=testAccount.Id);
    insert testTask;

    // Retrieve the new Task
    testTask = [SELECT Id FROM Task WHERE Id =:testTask.Id];

    ApexPages.StandardController stdController = new ApexPages.StandardController(testTask);
    flowLSHfTaskContExt controller = new flowLSHfTaskContExt(stdController);
    // public Flow.Interview.LogSalesHistoryFromTask historyFlow { get; set; }
    // nextPage = controller.save().getPageReference();
    // PageReference pageRef = Page.SalesHistoryPage;
    // Test.setCurrentPage(pageRef);


    // controller.getSalesHistoryID;

    // Add parameters to page URL
    // ApexPages.currentPage().getParameters().put('SalesHistoryID');
}
}

Am I going about this the wrong way? Maybe I don't need a test class, since it is related to a flow? It seems like this shouldn't be so difficult. I am trying to get this pushed to production and launched to our users. Any help would be appreciated!

Best Answer

To create an instance of the class, you first need to get a StandardController.

So your steps in the test will be:

Create and insert a Task record.
Create an instance of ApexPages.StandardController
Create an instance of flowLSHTaskContExt

Task testTask = new testTask(); //Add the fields required for a Task here
insert testTask;
ApexPages.StandardController stdController = new ApexPages.StandardController(testTask);
flowLSHfTaskContExt controller = new flowLSHfTaskContExt(stdController);

Related Solutions

[SalesForce] Visualforce Page Unknown Constructor Error

Check and make sure that in your controller extension you have a constructor like,

public LSHfTaskFlowControllerExtension{
  private final Task myTask;
  public LSHfTaskFlowControllerExtension(ApexPages.StandardController stdController) {
        this.myTask = (Task)stdController.getRecord();
        // Some code...
  }

  // Your code
}

This is a must when you are using a controller extension. Check here for more details to get an idea of why and benefits of having a controller extension. When you need get the benefit of a controller, there are two options.

Sometimes it's no need of having controller extension and we can work with just having a custom controller. In that case there are no mandatory constructors to be implemented. Here is the documentation.

[SalesForce] Unit Test is Providing 0% Coverage for Apex Trigger

The trigger code is having lot of redundancy, So I modified it. before posting the modified code few lines of explanation what I changed. you collected account Ids twice and did the condition check twice where once is more enough. I am also made changes to the test class, where Task data is provided which is not required because the trigger has to create it once the necessary conditions are met. I am expecting this trigger should work for you, if there is any errors feel free to post as a comment.

trigger OpportunityAfter on Opportunity (after update){

    Set AccountIDs = new Set();

    for(Opportunity o : trigger.new){
        if(opp.StageName == 'Closed - Lost' && opp.Business_Line__c == 'Workforce' && 
            opp.Survey_Type__c != 'APulse' && trigger.oldMap.get(opp.Id).StageName != opp.StageName){

                AccountIDs.add(o.AccountId);
         }
    }

    Task[] tasksToInsert = new Task[]{};

    for (Account acc : [Select Id, Name, OwnerId from Account where Id IN :AccountIds]){
        for (Opportunity opp : trigger.new){
            if(opp.AccountId == acc.Id){
                Task tas = new Task();
                tas.WhatId=acc.Id;
                tas.OwnerId=opp.OwnerId;
                tas.Subject='Follow-up: ' + opp.name + ' - ' + acc.name;
                tas.ActivityDate=(opp.CloseDate + 180);
                tas.Description='Follow up to see how engagement initiatives are going and if Avatar can help. Refer to lost opportunity: ' + opp.name;
                tasksToInsert.add(tas);                                                         
            }
        }
    }
    if(tasksToInsert != null && !tasksToInsert.isEmpty())
    Database.insert(tasksToInsert);

}

@isTest
public class TestClass {

    static testMethod void myUnitTest() {

    //Set up user
    User u1 = [SELECT Id FROM User WHERE Email='abc@sampleemail.com'];
    test.startTest();  
    //Run As U1
    System.RunAs(u1){

    System.debug('Testing trigger... (single record validation)');

    //NEW Account record
    Account acc = new account();
    acc.Name = 'Test Account';
    acc.Industry = 'Healthcare';

    insert acc;

    //NEW Opportunity record
    Opportunity opp = new Opportunity();
    opp.Name = 'Test Opportunity'; 
    opp.CloseDate = System.today();
    opp.StageName = 'S1 - Investigative';
    opp.Type = 'Repeat Business - Wrkforce HC';
    opp.AccountId = acc.Id;
    opp.Survey_Type__c = 'Product Name';

    insert opp;

    opp.StageName = 'Closed - Lost';
    opp.Reason_Won_Lost__c = 'Relationship';
    opp.Business_Line__c = 'Workforce'  //added this line to meet the if condition while collecting the set of id in the trigger.

    update opp;
   test.stopTest();
    // Here I am expecting the task has been inserted and doing a query for it         and check it in the assert statement.
   Task  testTask=[Select Id, WhatId from Task where WhatId=:acc.Id];
    //Validate single insert
    System.assertEquals(acc.Id, testTask.WhatId);

    }
    }
}

Best Answer

Related Solutions

[SalesForce] Visualforce Page Unknown Constructor Error

[SalesForce] Unit Test is Providing 0% Coverage for Apex Trigger

Related Topic