[SalesForce] Validation of required fields or disable Save button

With my existing VF page and controller, what do I need to do to be able keep the 'save' method from being called by an accidental click? Can I add validation or disable the save button?

When the Saved button is clicked and all of the required fields are not Null. A message appears notifying the user that the record was saved. VF is closed after 5 seconds. Account page reloads.

VF page

<apex:page standardController="Merchandising__c"  extensions="MerchandisingController"  standardstylesheets="true" showheader="false"  >
 <script>
   function Closewindow(){
   window.close();
   window.opener.location.href="/{!$CurrentPage.parameters.someId}";
   window.top.refresh();
}
</script>

<div style="background-color:green;height:500px;width:800px;">
   <apex:form id="Merchandising">
    <apex:sectionHeader title="Choose Merchandizing"/>
    <apex:pageBlock title="Demo Page">
    Delivery Date = '05/18/2018';
        <apex:pageBlockSection columns="2">             
          <apex:inputField value="{!merch.Merchandise__c}"/>
          <apex:inputField value="{!merch.Date_Displayed__c}"/>
          <apex:inputField value="{!merch.Merchandise_Category__c}"/>
          <apex:outputfield value="{!merch.Date_Delivered__c}"  html-disabled="true" />
          <apex:inputField value="{!merch.Merchandise_SubCategory__c}"/>                
          <apex:inputField value="{!merch.Date_Removed_Replaced__c}"/>
        </apex:pageBlockSection>
        <Br></Br><Br></Br><Br></Br>    

        <div align="center" draggable="false" >
        <apex:commandButton action="{!save}" value="Save" onclick="setTimeout(Closewindow, 5000)" id="saveButton" reRender="Panel" />        
        &nbsp;&nbsp;&nbsp;&nbsp;
        <apex:commandButton value="Cancel" onclick="window.close();" immediate="true"/>
        </div>

        <apex:outputPanel id="Panel" style="font-size:16px;color:red">
            <apex:messages />
        </apex:outputPanel>
    </apex:pageBlock>
</apex:form>
       &nbsp;&nbsp;&nbsp;&nbsp;

</div>     
</apex:page>

Controller

public with sharing class MerchandisingController {

public Merchandising__c merch{get;set;}
public string message {get;set;} 

public MerchandisingController (ApexPages.StandardController controller) 
{
    merch = new Merchandising__c();
    merch.Account__c= ApexPages.CurrentPage().getparameters().get('someId');
}

 public void save() 
 {
    insert merch; 
    message = 'Record Created Successfully.Please add pictures of the disply to the Account. Thank you!'; 
    ApexPages.AddMessage(new ApexPages.Message(ApexPages.Severity.CONFIRM,message )); 
 }  
}

Best Answer

The code above restricts the user from perform an accidental click, while the save is being performed, once the Save button is clicked.

Validations are required to ensure consistency in the input data. In order to restrict a Save, when fields are left empty, you can use the required attribute on <apex:inputField> as below.

<apex:inputField value="{!merch.Merchandise__c}" required="true"/>

However, is it important to understand that this technique will only mandate the field, to have a value only on this page. In case, you have the same field being populated with values through other mechanisms such as via an API integration or through a data upload, and require the same mandate to be applied there, you should mark the field as required on the respective Sobject rather than on the Visualforce page.

Related Solutions

[SalesForce] Save and close button not checking for required field

In this instance you'll need to not save, but mock save as you redirect to the next page. I can think of a couple of ways you might do this. The question is, do you really need to save whilst going to the next page, or can you just make do with holding the data in memory.

Use the View State Two pages sharing the same controller will keep non-static variable state in between requests. A lot of people are annoyed by this as it adds to the page payload. Historically new VF developers have ignored the effects of putting too much stuff in the page view state causing VF page load times to be slow.

But in this instance, you can definitely take advantage of this. To show this, I'll use two pages, the first of which is yours and taken your exact controller and added two navigation methods to go back and forth between to pages. I've renamed them ViewStateStudy_page1, ViewStateStudy_page1, and ViewStateStudy_controller.

public with sharing class ViewStateStudy_controller {

...all of the rest of this is as your original controller class...
//these are two new methods
//also note the use of the static reference to the page 
//instead of relative URL

    public PageReference page2(){
    return Page.ViewStateStudy_page2;   
}
public PageReference page1(){
    return Page.ViewStateStudy_page1;   
}
}

So here, my method does absolutely nothing except tell the VF engine to go to a different page. If I go to the first page, ViewStateStudy_page1 and don't specify the id param, I get an empty Account instance (by extension) and Name field.

Initial nav to page is empty

This can be verified by a peek at the View State inspector.

View state shows an empty Account record

Now, I fill out the account name field and click Next. I've added a button that maps to the page2() method above.

<apex:commandButton action="{!page2}" value="Next"/>

As you see, it doesn't do anything except submit a post request which takes me to the next page.

Enter in my account name on page1

Once I arrive at the next page, I can still see the value typed into the first page.

enter image description here

Here the View State inspector let's you down a bit, but if I were to add a save button on page 2, I'd be in good shape.

There are a couple of things you must do and must not do to make this work.

The controller must be the same for both pages.
The second page must be arrived at using HTTP POST. You ensure this happens by not using PageReference.setRedirect(true). The minute you add that, you wipe the entire view state and start over.
Ensure variables are not transient. Transient can be either explicitly declared in a class member, is implicit to some classes (like PageReference, for instance) and static members.
Immediate=true on you button will not post data into the view state. It is usually reserved for cancel buttons and the like.

So what about option number 2 in my mock save scenario. If you had to actually stick something in the database temporarily, that wasn't validated, there are numerous options: serialize it into xml or json and stuff it into a long text field to retrieve later, create a dummy sobject (costly for object limits, but an option). These put the onus on you to manage your own state, but can be done.

To pursue some of these, take a look at the articles on developerforce on view state management that go into some more details. There was also a very well done video at Dreamforce this year on building efficient Visualforce pages that you should check out.

Finally, I've added the entire code from my example pages to a gist if you wish to take a look.

[SalesForce] disable save button in page for particular stage

In your Controller you can create a property that indicates if the picklist should be enabled.

public boolean stagesDisabled {
    get {
        // Replace stage__c with the correct custom object field reference
        return myCustomObject.stage__c != 'completed';
    }
}

Then, in your Visualforce page you bind this to your commandButtons disabled property.

<apex:commandButton action="{!someAction}" value="Save&new" disabled="{!stagesDisabled}" />

Best Answer

Related Solutions

[SalesForce] Save and close button not checking for required field

[SalesForce] disable save button in page for particular stage

Related Topic