‘System.NullPointerException: Attempt to de-reference a null object’ error on test class for @RestResource @HttpPost

apexhttppostpost

I developed an Apex REST web service in Salesforce with the method 'POST'
This is my main class

public class Product {
    public String pName;
    public String pRating;
    public List<Item> Items;
}

public class Item{
    public String Name;
    public String Code;
}
@HttpPost
global static String createRecord() {
    
    RestRequest req = RestContext.request;
        RestResponse res = RestContext.response;
        String jSONRequestBody=req.requestBody.toString();
        Map<String,Object> jsonMap = (Map<String, Object>)JSON.deserializeUntyped(jSONRequestBody);
        String root = JSON.serialize(jsonMap.get('Product'));
        List<Product> Products = (List<Product>)JSON.deserialize(root,Product[].class);
    // Other logic for inserting records in objects
}

I am trying to write a test class for this, when i run the test class i am getting this error 'System.NullPointerException: Attempt to de-reference a null object'
Here is the test class

    @istest
    public static void dataSetup(){
        
        String ProductJson = '{'+
        '    \"Product\": [{'+
        '        \"pName\": \"Name new patch\", '+
        '        \"pRating\": \"15\", '+
        '    \"Item\":[                                 '+
        '         {                      '+
        '        \"Name\": \"item1\" ,'+
        '        \"Code\" : \"54294\" '+
        '        },'+
        '        {'+
        '        \"Name\": \"item2\",'+
        '        \"Code\" : \"57435\"'+
        '        }'+
        '     ],'+
        '    }]'+
        '}';
    
        RestRequest req = RestContext.request;
        RestResponse res = RestContext.response;
        req.requestURI = '/services/apexrest/demoURL';
        req.httpMethod = 'POST';
        req.requestBody = Blob.valueOf(ProductJson);
        RestContext.request = req;
        RestContext.response = res;

        Test.startTest();
        myRESTAPI.createRecord();
        Test.stopTest();
}

Best Answer

The error is related to the fact that req object that has not been instantiated.

Instead of: RestRequest req = RestContext.request;

You need to do RestRequest req = new RestRequest(); (Additionally, the same applies for your res variable).

Related Solutions

[SalesForce] wrapper class – System.NullPointerException: Attempt to de-reference a null object

You are using an uninitialized property discountSchedule in your for loop at line 95:

for(Custom_Package__c Proj1  :[select Id,Market__c from Custom_Package__c where ID=:cp.discountSchedule ] )
{
...
}

You are defining the property in your CustomPackageWrapper object, but I think you are never initializing it so it remains null when your code enters the for loop. I managed to reproduce the same error with similar code.

EDIT

I'm not 100% sure what you are trying to achieve with your code here, and I'm not sure what the Custom_Package__c object is and is supposed to do, I can only assume.

So, I'm assuming that you want to hold a list of Custom_Package__c IDs in the discountSchedule variable based on your for loop query. The [select Id,Market__c from Custom_Package__c where ID=:cp.discountSchedule ] query means that you want to return a list of Custom_Package__c objects who's ID is contained inside the cp.discountSchedule list - that's the where ID=:cp.discountSchedule part.

IF my assumption is right, you'll first have to rewrite the WHERE part of the query so the full query is like below (as this is how you check if ID is part of a list in query):

[SELECT Id,Market__c FROM Custom_Package__c WHERE Id IN :cp.discountSchedule]

And before your for loop you'll have to obtain a list of IDs of your Custom_Package__c objects. I'm not sure how you will do that and from where, that is something that you'll have to figure out as you are the one who knows what he is trying to achieve with this VF page.

That's all I can say about this at this time, and these are all assumptions. By giving you the cause of your exception I should have given you enough to start at least. The bottom line is that your cp.discountSchedule list is null, so you need to initialize it, probably by querying for the required list of Custom_Package__c IDs.

[SalesForce] Error: System.NullPointerException: Attempt to de-reference a null object

convertStatus is null. My guess is that you have more than one valid converted status. You didn't get the appropriate error because you used a try-catch block to catch the QueryException without actually reporting an error. Consider changing your code from this:

try{
    convertStatus = [SELECT Id, MasterLabel 
                            FROM LeadStatus 
                            WHERE IsConverted=true and MasterLabel='Converted' and Id != null]; 
}catch(System.QueryException e){
    System.debug('caught ya!');
}

To this:

convertStatus = [SELECT Id, MasterLabel 
                            FROM LeadStatus 
                            WHERE IsConverted=true and MasterLabel='Converted' LIMIT 1];

In general, if you're not prepared to handle an exception, do not use a try-catch block. See this question and answer for when using try-catch is okay, and when it's not.

Best Answer

Related Solutions

[SalesForce] wrapper class – System.NullPointerException: Attempt to de-reference a null object

[SalesForce] Error: System.NullPointerException: Attempt to de-reference a null object

Related Topic