It depends on where they are standing
The darkness spell is described in such a way as to give the impression that it is something tangible that spills out around corners, but can be blocked by objects. Think of darkness as not unlike a fog cloud spell.
The darkness spreads around corners. [...] Completely covering the source of the darkness with an opaque object, such as a bowl or a helm, blocks the darkness.
Likewise, darkness engulfs non-magical light - or rather, it cannot be illuminated by non-magical light. This means that magical light can illuminate it.
Light in 5e is described as having bounds. Faerie fire indicates that afflicted creatures shed dim light, which only means that area imposes disadvantage on Wisdom (Perception) checks; attacking into dim light behaves as normal.
This is where location comes into play. The bounds of the dim light must penetrate the bounds of the darkness spell in order to be seen. Put another way, there must be no darkness between you and the creature. You need to check the positions and radius of the area of darkness and creatures affected by the faerie fire.
If the radius of the darkness spell's area completely engulfs the radius of the dim light, they cannot be seen by you from any angle. If they are 5 feet or more away from the center of the darkness, they can be seen from the direction the dim light is from the center. This is sort of mathy, but really no more difficult than normal line of sight. Darkness spills out around corners continuously, so just visualize or draw the circles and draw a line to the center of the dim light.
Who do I have advantage against?
Advantage and disadvantage hinge on who can see whom. In general, you have disadvantage on attacks against targets you cannot see, and advantage on attacks against targets who can't see you. However, when neither target can see each other (such as when a target is standing in darkness and you are not), you have neither disadvantage or disadvantage.
From the basic rules on advantage:
If circumstances cause a roll to have both advantage and disadvantage, you are considered to have neither of them, and you roll one d20. This is true even if multiple circumstances impose disadvantage and only one grants advantage or vice versa.
This means that faerie fire's advantage only has an effect when no disadvantage is imposed. It is important to note that, as explained in the question, faerie fire must be cast at a level greater than 2nd, or darkness will dispel it.
You have advantage against:
- Targets you can see that can't see you. It shouldn't matter the
circumstances in which this takes place (Devil's Sight, location,
etc); if you can determine who can see whom, this will suffice for
advantage.
- Targets affected by faerie fire that you can see
- Targets in any situation in which you have at least 1 source of
advantage and no sources of disadvantage
You have disadvantage against:
- Targets not affected by faerie fire that you can't see and that can
see you
- Targets in any situation in which you have at least 1 source of
disadvantage and no sources of advantage
You have neither advantage nor disadvantage against:
- Targets you can't see that also can't see you
- Targets affected by faerie fire that you can't see
- Targets standing in dim light that you have line of sight to (i.e.
you can both see each other)
- Targets in any situation in which you have any number of sources of
advantage and disadvantage (at least one of each)
This answer hinges on the fact that the darkness spell is dark in 3 dimensions, much like a 15-foot radius of fog or smoke. I believe this is true because of how the darkness spills around corners and can be blocked by objects.
If the darkness spell only "darkens" objects and ground in its radius, then it makes sense to imply that the faerie fire penetrates through it, making line of sight meaningless. Is it a floating black orb, or is it a radius of darkened objects? Again, I say the former, but I would personally leave this up to the DM.
The expanded spell list tables are arranged by spell level.
The spells included in your expanded spell list table are considered to be included in the warlock spell list for you according to the given spell levels. The levels shown in the expanded spell list are not character or class levels. They are spell levels, as indicated in the table header.
This means that the 1st-level spells in your expanded list are added to the 1st-level warlock spells you can learn, the 2nd-level expanded list spells to the 2nd-level warlock spells you can learn, the 3rd-level expanded list spells with the 3rd-level warlock spells you can learn, and so on.
You become eligible to learn any of the spells on the expanded list of a given level precisely whenever you would be eligible to learn a standard warlock list spell of that level, which is indeed whenever your warlock spell slots are that level or higher.
So, for example, the 3rd-level spells listed in the expanded spell list are considered to be included in the list of 3rd-level warlock spells for you, meaning that you are able to learn them when you reach or exceed 5th-level as a warlock and become eligible to learn 3rd-level warlock spells in general.
Best Answer
The spell is chosen when you get the move.
A move that activated when you prepare spells would say "when you prepare spells" - The Wizard has no stock moves that work like this, but The Cleric's Divine Intervention/Invincibility have a similar trigger: "when you commune".
Because there is no precondition, the choice happens once, when you take the move. This makes The Wizard's choice of prodigy/mastery expressive of The Wizard's approach to magic, whatever that may be - contrast with the more simply worded "you may prepare one additional level of spells."
It's very difficult to find a rules cite to prove a negative, but if you'd care for a parallel case, grab The Fighter's playbook and have a look at Iron Hide: "you gain +1 armor". How many times do you think that's supposed to happen?
Though, to be fair, Fightgar's pretty much always getting use out of +1 armor. If Wizzrobe isn't getting the chance to prep the spell they're a prodigy at/master of, then even though the choice is only intended to be made once, maybe they should get together with the GM to work out how to change the rules.