[SalesForce] For loop within for loop

I have a custom object record with a start date, an end date, and a amount field. I want to be able to take the difference between the two dates in number of months, divide the amount by the difference and then create related records based on the difference count. To make a basic schedule.

I think I have to do two for loops in my class, however, I've never done two at the same time before so I'm unsure how to get started.

I know that to get the total number of months I can do this:

Integer numOfMonths = start_date.monthsbetween(end_date)

I know that to create the records I can do something like this:

for(Integer i = 0; i < numOfMonths; i++) {
    insert new Revenue_Schedules__c(
        Amount__c = amount/numOfMonths,
        Date__c = start_date.addmonths(numOfMonths), 
        );

How do you loop through values in the newMap to get each variable and then loop again to get records to insert?

-=EDIT=-

input example:
Revenue record with start_date = 10-1-2016, end_date = 9-1-2017, amount = 1100

output expectation:
12 Revenue Schedule records
* record 1, date = 10-1-2016 amount = 100
* record 2, date = 11-1-2016 amount = 100
* record 3, date = 12-1-2016 amount = 100
ect..

Best Answer

You should never do DML statements (such as insert) inside loops, this will easily get you off limits. Create a List outside the loop, iterate over your trigger in the first loop, create new records and add them to the list in the second loop, then insert everything outside the loop. Something like this:

List<Revenue_Schedule__c> new_records = new List<Revenue_Schedule__c>();

for (Your_Trigger_sObject__c current : trigger.new) {
    Integer numOfMonths = current.start_date.monthsbetween(current.end_date);
    for (Integer i=0; i < numOfMonths; i++) {
        new_records.add(
            new Revenue_Schedules__c(
                Amount__c = current.amount / numOfMonths,
                Date__c = current.start_date.addmonths(numOfMonths), 
            )
        );
    }
}

insert new_records;

The important is to keep the DML operation outside the loop. The same applies to queries, keep them always out.

Related Solutions

[SalesForce] Split a single field into 2 columns for a VF page

This is untested so you may need to have play, however this should return a List of the RevenueWrapper classes which contains the 4 columns you are looking to use in your VF page:

public class RevenueController{

Map<String, RevenueWrapper> ResultList = new Map<String, RevenueWrapper>(); 

public RevenueController(){
    List<AggregateResult> result =  [
    SELECT FISCAL_YEAR(Date__c) Date, Type__c, sum(Amount__c) Amount
    FROM Revenue__c
    GROUP BY FISCAL_YEAR(Date__c), Type__c];

    for(AggregateResult ar : result){

        RevenueWrapper RW = new RevenueWrapper();

        //If the RevenueWrapper already exists grab it from the Map
        if(ResultList.containsKey(String.valueOf(ar.get('Date')))){
            RW = ResultList.get(String.valueOf(ar.get('Date')));
        }

        //Set the amount
        RW.setAmount(ar);

        //Save back to the Map
        ResultList.put(String.valueOf(ar.get('Date')), RW);
    }
}

public List<RevenueWrapper> getResults() {
    return ResultList.values();
}


public class RevenueWrapper{
    public String revenueDate { get; set; }
    public Integer budgetAmount { get; set; }
    public Integer actualAmount { get; set; }
    public Integer varianceFYPercent { set; }
    public Integer varianceFYAmount { set; }

    public RevenueWrapper(){

    }

    public void setAmount(AggregateResult ar){
        revenueDate = String.valueOf(ar.get('Date'));

            //Set the amount value based on type
        if(ar.get('Type__c') == 'Budget'){
            budgetAmount = Integer.valueOf(ar.get('Amount'));
        }else if(ar.get('Type__c') == 'Actual'){
            actualAmount = Integer.valueOf(ar.get('Amount'));
        }else{ //Catch all for a type that isn't recognised
            return;
        }

    }

    public Integer getVarianceFYAmount(){
        return actualAmount - budgetAmount;
    }

    public Decimal getVarianceFYPercent(){
        if(budgetAmount != 0){
            return Decimal.valueOf((Double.valueOf(actualAmount) / Double.valueOf(budgetAmount)) * 100).setscale(1);
        } else{
            return 0;
        }
    }
}

}

[SalesForce] Need to build the dynamic soql query in trigger

As @Birthus mentioned a trigger will only work for this assuming you have less than 50k records in the DB. You can try to further filter your SOQL, but beyond that Batch may be the way to go.

Assuming that you have less than 50k records, then something like below should work, but will not work should you have a large number of Schedule__c records in the database already

trigger newrunway on Schedule__c (before insert, before update) {

    map<string,set<DateTime>> runway2DateMap = new map<string,set<DateTime>>();

    for(Schedule__c sched : [Select Id, Date__c, Runway__c From Schedule__c Where Date__c > TODAY And Id Not In : trigger.new]){
        if(!runway2DateMap.containsKey(sched.Runway__c)){
            runway2DateMap.put(sched.Runway__c, new set<DateTime>());
        }
        runway2DateMap.get(sched.Runway__c).add(sched.Date__c);
    }

    for(Schedule__c sched : trigger.new){
        if(runway2DateMap.get(sched.Runway__c).contains(sched.Date__c)){
            sched.addError('Flight Already Scheduled on the Runway');
        }
    } 
}

Related Topic