[SalesForce] how to break from a if statement

I have two objects, Revenue Schedule and revenue schedule split. Every Revenue Schedule will have 3 revenue schedule split records. For Revenue Schedule object I have 3 fields: sales rep 1, sales rep 2, and sales rep 3.

But I have only one field for Revenue schedule split object which is sales rep. Now on updating revenue schedule I want to update split records. Below is my code –

if(trigger.IsUpdate){

        for(Revenue_Schedule__c shed: Trigger.new){

        Double percentRemain = 100.0;
        percentRemain -= (Double) shed.Split_Percent_2__c;
        percentRemain -= (Double) shed.Split_Percent_3__c;

            for(Rev_Schedule_Split__c sp: revshedtoSplits.get(shed.id)){
            //split 1 calculation
                if(shed.Sales_Rep_1__c != null){
                    sp.Sales_Rep__c = shed.Sales_Rep_1__c;
                    sp.Amount_LC__c  = percentRemain * shed.Revenue_LC__c  * .01;
                    sp.Amount_USD__c = percentRemain * shed.Revenue_USD__c * .01;

                }
            //split 2 calculation
                if(shed.Sales_Rep_2__c != null){
                    sp.Sales_Rep__c = shed.Sales_Rep_2__c;
                    sp.Amount_LC__c  = shed.Split_Percent_2__c * shed.Revenue_LC__c  * .01;
                    sp.Amount_USD__c = shed.Split_Percent_2__c * shed.Revenue_USD__c * .01; 

                }
            //split 3 calculation
                if(shed.Sales_Rep_3__c != null){
                    sp.Sales_Rep__c = shed.Sales_Rep_3__c;
                    sp.Amount_LC__c  = shed.Split_Percent_3__c * shed.Revenue_LC__c  * .01;
                    sp.Amount_USD__c = shed.Split_Percent_3__c * shed.Revenue_USD__c * .01; 

                }
               toUpdatesplits.add(sp); 
            }

        }
        if(toUpdatesplits != null && toUpdatesplits.size()>0){
            update toUpdatesplits;
        }
    }

where revshedtoSplits is a map which stores Revenue Schedule id and corresponding split records. Above code is updating the split records with the sales_rep_3 for all split records. I want to update each split record by sales rep 1,2 and 3. I tried using break statement, but it is breaking from for loop itself. I just want to break from if loop. Please guide.

Best Answer

If you have all 3 sales rep fields populated on the Revenue Schedule object, all 3 conditions inside the for loop will match and the last condition will obviously overwrite the first 2.

one alternate i can think of is to run the loop with index based on the split record size and assign the reps to each of the split records in order..

something like below

if(trigger.IsUpdate){

    for(Revenue_Schedule__c shed: Trigger.new){

    Double percentRemain = 100.0;
    percentRemain -= (Double) shed.Split_Percent_2__c;
    percentRemain -= (Double) shed.Split_Percent_3__c;

    List<Rev_Schedule_Split__c> spList = revshedtoSplits.get(shed.id);
    if(spList == null || spList.isEmpty())
        continue;

        for(Integer i=0; i < spList.size(); i++){
            Rev_Schedule_Split__c sp
        //split 1 calculation
            if(i==0 && shed.Sales_Rep_1__c != null){
                sp.Sales_Rep__c = shed.Sales_Rep_1__c;
                sp.Amount_LC__c  = percentRemain * shed.Revenue_LC__c  * .01;
                sp.Amount_USD__c = percentRemain * shed.Revenue_USD__c * .01;

            }
        //split 2 calculation
            if(i==1 && shed.Sales_Rep_2__c != null){
                sp.Sales_Rep__c = shed.Sales_Rep_2__c;
                sp.Amount_LC__c  = shed.Split_Percent_2__c * shed.Revenue_LC__c  * .01;
                sp.Amount_USD__c = shed.Split_Percent_2__c * shed.Revenue_USD__c * .01; 

            }
        //split 3 calculation
            if(i==2 && shed.Sales_Rep_3__c != null){
                sp.Sales_Rep__c = shed.Sales_Rep_3__c;
                sp.Amount_LC__c  = shed.Split_Percent_3__c * shed.Revenue_LC__c  * .01;
                sp.Amount_USD__c = shed.Split_Percent_3__c * shed.Revenue_USD__c * .01; 

            }
           toUpdatesplits.add(sp); 
        }

    }
    if(toUpdatesplits != null && toUpdatesplits.size()>0){
        update toUpdatesplits;
    }
}

or if you have any other identifiers on the split records that can be used to pick the sales rep from the parent object, you can use that in the if statements.

Related Solutions

[SalesForce] Apex – how to batch update a ‘ranking’ on all accounts

What you need here is to implement Database.Stateful on your class to retain the index between calls to the execute method, without this the index will reset each time Batch Apex passes the job the next chunk of 200 records (which is the default chunk/scope size via Database.executeBatch).

Using State in Batch Apex

Each execution of a batch Apex job is considered a discrete transaction. For example, a batch Apex job that contains 1,000 records and is executed without the optional scope parameter is considered five transactions of 200 records each.

If you specify Database.Stateful in the class definition, you can maintain state across these transactions. When using Database.Stateful, only instance member variables retain their values between transactions. Static member variables don’t and are reset between transactions. Maintaining state is useful for counting or summarizing records as they're processed. For example, suppose your job processed opportunity records. You could define a method in execute to aggregate totals of the opportunity amounts as they were processed.

If you move your Integer out as a class member this will retain its state between calls, like so.

public class BatchTierUpdate implements Database.Batchable<sObject>
   implements Database.Stateful
{
    public final String Query;
    public Integer rankIndex;

    public BatchTierUpdate()
    {
        Query = 'SELECT Id FROM Account Order by Revenue__c';
        rankIndex = 1;
    }

    public Database.QueryLocator start(Database.BatchableContext BC) 
    {   
        return Database.getQueryLocator(query);
    }

    public void execute(Database.BatchableContext BC, List<Account> scope) 
    {   
        for (Account ac : scope) 
        {
            ac.Rank__c = i;
            rankIndex = rankIndex + 1;
        }
        update scope;
    }

    public void finish(Database.BatchableContext BC) { }    
}

Note: That i have also removed the global and used public, the documentation still shows this, as in the past it was a requirement, these days it is not, unless you want to expose this class to callers outside a managed package.

[SalesForce] For loop within for loop

You should never do DML statements (such as insert) inside loops, this will easily get you off limits. Create a List outside the loop, iterate over your trigger in the first loop, create new records and add them to the list in the second loop, then insert everything outside the loop. Something like this:

List<Revenue_Schedule__c> new_records = new List<Revenue_Schedule__c>();

for (Your_Trigger_sObject__c current : trigger.new) {
    Integer numOfMonths = current.start_date.monthsbetween(current.end_date);
    for (Integer i=0; i < numOfMonths; i++) {
        new_records.add(
            new Revenue_Schedules__c(
                Amount__c = current.amount / numOfMonths,
                Date__c = current.start_date.addmonths(numOfMonths), 
            )
        );
    }
}

insert new_records;

The important is to keep the DML operation outside the loop. The same applies to queries, keep them always out.

Best Answer

Related Solutions

[SalesForce] Apex – how to batch update a ‘ranking’ on all accounts

[SalesForce] For loop within for loop

Related Topic