[SalesForce] ‘Save’ Button and ‘Save & New’ Button in Custom Wizard Create Multiple Records if Clicked Multiple Times before New Page Is Loaded

I'm creating a custom wizard for a custom object. There is a 'Save' button which saves the record and redirects to the parent object. There is a 'Save & New' button which saves the record but remains on the page and creates a new record. So far so good except one rather irritating issue: if the 'Save' button is clicked multiple times before being redirected to the parent record, then multiple copies of the child record are saved, likewise for the 'Save & New' button.

I've tried using <apex:actionStatus> with <apex:facet> . This nicely disabled the button after clicking it and rerendered the button from 'Save' to 'Saving…' but ultimately didn't redirect to the desired page nor saved the record.

I've also tried adding a Boolean flag in my controller and changing its value in my save() method. Trying both:

<apex:commandButton id="savebutton" action="{!save}" value="Save" rendered="{!flag}"/> as well as:
<apex:commandButton id="savebutton" action="{!save}" value="Save" disabled="{!flag}"/>. But still multiple clicks would save multiple records.

I would prefer using the <apex:actionStatus> in my VF page, but can't get it to redirect properly. I think it has to do with rerendering overriding the page reference redirect.

Here is the save method in my controller as is without a flag:

public PageReference save(){
  PageReference parentPage = new ApexPages.StandardController(parent).view();      
  parentPage.setRedirect(true);

  try{
     insert component;
  } 
  catch(System.Exception e){

      ApexPages.addMessages(e);
      return null;

  }

  return parentPage;

}

Best Answer

Your button should control itself client-side:

    <apex:commandButton action="{!saveAndRedirectSample}" reRender="form" 
        status="status" onClick="this.disabled=true; this.className='btnDisabled';"
        onComplete="this.disabled=false; this.className='btn';" 
        value="Save And Redirect"/>

The VF framework should be able to redirect even in the event of a reRender attribute, so you may simply have a bug somewhere.

I've written a trivial example that demonstrates this:

public class DemoRedirectController {
    public PageReference saveAndRedirectSample() {
        Long startTime = System.now().getTime();
        while(System.now().getTime()-startTime<2000);
        return new PageReference('https://www.google.com/');
    }
}

<apex:page controller="DemoRedirectController">
    <apex:form id="form">
        <apex:actionStatus startText="Working..." id="status" />
        <apex:commandButton action="{!saveAndRedirectSample}" reRender="form" 
            status="status" onClick="this.disabled=true; this.className='btnDisabled';"
            onComplete="this.disabled=false; this.className='btn';" 
            value="Save And Redirect"/>
    </apex:form>
</apex:page>

Related Solutions

[SalesForce] Disable commandButton after first click to prevent double submission

The mechanism I have found to be most maintainable uses a JavaScript function called by an element's click event, which internally calls an actionFunction to post the form, disables the buttons on the page and then returns false on the commandlink/button. This is used in conjunction with an oncomplete on the actionFunction to re-enable the buttons when the form has been (ajax) posted and returns a result to the page.

Without the rerender attribute the form performs a full postback along with the disabling of the buttons.

Note: You can't disable the button(s) before the form is posted or the data sent to the controller will not include which button/link within the form was clicked and thus which action to execute.

<script src="//ajax.googleapis.com/ajax/libs/jquery/latest/jquery.js"></script>
<script>

    function buttonsEnabled(enabled) {
        // retrieve all of the buttons or links on the page
        // with the css class of btn
        var $buttons = jQuery('.btn');
        if (enabled === false) {
            // add the btnDisabled class to give it the look of being disabled
            // add the disabled attribute to actually disable interactability
            $buttons.toggleClass('btnDisabled', true).attr('disabled', 'disabled');
        } else {
            // remove the css class and the disabled attribute
            $buttons.toggleClass('btnDisabled', false).attr('disabled', null);
        } 
    }

    function doSomeWork() {
        // first, call the action function to post the form
        doSomeWorkActionFunction();

        // second, disable the buttons
        buttonsEnabled(false);

        // third, return false to prevent the click from
        // posting the form a second time
        return false;
    }

</script>

<apex:form>

    <apex:actionFunction name="doSomeWorkActionFunction" 
        action="{!yourControllerMethod}" 
        oncomplete="buttonsEnabled(true);"
        rerender="whateverYouNeedToRerender"></apex:actionFunction>

    <apex:commandLink action="{!yourControllerMethod}" 
        value="Your Text Here" 
        id="theCommandLink" 
        onclick="return doSomeWork();" />

</apex:form>

[SalesForce] How to prevent the creation of multiple Records with an overwritten save button

I would Agree to Lucid's solutions.

Solution1: Render the save button based on this flag i.e set a boolean variable to 'False' as soon as the function is called and render the command button based on this variable.

Solution 2: Write a select query in the function based on a unique ID in the object. If the query returns something, do not insert otherwise insert. Here's the sample code:

VF page:

<apex:commandButton value="Save" action="{!saveAndRedircet}" rendered="{!flag}"/>

Controller:

 public boolean flag{get;set;}

   public PageReference saveAndRedirect() {

     flag=false;
    PageReference result = null;

    try {
         list<MyObject__c> listMyObj = [Select <fieldNames> from MyObject__c where uniqueID=:your_unique_ID_from_VF_Page];
         if(listMyObj.size()==0)
          insert myObject;
          else
        upsert myObject;

        result = new PageReference('/' + myObject.mdr_Parent__c);
    }
    catch(Exception ignore) {}

    return result;
}

This code has both the above solutions implemented. Let me know if this works!

Best Answer

Related Solutions

[SalesForce] Disable commandButton after first click to prevent double submission

[SalesForce] How to prevent the creation of multiple Records with an overwritten save button

Related Topic