[SalesForce] Trigger On Order to get Opportunity Line Item from opportunity to add in orderlineitem

I am trying to create a trigger which is after insert and after update whenever i create order the opportunitline item will be added to the orderline item.I have created lookup relationship from order to opportunity.I have done as follwing but it is not creating order line item.

> trigger creatingMenuDetails on Order (after insert,after update)  {
    >     list<OrderItem> MD=new list<OrderItem>();
    >     for(Order op:trigger.new)
    >     {
    >         list<OrderItem> MD1=[SELECT AvailableQuantity,ListPrice,OrderId,OrderItemNumber,Quantity,UnitPrice
    > FROM OrderItem where OrderItemNumber=:op.id ];
    >         list<OpportunityLineItem> pd1=[SELECT Description,Id,ListPrice,Name,OpportunityId,Product2Id,ProductCode,Quantity,TotalPrice,UnitPrice
    > FROM OpportunityLineItem where Name=:op.Opportunity__c];
    >         
    >        if(MD1.size()==0)
    >         {
    >             for(integer i=0;i<pd1.size();i++)
    >             {
    >                 OrderItem om=new OrderItem();
    >                 om.OrderId=op.id;
    >                                                             
    >                 MD.add(om);
    >             }
    >         }
    >     } insert MD; }
    >

Best Answer

Hopefully this helps out, just did a quick refactor with no testing so you may still need to do a little brush up work.

trigger creatingMenuDetails on Order (after insert, after update)
{
    // Get all related opportunities from orders
    Set<Id> opportunityIds = new Set<Id>();
    List<Order> orderList = new List<Order>();
    for(Order o : Trigger.new)
    {
        if(o.Opportunity__c != NULL)
        {
            opportunityIds.add(o.Opportunity__c);
            orderList.add(o);
        }
    }

    // Query for all opportunities with their related opportunity line items
    Map<Id, Opportunity> oppsWithLineItems = new Map<Id, Opportunity>([SELECT Id, (SELECT Description,Id,ListPrice,Name,OpportunityId,Product2Id,ProductCode,Quantity,TotalPrice,UnitPrice FROM OpportunityLineItem) WHERE Id IN :opportunityIds]);

    if(opportunityIds.size() > 0)
    {
        // Loop through orders
        List<OrderItem> orderItemsForInsert = new List<OrderItem>();
        for(Order o : ordersList)
        {
            // For each order get the related opportunity and line items, loop through the line items and add a new order line item to the order line item list for each matching opportunity line item
            Opportunity oppWithLineItem = oppsWithLineItems.get(o.Opportunity__c);
            for(OpportunityLineItem oli : oppWithLineItem.OpportunityLineItems)
            {
                orderItemsForInsert.add(new OrderItem(AvailableQuantity=Quantity,OrderId=o.Id,etc,etc,etc));
            }
        }
        // If we have order line items, insert data
        if(orderItemsForInsert.size() > 0)
        {
            insert orderItemsForInsert;
        }
    }
}

Related Solutions

[SalesForce] Create OrderItem (Order Product) from Bulk upload Object

The reason you are getting the error is productOrders is not initiated.

Also moved a for loop to a upper place.

trigger OnUploadInsert on CSVUpload__c (after insert) {
    Account[] accounts = new Account[] {};
    Contact[] contacts = new Contact[] {};
    Boat__c[] boats = new Boat__c[] {};
    Membership__c[] memberships = new Membership__c[]{};
    Order[] orders = new Order[]{};
    OrderItem[] productOrders = new OrderItem[]{};//testing
    Promotion_Code__c[] promos = new Promotion_Code__c[]{};
    Set<String> setMemberType = new Set<String>(); // Used to store MemberType from CSVUpload__c object
    Map<String,Id> mapMemberTypeProductId = new Map<String,Id>(); // Used to store map of MemberType to Product I
    Set<String> setProductId = new Set<String>();
    Map<String,Id> mapPriceBookEntryId = new Map<String,Id>();
    for (CSVUpload__c u : Trigger.new) {
        accounts.add(new Account(
                Name = u.FirstName__c + ' ' + u.LastName__c
        ));
        contacts.add(new Contact(
                FirstName = u.FirstName__c,
                LastName = u.LastName__c,
                MailingStreet = u.Address__c,
                MailingCity = u.City__c,
                MailingStateCode = u.State__c,
                MailingPostalCode = u.Zip__c,
                HomePhone = u.HomePhone__c,
                OtherPhone = u.BusinessPhone__c,
                MobilePhone = u.MobilePhone__c,
                Email = u.EmailAddress__C,
                Title = u.Title__c,
                Fax = u.FaxNo__c
        ));
        boats.add(new Boat__c(
               Address__c = u.BoatAddress__c,
               City__c = u.BoatCity__c,
               State__c = u.BoatState__c,
               Zip__c = u.BoatZip__c,
               Country__c = u.BoatCountry__c
        ));
        memberships.add(new Membership__c(
               Auto_Renew__c = u.AutoReNew__c,
               MemberSince__c = u.MemberSince__c,
               Expiration__c = u.ExpireDate__c,
               MemberSource__c = u.MemberSource__c,
               MemberStatus__c = u.MemberStatus__c,
               Trailer_Care__c = u.TrailerCoverage__c
        ));
        orders.add(new Order(
               Status = 'Draft',
               TypeAmt__c = u.TypeAmt__c,
               PoDate = u.TransDate__c,
               EffectiveDate = u.EffectiveDate__c
        ));
        promos.add(new Promotion_Code__c(
               Code__c = u.PromCode__c
        ));

        setMemberType.add(u.MemberType__c);
        // Start - Added to populate productOrders list with blank OrderItem
        productOrders.add(new OrderItem());
        // End - Added to populate productOrders list with blank OrderItem
    }
    insert accounts;
    for (Integer i = 0; i < accounts.size(); i++) {
        contacts[i].AccountId = accounts[i].Id;
        boats[i].Account__c = accounts[i].Id;
        memberships[i].Account__c = accounts[i].Id;
        orders[i].AccountId = accounts[i].Id;
    }

    insert contacts;
    insert boats;
    insert memberships;

    //for(Integer m = 0; m < memberships.size(); m++)
    //{
    //    orders[m].Membership__c = memberships[m].Id;
    //}

    insert orders;
    // Start
    for(Product2 p : [Select Id,Name From Product2 Where Name IN : setMemberType]) {
        mapMemberTypeProductId.put(p.Name,p.Id);
        setProductId.Add(p.Id);
    }
    // End
    //this is my effort, and it seems to be a poor one. 
    for(PriceBookEntry pe : [SELECT Id, Name FROM PriceBookEntry WHERE Product2Id IN : setProductId])
    {
        mapPriceBookEntryId.put(pe.Name, pe.Id);
    }
    for(Integer o = 0; o < orders.size(); o++)
    {
        promos[o].Order__c = orders[o].Id;      
        // Start - Added to update PriceBook2Id in Order before updating PriceBookEntryId in OrderItem
        orders[o].Pricebook2Id = mapPriceBookEntryId.get(Trigger.new[o].MemberType__c);
        // End - Added to update PriceBook2Id in Order before updating PriceBookEntryId in OrderItem
        productOrders[o].OrderId = orders[o].Id;//errors here
        productOrders[o].PriceBookEntryId= mapPriceBookEntryId.get(Trigger.new[o].MemberType__c);
        productOrders[o].Quantity = 1;
    }

    insert promos;
    insert productOrders;
    // Start - Commented and moved the code before order for loop
    /*for(Product2 p : [Select Id,Name From Product2 Where Name IN : setMemberType]) {
        mapMemberTypeProductId.put(p.Name,p.Id);
        setProductId.Add(p.Id);

    }*/
    // End - Commented and moved the code before order for loop

    for(Integer ms = 0; ms < memberships.size(); ms++)
    {
        memberships[ms].Product__c = mapMemberTypeProductId.get(Trigger.new[ms].MemberType__c);
    }

    update memberships;

}

Hope it helps.

[SalesForce] What value to assign at decimal/double variable in constructor in apex class

Apex handles the type conversion of numeric constants well for Decimals so you can initialize like this if you don't care about the number of decimal places (the scale):

Decimal price;
...
price = 0;

or like this if you want a specific number of decimal places (2 in this case):

Decimal price;
...
price = 0.00;

As Rahul suggests, your problem most likely lies in other code.

Best Answer

Related Solutions

[SalesForce] Create OrderItem (Order Product) from Bulk upload Object

[SalesForce] What value to assign at decimal/double variable in constructor in apex class

Related Topic